From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/3] Drop checking whether +CMER is supported.
Date: Mon, 17 Dec 2012 10:27:32 -0600 [thread overview]
Message-ID: <50CF47F4.8070700@gmail.com> (raw)
In-Reply-To: <1355761338-9081-3-git-send-email-mingli@southpole.se>
[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]
Hi Mingli,
On 12/17/2012 10:22 AM, Mingli Wu wrote:
> For Telit HE910, ofono always got "\r\n+CME ERROR: 14\r\n"
> after issuing "AT+CMER=3,0,0,2\r" command. "CME ERROR: 14"
> means that SIM is busy. Now we igonre the result of the
> command "AT+CMER=3,0,0,2\r", and register network anyway.
> ---
> drivers/atmodem/network-registration.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/atmodem/network-registration.c b/drivers/atmodem/network-registration.c
> index 19b19b2..518a548 100644
> --- a/drivers/atmodem/network-registration.c
> +++ b/drivers/atmodem/network-registration.c
> @@ -1480,7 +1480,6 @@ static void at_cmer_not_supported(struct ofono_netreg *netreg)
> ofono_error("+CMER not supported by this modem. If this is an error"
> " please submit patches to support this hardware");
>
> - ofono_netreg_remove(netreg);
You are changing the global behavior of the driver here. This affects
other modems than HE910...
> }
>
> static void at_cmer_set_cb(gboolean ok, GAtResult *result, gpointer user_data)
> @@ -1490,7 +1489,6 @@ static void at_cmer_set_cb(gboolean ok, GAtResult *result, gpointer user_data)
>
> if (!ok) {
> at_cmer_not_supported(netreg);
> - return;
> }
>
> /*
Regards,
-Denis
next prev parent reply other threads:[~2012-12-17 16:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 16:22 [PATCH 0/3] Telit HE910 Mingli Wu
2012-12-17 16:22 ` [PATCH 1/3] Support Telit cdc acm device Mingli Wu
2012-12-17 16:34 ` Denis Kenzior
2012-12-17 18:39 ` Ming Li Wu
2012-12-17 16:22 ` [PATCH 2/3] Drop checking whether +CMER is supported Mingli Wu
2012-12-17 16:27 ` Denis Kenzior [this message]
2012-12-18 10:08 ` Christopher Vogl
2012-12-17 16:22 ` [PATCH 3/3] Delay 10 seconds between CFUN=4 and CFUN=1 Mingli Wu
-- strict thread matches above, loose matches on Subject: below --
2013-03-29 15:40 [PATCH 2/3] Drop checking whether +CMER is supported Etienne Mabille
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CF47F4.8070700@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.