Re: [PATCH 1/3] Support Telit cdc acm device

[Ming Li Wu <mingli@southpole.se>]

[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]

Hi Denis,
>> +    /* This is for Telit HE910. */
>> +    if(udevng_match_modem_id(modem, "1bc7", "0021")){
>> +        options = g_hash_table_new(g_str_hash, g_str_equal);
>> +
>> +        if (options == NULL)
>> +            return NULL;
>> +
>> +        g_hash_table_insert(options, "Baud", "115200");
>> +        g_hash_table_insert(options, "Parity", "none");
>> +        g_hash_table_insert(options, "StopBits", "1");
>> +        g_hash_table_insert(options, "DataBits", "8");
>> +        g_hash_table_insert(options, "XonXoff", "off");
>> +        g_hash_table_insert(options, "Local", "on");
>> +        g_hash_table_insert(options, "RtsCts", "on");
>> +    }
>> +
>> +    channel = g_at_tty_open(device, options);
>> +    if(options){
>> +        g_hash_table_destroy(options);
>> +    }
>> +
>
> This was already taken care of by the patch from Christopher that was 
> applied today.
>

I have two questions about settings of serial ports:

1. Are the following settings necessary?
         g_hash_table_insert(options, "XonXoff", "off");
         g_hash_table_insert(options, "Local", "on");
         g_hash_table_insert(options, "RtsCts", "on");

2.Should settings of modem port and aux port be different?


Thanks!

Mingli