Re: [PATCH] xf86-video-imxfb-vivante: add dependency on X11

[Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>]

On 18.12.2012 13:10, Otavio Salvador wrote:
> On Tue, Dec 18, 2012 at 8:30 AM, Andrei Gherzan<andrei@gherzan.ro>  wrote:
>> On Tue, Dec 18, 2012 at 1:37 AM, Vladimir Zapolskiy
>> <vladimir_zapolskiy@mentor.com>  wrote:
>>>
>>> Prior to xf86-video-imxfs-vivante there should be built libX11.
>>>
>>> This change fixes an issue met on configuration stage:
>>>
>>>    | configure:3303: checking whether the C compiler works
>>>    | configure:3325: arm-mentor-linux-gnueabi-gcc  -march=armv7-a
>>> -mthumb-interwork -mfloat-abi=softfp -mfpu=neon -mtune=cortex-a9
>>> -mno-unaligned-access [snip] -lm -ldl -lGAL-x11 conftest.c>&5
>>>    |
>>> /opt/projects/mentor/thales-mel6.0/build/tmp/sysroots/imx6qsabrelite/usr/lib/libGAL-x11.so:
>>> undefined reference to `XWidthOfScreen'
>>>    [snip]
>>>    | collect2: ld returned 1 exit status
>>
>>
>> It's very strange that i never saw this issue before. I compiled this driver
>> a couple of times and didn't see this error. Maybe it was a race thing where
>> libx11 was compiled first but about that LDFLAGS, are you sure -lX11 is not
>> added by default?
>>
>> +1 for [meta-fsl-arm] prefix.
>
> Andrei is right Vladimir. Please check if LDFLAGS is really need and
> as Daiane said please bump PR.

Daiane, Andrei, Otavio, thanks for comments, I'll send the second
version of the patch for review.

-- 
With best wishes,
Vladimir