Re: [Qemu-devel] [PATCH qom-cpu v2 4/5] target-alpha: Turn CPU definitions into subclasses

["Andreas Färber" <afaerber@suse.de>]

Am 09.12.2012 02:40, schrieb Andreas Färber:
> Make TYPE_ALPHA_CPU abstract and add types <name>-alpha-cpu.
> Use type inheritence, and turn "2*" models into aliases.
> 
> Move cpu_alpha_init() to cpu.c and split out CPU realization.
> Default to creating type "ev67-alpha-cpu" as before.
> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target-alpha/cpu.c       |  178 +++++++++++++++++++++++++++++++++++++++++++++-
>  target-alpha/cpu.h       |    2 +
>  target-alpha/translate.c |   58 +--------------
>  3 Dateien geändert, 180 Zeilen hinzugefügt(+), 58 Zeilen entfernt(-)
> 
> diff --git a/target-alpha/cpu.c b/target-alpha/cpu.c
> index 11a19eb..11df753 100644
> --- a/target-alpha/cpu.c
> +++ b/target-alpha/cpu.c
> @@ -21,8 +21,175 @@
>  
>  #include "cpu.h"
>  #include "qemu-common.h"
> +#include "error.h"
>  
>  
> +static void alpha_cpu_realize(Object *obj, Error **err)

Should've been errp by convention, fixed.
No functional change since unused.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg