Question regarding patches

Question regarding patches

[Shraddha Kamat]

Sorry if this is not relevant to kernel. But since I am 
patching the kernel - Please consider this as a uber beginner
question to ask on this mailing list - forgive me for that.

Now my question is - 

What "@@ -321,7 +321,8 @@" mean in this snippet from the patch -  

diff --git a/exec.h b/exec.h
index 722c620..6abb687 100644
--- a/exec.h
+++ b/exec.h
@@ -321,7 +321,8 @@ static void acct_arg_size(struct linux_binprm *bprm,
unsigned long pages);

-- Shraddha 

Question regarding patches

[Jeff Kirsher]

On 12/19/2012 12:47 AM, Shraddha Kamat wrote:
> Sorry if this is not relevant to kernel. But since I am 
> patching the kernel - Please consider this as a uber beginner
> question to ask on this mailing list - forgive me for that.
>
> Now my question is - 
>
> What "@@ -321,7 +321,8 @@" mean in this snippet from the patch -  

The first number -321 means the line number of the original file that
the change takes place.  The next number & means that before the change,
there were 7 lines of code.  The next number +321 is the line number
after the change.  Since this is the first (and only change) it is the
same as the first number.  If there multiple changes in a patch, this
number can differ greatly from the first number.  The last number is the
lines of code after the change.
>
> diff --git a/exec.h b/exec.h
> index 722c620..6abb687 100644
> --- a/exec.h
> +++ b/exec.h
> @@ -321,7 +321,8 @@ static void acct_arg_size(struct linux_binprm *bprm,
> unsigned long pages);
>
> -- Shraddha 
>
>
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20121219/cb9f2f39/attachment.bin 

Question regarding patches

[Lijo Antony]

On 12/19/2012 12:47 PM, Shraddha Kamat wrote:
> Sorry if this is not relevant to kernel. But since I am
> patching the kernel - Please consider this as a uber beginner
> question to ask on this mailing list - forgive me for that.
>
> Now my question is -
>
> What "@@ -321,7 +321,8 @@" mean in this snippet from the patch -
>
> diff --git a/exec.h b/exec.h
> index 722c620..6abb687 100644
> --- a/exec.h
> +++ b/exec.h
> @@ -321,7 +321,8 @@ static void acct_arg_size(struct linux_binprm *bprm,
> unsigned long pages);
>

http://www.gnu.org/software/diffutils/manual/html_node/Detailed-Unified.html
http://www.artima.com/weblogs/viewpost.jsp?thread=164293

-lijo

> -- Shraddha
>
>
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>

Question regarding patches

[Shraddha Kamat]

On Wed, 2012-12-19 at 13:58 +0400, Lijo Antony wrote:
> On 12/19/2012 12:47 PM, Shraddha Kamat wrote:
> > Sorry if this is not relevant to kernel. But since I am
> > patching the kernel - Please consider this as a uber beginner
> > question to ask on this mailing list - forgive me for that.
> >
> > Now my question is -
> >
> > What "@@ -321,7 +321,8 @@" mean in this snippet from the patch -
> >
> > diff --git a/exec.h b/exec.h
> > index 722c620..6abb687 100644
> > --- a/exec.h
> > +++ b/exec.h
> > @@ -321,7 +321,8 @@ static void acct_arg_size(struct linux_binprm *bprm,
> > unsigned long pages);
> >
> 
> http://www.gnu.org/software/diffutils/manual/html_node/Detailed-Unified.html
> http://www.artima.com/weblogs/viewpost.jsp?thread=164293
> 
> -lijo
> 
But I don't see any mention of the "index" field here // 
see line "index 722c620..6abb687 100644". What does this mean ?

> > -- Shraddha
> >
> >
> >
> > _______________________________________________
> > Kernelnewbies mailing list
> > Kernelnewbies at kernelnewbies.org
> > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
> >
> 
> 
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

-- Shraddha 

Question regarding patches

[devendra.aaru]

On Wed, Dec 19, 2012 at 5:13 AM, Shraddha Kamat <sh2008ka@gmail.com> wrote:
> On Wed, 2012-12-19 at 13:58 +0400, Lijo Antony wrote:
>> On 12/19/2012 12:47 PM, Shraddha Kamat wrote:
>> > Sorry if this is not relevant to kernel. But since I am
>> > patching the kernel - Please consider this as a uber beginner
>> > question to ask on this mailing list - forgive me for that.
>> >
>> > Now my question is -
>> >
>> > What "@@ -321,7 +321,8 @@" mean in this snippet from the patch -
>> >
>> > diff --git a/exec.h b/exec.h
>> > index 722c620..6abb687 100644
>> > --- a/exec.h
>> > +++ b/exec.h
>> > @@ -321,7 +321,8 @@ static void acct_arg_size(struct linux_binprm *bprm,
>> > unsigned long pages);
>> >
>>
>> http://www.gnu.org/software/diffutils/manual/html_node/Detailed-Unified.html
>> http://www.artima.com/weblogs/viewpost.jsp?thread=164293
>>
>> -lijo
>>
> But I don't see any mention of the "index" field here //
> see line "index 722c620..6abb687 100644". What does this mean ?
>
the index 7222...6bbb are may be the git ids or some git's references...

100644 is the file mode.

Question regarding patches

[Avinash Patil]

I think those are git commit IDs.

-Avinash


On Wed, Dec 19, 2012 at 3:43 PM, Shraddha Kamat <sh2008ka@gmail.com> wrote:

> On Wed, 2012-12-19 at 13:58 +0400, Lijo Antony wrote:
> > On 12/19/2012 12:47 PM, Shraddha Kamat wrote:
> > > Sorry if this is not relevant to kernel. But since I am
> > > patching the kernel - Please consider this as a uber beginner
> > > question to ask on this mailing list - forgive me for that.
> > >
> > > Now my question is -
> > >
> > > What "@@ -321,7 +321,8 @@" mean in this snippet from the patch -
> > >
> > > diff --git a/exec.h b/exec.h
> > > index 722c620..6abb687 100644
> > > --- a/exec.h
> > > +++ b/exec.h
> > > @@ -321,7 +321,8 @@ static void acct_arg_size(struct linux_binprm
> *bprm,
> > > unsigned long pages);
> > >
> >
> >
> http://www.gnu.org/software/diffutils/manual/html_node/Detailed-Unified.html
> > http://www.artima.com/weblogs/viewpost.jsp?thread=164293
> >
> > -lijo
> >
> But I don't see any mention of the "index" field here //
> see line "index 722c620..6abb687 100644". What does this mean ?
>
> > > -- Shraddha
> > >
> > >
> > >
> > > _______________________________________________
> > > Kernelnewbies mailing list
> > > Kernelnewbies at kernelnewbies.org
> > > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
> > >
> >
> >
> > _______________________________________________
> > Kernelnewbies mailing list
> > Kernelnewbies at kernelnewbies.org
> > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>
> -- Shraddha
>
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20121219/3d362e3d/attachment.html 

Question regarding patches

[Tobias Boege]

On Wed, 19 Dec 2012, Shraddha Kamat wrote:
> On Wed, 2012-12-19 at 13:58 +0400, Lijo Antony wrote:
> > On 12/19/2012 12:47 PM, Shraddha Kamat wrote:
> > > Sorry if this is not relevant to kernel. But since I am
> > > patching the kernel - Please consider this as a uber beginner
> > > question to ask on this mailing list - forgive me for that.
> > >
> > > Now my question is -
> > >
> > > What "@@ -321,7 +321,8 @@" mean in this snippet from the patch -
> > >
> > > diff --git a/exec.h b/exec.h
> > > index 722c620..6abb687 100644
> > > --- a/exec.h
> > > +++ b/exec.h
> > > @@ -321,7 +321,8 @@ static void acct_arg_size(struct linux_binprm *bprm,
> > > unsigned long pages);
> > >
> > 
> > http://www.gnu.org/software/diffutils/manual/html_node/Detailed-Unified.html
> > http://www.artima.com/weblogs/viewpost.jsp?thread=164293
> > 
> > -lijo
> > 
> But I don't see any mention of the "index" field here // 
> see line "index 722c620..6abb687 100644". What does this mean ?

See "man git-diff" (GENERATING PATCHES WITH -P) for the information.

Regards,
Tobi

Question regarding patches

[Anand Arumugam]

On Wed, Dec 19, 2012 at 2:13 AM, Shraddha Kamat <sh2008ka@gmail.com> wrote:

> On Wed, 2012-12-19 at 13:58 +0400, Lijo Antony wrote:
> > On 12/19/2012 12:47 PM, Shraddha Kamat wrote:
> > > Sorry if this is not relevant to kernel. But since I am
> > > patching the kernel - Please consider this as a uber beginner
> > > question to ask on this mailing list - forgive me for that.
> > >
> > > Now my question is -
> > >
> > > What "@@ -321,7 +321,8 @@" mean in this snippet from the patch -
> > >
> > > diff --git a/exec.h b/exec.h
> > > index 722c620..6abb687 100644
> > > --- a/exec.h
> > > +++ b/exec.h
> > > @@ -321,7 +321,8 @@ static void acct_arg_size(struct linux_binprm
> *bprm,
> > > unsigned long pages);
> > >
> >
> >
> http://www.gnu.org/software/diffutils/manual/html_node/Detailed-Unified.html
> > http://www.artima.com/weblogs/viewpost.jsp?thread=164293
> >
> > -lijo
> >
> But I don't see any mention of the "index" field here //
> see line "index 722c620..6abb687 100644". What does this mean ?
>
>
'722c620' is the commit id in which a/exec.h is part of and
'6abb687' is the commit id in which b/exec.h is part of. 'a' and 'b' are
not folders. Its just a notation that diff uses for left and right side.

to know more on git look here: http://git-scm.com/book
and git diff in particular look at the man page or search for "git diff"
and you get a lot of links that explains it...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20121219/425bca1d/attachment.html 

Question regarding patches

[Shraddha Barke]

[-- Attachment #1.1: Type: text/plain, Size: 242 bytes --]

I want to do 2 changes in same header file - 1. Remove unused functions and 
2. Remove the function declarations of static functions.
Should I split this up into separate patches considering that it is the 
same header? 

Thanks,

Shraddha  

[-- Attachment #1.2: Type: text/html, Size: 280 bytes --]