All of lore.kernel.org
 help / color / mirror / Atom feed
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: cache: flush to LoUU instead of LoUIS on uniprocessor CPUs
Date: Thu, 20 Dec 2012 12:36:20 +0530	[thread overview]
Message-ID: <50D2B8EC.9040306@ti.com> (raw)
In-Reply-To: <1355760642-28559-1-git-send-email-will.deacon@arm.com>

On Monday 17 December 2012 09:40 PM, Will Deacon wrote:
> flush_cache_louis flushes the D-side caches to the point of unification
> inner-shareable. On uniprocessor CPUs, this is defined as zero and
> therefore no flushing will take place. Rather than invent a new interface
> for UP systems, instead use our SMP_ON_UP patching code to read the
> LoUU from the CLIDR instead.
>
> Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> Tested-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
> ---
Looks reasonable idea.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

>   arch/arm/mm/cache-v7.S | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mm/cache-v7.S b/arch/arm/mm/cache-v7.S
> index cd95664..7539ec2 100644
> --- a/arch/arm/mm/cache-v7.S
> +++ b/arch/arm/mm/cache-v7.S
> @@ -44,8 +44,10 @@ ENDPROC(v7_flush_icache_all)
>   ENTRY(v7_flush_dcache_louis)
>   	dmb					@ ensure ordering with previous memory accesses
>   	mrc	p15, 1, r0, c0, c0, 1		@ read clidr, r0 = clidr
> -	ands	r3, r0, #0xe00000		@ extract LoUIS from clidr
> -	mov	r3, r3, lsr #20			@ r3 = LoUIS * 2
> +	ALT_SMP(ands	r3, r0, #(7 << 21))	@ extract LoUIS from clidr
> +	ALT_UP(ands	r3, r0, #(7 << 27))	@ extract LoUU from clidr
> +	ALT_SMP(mov	r3, r3, lsr #20)	@ r3 = LoUIS * 2
> +	ALT_UP(mov	r3, r3, lsr #26)	@ r3 = LoUU * 2
>   	moveq	pc, lr				@ return if level == 0
>   	mov	r10, #0				@ r10 (starting level) = 0
>   	b	flush_levels			@ start flushing cache levels
>

      parent reply	other threads:[~2012-12-20  7:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-17 16:10 [PATCH] ARM: cache: flush to LoUU instead of LoUIS on uniprocessor CPUs Will Deacon
2012-12-17 20:19 ` Nicolas Pitre
2012-12-18 10:07   ` Will Deacon
2012-12-20  7:06 ` Santosh Shilimkar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50D2B8EC.9040306@ti.com \
    --to=santosh.shilimkar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.