All of lore.kernel.org
 help / color / mirror / Atom feed
From: ludovic.desroches@atmel.com (ludovic.desroches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: AT91: IIO: add low and high res support for adc
Date: Thu, 20 Dec 2012 17:13:52 +0100	[thread overview]
Message-ID: <50D33940.4000607@atmel.com> (raw)
In-Reply-To: <50D3340F.3090209@free-electrons.com>

On 12/20/2012 04:51 PM, Maxime Ripard wrote:
> Hi Ludovic,
>
> Le 20/12/2012 11:52, ludovic.desroches a ?crit :
>>> I'm wondering, why are you using such a complex dt parsing code, and
>>> bindings, when you only requires a boolean to switch between 8 and 10
>>> bits mode (which seem to be the only thing you support)?
>>
>> We will have a 10 and 12 bits mode on future ADCs and I would like to
>> have something which could manage more than two resolutions if it
>> happens one day.
>
> I see your point. I'm not fond at all of the existing bindings for the
> driver (putting things like registers offset in the dt is a non-sense to
> me, but hey...), so I'd like to still keep it as simple and non-bloated
> as possible, but it's true that in the current situation, we probably
> have no other choice.
>

I have the same feeling than you about ADC bindings, I think that there 
are too many parameters exhibited. Moreover, most of them are chip relative.

I have not found other ways to deal with it properly. I would like to 
have them hidden into the driver (depending on the compatible string) 
but it will be a mess if we split parameters into dt and driver.

So the idea was to have a binding which could allow us to manage several 
cases about resolution modes in the future.

Ludovic

> Maxime
>

  reply	other threads:[~2012-12-20 16:13 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-19 18:32 [PATCH 0/3] IIO: AT91: add lowres, sleep and sample&hold time missing support Jean-Christophe PLAGNIOL-VILLARD
2012-12-19 18:32 ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-19 18:37 ` [PATCH 1/3] ARM: AT91: IIO: add low and high res support for adc Jean-Christophe PLAGNIOL-VILLARD
2012-12-19 18:37   ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-19 18:37   ` [PATCH 2/3] ARM: AT91: IIO: add sleep mode support Jean-Christophe PLAGNIOL-VILLARD
2012-12-19 18:37     ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-20 10:46     ` Maxime Ripard
2012-12-20 10:46       ` Maxime Ripard
2012-12-27 12:09       ` Jonathan Cameron
2012-12-27 12:09         ` Jonathan Cameron
2012-12-27 17:54     ` Maxime Ripard
2012-12-27 17:54       ` Maxime Ripard
2012-12-19 18:37   ` [PATCH 3/3] ARM: AT91: IIO: fix missing Sample and Hold time Jean-Christophe PLAGNIOL-VILLARD
2012-12-19 18:37     ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-20 10:55     ` Maxime Ripard
2012-12-20 10:55       ` Maxime Ripard
2012-12-20 12:49       ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-20 12:49         ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-21  9:08         ` Maxime Ripard
2012-12-21  9:08           ` Maxime Ripard
2012-12-20 10:42   ` [PATCH 1/3] ARM: AT91: IIO: add low and high res support for adc Maxime Ripard
2012-12-20 10:42     ` Maxime Ripard
2012-12-20 10:52     ` ludovic.desroches
2012-12-20 15:51       ` Maxime Ripard
2012-12-20 15:51         ` Maxime Ripard
2012-12-20 16:13         ` ludovic.desroches [this message]
2012-12-21  9:07           ` Maxime Ripard
2012-12-21  9:07             ` Maxime Ripard
2012-12-22 17:21             ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-22 17:21               ` Jean-Christophe PLAGNIOL-VILLARD
2013-01-07  9:20               ` Maxime Ripard
2013-01-07  9:20                 ` Maxime Ripard
2012-12-20 10:40 ` [PATCH 0/3] IIO: AT91: add lowres, sleep and sample&hold time missing support Maxime Ripard
2012-12-20 10:40   ` Maxime Ripard
2012-12-20 10:51 ` Nicolas Ferre
2012-12-20 10:51   ` Nicolas Ferre
2012-12-27 12:14   ` Jonathan Cameron
2012-12-27 12:14     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50D33940.4000607@atmel.com \
    --to=ludovic.desroches@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.