From: Subash Patel <subashrp@gmail.com>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Olof Johansson <olof@lixom.net>,
linux-samsung-soc@vger.kernel.org,
Kukjin Kim <kgene.kim@samsung.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: fix split memory bank for SSDK5440
Date: Thu, 20 Dec 2012 14:19:48 -0800 [thread overview]
Message-ID: <50D38F04.8020307@gmail.com> (raw)
In-Reply-To: <1464138.NEt7mMkYJc@flatron>
I would like to ask a question here. Do we need to have sparse even if
the physical memory is contiguous? All the recent exynos machines come
with physical banks without any holes, and I am thinking why not drop it
and use flat mem instead. With LPAE these sections sizes wont be useful,
and I dont like to keep different section sizes for different
configurations. Any suggestions/opinions are very much helpful to me.
Regards,
Subash
On Thursday 20 December 2012 01:14 PM, Tomasz Figa wrote:
> Hi Olof,
>
> On Thursday 20 of December 2012 11:56:59 Olof Johansson wrote:
>> Hi,
>>
>> On Thu, Dec 20, 2012 at 11:03 AM, Kukjin Kim <kgene.kim@samsung.com>
> wrote:
>>> The size of memory bank should be under 256MB, because current
>>> section size is 256MB on EXYNOS SoCs. This patch fixes it.
>>
>> This makes no sense. You don't have to split up memory ranges, the
>> code should be made to handle it instead.
>
> It's not Exynos code which causes the problem. Sparsemem initialization
> relies on the fact that initial amount of structures to described memory
> equals to maximum section size which is defined per arch (e.g.
> ARCH_EXYNOS).
>
>> What's the actual bug caused by this? The description is vague.
>
> The kernel panics early on NULL pointer dereference in memory
> initialization.
>
> Best regards,
> Tomasz Figa
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: subashrp@gmail.com (Subash Patel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: fix split memory bank for SSDK5440
Date: Thu, 20 Dec 2012 14:19:48 -0800 [thread overview]
Message-ID: <50D38F04.8020307@gmail.com> (raw)
In-Reply-To: <1464138.NEt7mMkYJc@flatron>
I would like to ask a question here. Do we need to have sparse even if
the physical memory is contiguous? All the recent exynos machines come
with physical banks without any holes, and I am thinking why not drop it
and use flat mem instead. With LPAE these sections sizes wont be useful,
and I dont like to keep different section sizes for different
configurations. Any suggestions/opinions are very much helpful to me.
Regards,
Subash
On Thursday 20 December 2012 01:14 PM, Tomasz Figa wrote:
> Hi Olof,
>
> On Thursday 20 of December 2012 11:56:59 Olof Johansson wrote:
>> Hi,
>>
>> On Thu, Dec 20, 2012 at 11:03 AM, Kukjin Kim <kgene.kim@samsung.com>
> wrote:
>>> The size of memory bank should be under 256MB, because current
>>> section size is 256MB on EXYNOS SoCs. This patch fixes it.
>>
>> This makes no sense. You don't have to split up memory ranges, the
>> code should be made to handle it instead.
>
> It's not Exynos code which causes the problem. Sparsemem initialization
> relies on the fact that initial amount of structures to described memory
> equals to maximum section size which is defined per arch (e.g.
> ARCH_EXYNOS).
>
>> What's the actual bug caused by this? The description is vague.
>
> The kernel panics early on NULL pointer dereference in memory
> initialization.
>
> Best regards,
> Tomasz Figa
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-12-20 22:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 19:03 [PATCH] ARM: dts: fix split memory bank for SSDK5440 Kukjin Kim
2012-12-20 19:03 ` Kukjin Kim
2012-12-20 19:56 ` Olof Johansson
2012-12-20 19:56 ` Olof Johansson
2012-12-20 21:14 ` Tomasz Figa
2012-12-20 21:14 ` Tomasz Figa
2012-12-20 22:19 ` Subash Patel [this message]
2012-12-20 22:19 ` Subash Patel
2012-12-20 23:18 ` Tomasz Figa
2012-12-20 23:18 ` Tomasz Figa
2012-12-21 0:43 ` Kukjin Kim
2012-12-21 0:43 ` Kukjin Kim
2012-12-20 23:41 ` Russell King - ARM Linux
2012-12-20 23:41 ` Russell King - ARM Linux
2012-12-21 0:32 ` Kukjin Kim
2012-12-21 0:32 ` Kukjin Kim
2012-12-21 0:35 ` Olof Johansson
2012-12-21 0:35 ` Olof Johansson
2012-12-21 0:56 ` Cho KyongHo
2012-12-21 0:56 ` Cho KyongHo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D38F04.8020307@gmail.com \
--to=subashrp@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.