All of lore.kernel.org
 help / color / mirror / Atom feed
From: Donghwa Lee <dh09.lee@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 2/4] EXYNOS: Add dummy definition to fix compilation dependency on CONFIG_EXYNOS_MIPI_DSIM
Date: Fri, 21 Dec 2012 10:47:18 +0900	[thread overview]
Message-ID: <50D3BFA6.5010208@samsung.com> (raw)
In-Reply-To: <1356006906-31510-3-git-send-email-ajaykumar.rs@samsung.com>

On 2012? 12? 20? 21:35, Ajay Kumar wrote:
> When only DP is used, we need not enable CONFIG_EXYNOS_MIPI_DSIM.
> But if we do not select CONFIG_EXYNOS_MIPI_DSIM, exynos_fb.c throws
> error saying exynos_mipi_dsi_init() not defined. So, we add
> dummy definition for exynos_mipi_dsi_init when CONFIG_EXYNOS_MIPI_DSIM
> is not defined.
>
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> ---
>   arch/arm/include/asm/arch-exynos/mipi_dsim.h |    7 +++++++
>   1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-exynos/mipi_dsim.h b/arch/arm/include/asm/arch-exynos/mipi_dsim.h
> index 9a7cbeb..b73263d 100644
> --- a/arch/arm/include/asm/arch-exynos/mipi_dsim.h
> +++ b/arch/arm/include/asm/arch-exynos/mipi_dsim.h
> @@ -358,7 +358,14 @@ struct mipi_dsim_lcd_driver {
>   	void	(*mipi_display_on)(struct mipi_dsim_device *dsim_dev);
>   };
>   
> +#ifdef CONFIG_EXYNOS_MIPI_DSIM
>   int exynos_mipi_dsi_init(void);
> +#else
> +int exynos_mipi_dsi_init(void)
> +{
> +	return 0;
> +}
> +#endif
>   
>   /*
>    * register mipi_dsim_lcd_driver object defined by lcd panel driver
It looks good to me.
Acked-by: Donghwa Lee <dh09.lee@samsung.com>

Thank you,
Donghwa Lee

  parent reply	other threads:[~2012-12-21  1:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-20 12:35 [U-Boot] [PATCH V3 0/4] Add support for FIMD and DP on SMDK5250 Ajay Kumar
2012-12-20 12:35 ` [U-Boot] [PATCH RESEND V2 1/4] EXYNOS5: Change parent clock of FIMD to MPLL Ajay Kumar
2012-12-21  1:46   ` Donghwa Lee
2012-12-20 12:35 ` [U-Boot] [PATCH V3 2/4] EXYNOS: Add dummy definition to fix compilation dependency on CONFIG_EXYNOS_MIPI_DSIM Ajay Kumar
2012-12-20 20:40   ` Simon Glass
2012-12-21  1:47   ` Donghwa Lee [this message]
2012-12-20 12:35 ` [U-Boot] [PATCH V3 3/4] video: Modify exynos_fimd driver to support LCD console Ajay Kumar
2012-12-20 20:46   ` Simon Glass
2012-12-21  1:53   ` Donghwa Lee
2012-12-21  2:59     ` Minkyu Kang
2012-12-20 12:35 ` [U-Boot] [PATCH V3 4/4] EXYNOS5: Add support for FIMD and DP Ajay Kumar
2012-12-20 20:47   ` Simon Glass
  -- strict thread matches above, loose matches on Subject: below --
2013-01-08  7:32 [U-Boot] [PATCH V5 0/4] Add support for FIMD and DP on SMDK5250 Ajay Kumar
2013-01-08  7:32 ` [U-Boot] [PATCH V3 2/4] EXYNOS: Add dummy definition to fix compilation dependency on CONFIG_EXYNOS_MIPI_DSIM Ajay Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50D3BFA6.5010208@samsung.com \
    --to=dh09.lee@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.