From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/5] ARM: remove useless guard in smp.c
Date: Fri, 21 Dec 2012 15:32:01 +0530 [thread overview]
Message-ID: <50D43399.7010705@ti.com> (raw)
In-Reply-To: <1355832418-31692-2-git-send-email-mark.rutland@arm.com>
On Tuesday 18 December 2012 05:36 PM, Mark Rutland wrote:
> Currently we only provide an implementation of smp_timer_broadcast in
> smp.c if GENERIC_CLOCKEVENTS_BROADCAST is selected. As
> smp_timer_broadcast is only used in smp.c, smp.c depends on SMP, and
> GENERIC_CLOCKEVENTS_BROADCAST is selected by SMP, this is unnecessary.
>
> This patch removes the redundant guard.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> ---
CONFIG_GENERIC_CLOCKEVENTS_BROADCAST isn't mandatory to
have SMP kernel working so the below select in ARM arch
kconfig not seems to entirely accurate. SMP kernel will
still boot with !GENERIC_CLOCKEVENTS_BROADCAST.
select GENERIC_CLOCKEVENTS_BROADCAST if SMP
The issue comes only for deeper CPU power C-states.
Anyway, you patch is correct from the current code point of
view.
Regards
Santosh
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: <linux-kernel@vger.kernel.org>, <linux@arm.linux.org.uk>,
<nico@linaro.org>, <marc.zyngier@arm.com>, <will.deacon@arm.com>,
<john.stultz@linaro.org>, <tglx@linutronix.de>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 1/5] ARM: remove useless guard in smp.c
Date: Fri, 21 Dec 2012 15:32:01 +0530 [thread overview]
Message-ID: <50D43399.7010705@ti.com> (raw)
In-Reply-To: <1355832418-31692-2-git-send-email-mark.rutland@arm.com>
On Tuesday 18 December 2012 05:36 PM, Mark Rutland wrote:
> Currently we only provide an implementation of smp_timer_broadcast in
> smp.c if GENERIC_CLOCKEVENTS_BROADCAST is selected. As
> smp_timer_broadcast is only used in smp.c, smp.c depends on SMP, and
> GENERIC_CLOCKEVENTS_BROADCAST is selected by SMP, this is unnecessary.
>
> This patch removes the redundant guard.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> ---
CONFIG_GENERIC_CLOCKEVENTS_BROADCAST isn't mandatory to
have SMP kernel working so the below select in ARM arch
kconfig not seems to entirely accurate. SMP kernel will
still boot with !GENERIC_CLOCKEVENTS_BROADCAST.
select GENERIC_CLOCKEVENTS_BROADCAST if SMP
The issue comes only for deeper CPU power C-states.
Anyway, you patch is correct from the current code point of
view.
Regards
Santosh
next prev parent reply other threads:[~2012-12-21 10:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 12:06 [RFC PATCH 0/5] clockevents: decouple broadcast mechanism from drivers Mark Rutland
2012-12-18 12:06 ` Mark Rutland
2012-12-18 12:06 ` [RFC PATCH 1/5] ARM: remove useless guard in smp.c Mark Rutland
2012-12-18 12:06 ` Mark Rutland
2012-12-18 18:47 ` Stephen Boyd
2012-12-18 18:47 ` Stephen Boyd
2012-12-19 9:40 ` Mark Rutland
2012-12-19 9:40 ` Mark Rutland
2012-12-21 10:02 ` Santosh Shilimkar [this message]
2012-12-21 10:02 ` Santosh Shilimkar
2013-01-02 11:14 ` Mark Rutland
2013-01-02 11:14 ` Mark Rutland
2012-12-18 12:06 ` [RFC PATCH 2/5] clockevents: Add generic timer broadcast receiver Mark Rutland
2012-12-18 12:06 ` Mark Rutland
2012-12-18 22:17 ` Stephen Boyd
2012-12-18 22:17 ` Stephen Boyd
2012-12-19 10:19 ` Mark Rutland
2012-12-19 10:19 ` Mark Rutland
2012-12-21 10:02 ` Santosh Shilimkar
2012-12-21 10:02 ` Santosh Shilimkar
2013-01-02 10:59 ` Mark Rutland
2013-01-02 10:59 ` Mark Rutland
2012-12-18 12:06 ` [RFC PATCH 3/5] ARM: Use generic timer broadcast receive Mark Rutland
2012-12-18 12:06 ` Mark Rutland
2012-12-18 12:06 ` [RFC PATCH 4/5] clockevents: Add generic timer broadcast function Mark Rutland
2012-12-18 12:06 ` Mark Rutland
2012-12-18 22:17 ` Stephen Boyd
2012-12-18 22:17 ` Stephen Boyd
2012-12-19 10:37 ` Mark Rutland
2012-12-19 10:37 ` Mark Rutland
2012-12-18 12:06 ` [RFC PATCH 5/5] ARM: Add generic timer broadcast support Mark Rutland
2012-12-18 12:06 ` Mark Rutland
2012-12-21 10:08 ` [RFC PATCH 0/5] clockevents: decouple broadcast mechanism from drivers Santosh Shilimkar
2012-12-21 10:08 ` Santosh Shilimkar
2013-01-02 11:41 ` Mark Rutland
2013-01-02 11:41 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D43399.7010705@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.