[U-Boot] [PATCH V4 0/4] Add support for FIMD and DP on SMDK5250

[U-Boot] [PATCH V4 0/4] Add support for FIMD and DP on SMDK5250

[Ajay Kumar]

Changes since V3:
	-- Make the dummy definition for "exynos_mipi_dsi_init" static and inline.
	-- Remove #ifdef, instead use logo_on field to add LCD console support.

 [PATCH V2 RESEND 1/4] EXYNOS5: Change parent clock of FIMD to MPLL
 [PATCH V2 2/4] EXYNOS: Add dummy definition to fix compilation dependency on
			CONFIG_EXYNOS_MIPI_DSIM
 [PATCH V4 3/4] video: Modify exynos_fimd driver to support LCD console
 [PATCH V4 4/4] EXYNOS5: Add support for FIMD and DP

 arch/arm/cpu/armv7/exynos/clock.c            |    2 +-
 arch/arm/include/asm/arch-exynos/mipi_dsim.h |    7 ++
 board/samsung/smdk5250/smdk5250.c            |   97 ++++++++++++++++++++++++++
 drivers/video/exynos_fb.c                    |    7 ++
 drivers/video/exynos_fimd.c                  |   12 ++-
 include/configs/smdk5250.h                   |    8 ++
 6 files changed, 128 insertions(+), 5 deletions(-)

[U-Boot] [PATCH V2 RESEND 1/4] EXYNOS5: Change parent clock of FIMD to MPLL

[Ajay Kumar]

With VPLL as source clock to FIMD,
Exynos DP Initializaton was failing sometimes with unstable clock.
Changing FIMD source to MPLL resolves this issue.

Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
Acked-by: Simon Glass <sjg@chromium.org>
Acked-by: Donghwa Lee <dh09.lee@samsung.com>
---
 arch/arm/cpu/armv7/exynos/clock.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/cpu/armv7/exynos/clock.c b/arch/arm/cpu/armv7/exynos/clock.c
index fe61f88..bfcd5f7 100644
--- a/arch/arm/cpu/armv7/exynos/clock.c
+++ b/arch/arm/cpu/armv7/exynos/clock.c
@@ -603,7 +603,7 @@ void exynos5_set_lcd_clk(void)
 	 */
 	cfg = readl(&clk->src_disp1_0);
 	cfg &= ~(0xf);
-	cfg |= 0x8;
+	cfg |= 0x6;
 	writel(cfg, &clk->src_disp1_0);
 
 	/*
-- 
1.7.1

[U-Boot] [PATCH V2 2/4] EXYNOS: Add dummy definition to fix compilation dependency on CONFIG_EXYNOS_MIPI_DSIM

[Ajay Kumar]

When only DP is used, we need not enable CONFIG_EXYNOS_MIPI_DSIM.
But if we do not select CONFIG_EXYNOS_MIPI_DSIM, exynos_fb.c throws
error saying exynos_mipi_dsi_init() not defined. So, we add
dummy definition for exynos_mipi_dsi_init when CONFIG_EXYNOS_MIPI_DSIM
is not defined.

Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
Acked-by: Simon Glass <sjg@chromium.org>
Acked-by: Donghwa Lee <dh09.lee@samsung.com>
---
 arch/arm/include/asm/arch-exynos/mipi_dsim.h |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/arch/arm/include/asm/arch-exynos/mipi_dsim.h b/arch/arm/include/asm/arch-exynos/mipi_dsim.h
index 9a7cbeb..c1c9a35 100644
--- a/arch/arm/include/asm/arch-exynos/mipi_dsim.h
+++ b/arch/arm/include/asm/arch-exynos/mipi_dsim.h
@@ -358,7 +358,14 @@ struct mipi_dsim_lcd_driver {
 	void	(*mipi_display_on)(struct mipi_dsim_device *dsim_dev);
 };
 
+#ifdef CONFIG_EXYNOS_MIPI_DSIM
 int exynos_mipi_dsi_init(void);
+#else
+static inline int exynos_mipi_dsi_init(void)
+{
+	return 0;
+}
+#endif
 
 /*
  * register mipi_dsim_lcd_driver object defined by lcd panel driver
-- 
1.7.1

[U-Boot] [PATCH V4 3/4] video: Modify exynos_fimd driver to support LCD console

[Ajay Kumar]

Currently, exynos FIMD driver is being used to support only TIZEN LOGOs.
In order to get LCD console, we need to enable half word swap feature
of FIMD and use 16 BPP.
LCD console and proprietary Logo cannot be used simultaneously.
We use logo_on field inside vidinfo_t structure to decide whether
user wants Logo or Console.

Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
---
 drivers/video/exynos_fb.c   |    7 +++++++
 drivers/video/exynos_fimd.c |   12 ++++++++----
 2 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/drivers/video/exynos_fb.c b/drivers/video/exynos_fb.c
index d9a3f9a..ee916be 100644
--- a/drivers/video/exynos_fb.c
+++ b/drivers/video/exynos_fb.c
@@ -45,6 +45,13 @@ short console_row;
 
 static unsigned int panel_width, panel_height;
 
+#ifndef CONFIG_CMD_BMP
+int bmp_display(ulong addr, int x, int y)
+{
+	return 0;
+}
+#endif
+
 static void exynos_lcd_init_mem(void *lcdbase, vidinfo_t *vid)
 {
 	unsigned long palette_size;
diff --git a/drivers/video/exynos_fimd.c b/drivers/video/exynos_fimd.c
index 06eae2e..f957dc8 100644
--- a/drivers/video/exynos_fimd.c
+++ b/drivers/video/exynos_fimd.c
@@ -88,14 +88,18 @@ static void exynos_fimd_set_par(unsigned int win_id)
 	/* DATAPATH is DMA */
 	cfg |= EXYNOS_WINCON_DATAPATH_DMA;
 
-	/* bpp is 32 */
-	cfg |= EXYNOS_WINCON_WSWP_ENABLE;
+	if (pvid->logo_on) /* To get proprietary LOGO */
+		cfg |= EXYNOS_WINCON_WSWP_ENABLE;
+	else /* To get output console on LCD */
+		cfg |= EXYNOS_WINCON_HAWSWP_ENABLE;
 
 	/* dma burst is 16 */
 	cfg |= EXYNOS_WINCON_BURSTLEN_16WORD;
 
-	/* pixel format is unpacked RGB888 */
-	cfg |= EXYNOS_WINCON_BPPMODE_24BPP_888;
+	if (pvid->logo_on) /* To get proprietary LOGO */
+		cfg |= EXYNOS_WINCON_BPPMODE_24BPP_888;
+	else /* To get output console on LCD */
+		cfg |= EXYNOS_WINCON_BPPMODE_16BPP_565;
 
 	writel(cfg, (unsigned int)&fimd_ctrl->wincon0 +
 			EXYNOS_WINCON(win_id));
-- 
1.7.1

[U-Boot] [PATCH V4 4/4] EXYNOS5: Add support for FIMD and DP

[Ajay Kumar]

Add panel_info structure required by LCD driver
and DP panel platdata for SMDK5250.
Add GPIO configuration for LCD.
Enable FIMD and DP support on SMDK5250.
DP Panel size: 2560x1600.
We use 16BPP resolution to get LCD console.

Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
Acked-by: Simon Glass <sjg@chomium.org>
---
 board/samsung/smdk5250/smdk5250.c |   97 +++++++++++++++++++++++++++++++++++++
 include/configs/smdk5250.h        |    8 +++
 2 files changed, 105 insertions(+), 0 deletions(-)

diff --git a/board/samsung/smdk5250/smdk5250.c b/board/samsung/smdk5250/smdk5250.c
index 4c50342..46fd2a5 100644
--- a/board/samsung/smdk5250/smdk5250.c
+++ b/board/samsung/smdk5250/smdk5250.c
@@ -24,12 +24,15 @@
 #include <asm/io.h>
 #include <i2c.h>
 #include <netdev.h>
+#include <lcd.h>
 #include <spi.h>
 #include <asm/arch/cpu.h>
 #include <asm/arch/gpio.h>
 #include <asm/arch/mmc.h>
+#include <asm/arch/power.h>
 #include <asm/arch/pinmux.h>
 #include <asm/arch/sromc.h>
+#include <asm/arch/dp_info.h>
 #include <pmic.h>
 
 DECLARE_GLOBAL_DATA_PTR;
@@ -181,6 +184,100 @@ static int board_uart_init(void)
 	return 0;
 }
 
+void cfg_lcd_gpio(void)
+{
+	struct exynos5_gpio_part1 *gpio1 =
+		(struct exynos5_gpio_part1 *) samsung_get_base_gpio_part1();
+
+	/* For Backlight */
+	s5p_gpio_cfg_pin(&gpio1->b2, 0, GPIO_OUTPUT);
+	s5p_gpio_set_value(&gpio1->b2, 0, 1);
+
+	/* LCD power on */
+	s5p_gpio_cfg_pin(&gpio1->x1, 5, GPIO_OUTPUT);
+	s5p_gpio_set_value(&gpio1->x1, 5, 1);
+
+	/* Set Hotplug detect for DP */
+	s5p_gpio_cfg_pin(&gpio1->x0, 7, GPIO_FUNC(0x3));
+}
+
+vidinfo_t panel_info = {
+	.vl_freq	= 60,
+	.vl_col		= 2560,
+	.vl_row		= 1600,
+	.vl_width	= 2560,
+	.vl_height	= 1600,
+	.vl_clkp	= CONFIG_SYS_LOW,
+	.vl_hsp		= CONFIG_SYS_LOW,
+	.vl_vsp		= CONFIG_SYS_LOW,
+	.vl_dp		= CONFIG_SYS_LOW,
+	.vl_bpix	= 4,	/* LCD_BPP = 2^4, for output conosle on LCD */
+
+	/* wDP panel timing infomation */
+	.vl_hspw	= 32,
+	.vl_hbpd	= 80,
+	.vl_hfpd	= 48,
+
+	.vl_vspw	= 6,
+	.vl_vbpd	= 37,
+	.vl_vfpd	= 3,
+	.vl_cmd_allow_len = 0xf,
+
+	.win_id		= 3,
+	.cfg_gpio	= cfg_lcd_gpio,
+	.backlight_on	= NULL,
+	.lcd_power_on	= NULL,
+	.reset_lcd	= NULL,
+	.dual_lcd_enabled = 0,
+
+	.init_delay	= 0,
+	.power_on_delay = 0,
+	.reset_delay	= 0,
+	.interface_mode = FIMD_RGB_INTERFACE,
+	.dp_enabled	= 1,
+};
+
+static struct edp_device_info edp_info = {
+	.disp_info = {
+		.h_res = 2560,
+		.h_sync_width = 32,
+		.h_back_porch = 80,
+		.h_front_porch = 48,
+		.v_res = 1600,
+		.v_sync_width  = 6,
+		.v_back_porch = 37,
+		.v_front_porch = 3,
+		.v_sync_rate = 60,
+	},
+	.lt_info = {
+		.lt_status = DP_LT_NONE,
+	},
+	.video_info = {
+		.master_mode = 0,
+		.bist_mode = DP_DISABLE,
+		.bist_pattern = NO_PATTERN,
+		.h_sync_polarity = 0,
+		.v_sync_polarity = 0,
+		.interlaced = 0,
+		.color_space = COLOR_RGB,
+		.dynamic_range = VESA,
+		.ycbcr_coeff = COLOR_YCBCR601,
+		.color_depth = COLOR_8,
+	},
+};
+
+static struct exynos_dp_platform_data dp_platform_data = {
+	.phy_enable	= set_dp_phy_ctrl,
+	.edp_dev_info	= &edp_info,
+};
+
+void init_panel_info(vidinfo_t *vid)
+{
+	vid->rgb_mode   = MODE_RGB_P,
+
+	exynos_set_dp_platform_data(&dp_platform_data);
+}
+
 #ifdef CONFIG_SYS_I2C_INIT_BOARD
 static int board_i2c_init(void)
 {
diff --git a/include/configs/smdk5250.h b/include/configs/smdk5250.h
index e412da8..a9b3b8b 100644
--- a/include/configs/smdk5250.h
+++ b/include/configs/smdk5250.h
@@ -256,6 +256,14 @@
 #define CONFIG_SOUND_WM8994
 #endif
 
+/* Display */
+#define CONFIG_LCD
+#define CONFIG_EXYNOS_FB
+#define CONFIG_EXYNOS_DP
+#define LCD_XRES			2560
+#define LCD_YRES			1600
+#define LCD_BPP			LCD_COLOR16
+
 /* Enable devicetree support */
 #define CONFIG_OF_LIBFDT
 
-- 
1.7.1

[U-Boot] [PATCH V4 4/4] EXYNOS5: Add support for FIMD and DP

[Rajeshwari Birje]

Hi Ajay

On Fri, Dec 21, 2012 at 4:05 PM, Ajay Kumar <ajaykumar.rs@samsung.com>wrote:

> Add panel_info structure required by LCD driver
> and DP panel platdata for SMDK5250.
> Add GPIO configuration for LCD.
> Enable FIMD and DP support on SMDK5250.
> DP Panel size: 2560x1600.
> We use 16BPP resolution to get LCD console.
>
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> Acked-by: Simon Glass <sjg@chomium.org>
> ---
>  board/samsung/smdk5250/smdk5250.c |   97
> +++++++++++++++++++++++++++++++++++++
>  include/configs/smdk5250.h        |    8 +++
>  2 files changed, 105 insertions(+), 0 deletions(-)
>
> diff --git a/board/samsung/smdk5250/smdk5250.c
> b/board/samsung/smdk5250/smdk5250.c
> index 4c50342..46fd2a5 100644
> --- a/board/samsung/smdk5250/smdk5250.c
> +++ b/board/samsung/smdk5250/smdk5250.c
> @@ -24,12 +24,15 @@
>  #include <asm/io.h>
>  #include <i2c.h>
>  #include <netdev.h>
> +#include <lcd.h>
>  #include <spi.h>
>  #include <asm/arch/cpu.h>
>  #include <asm/arch/gpio.h>
>  #include <asm/arch/mmc.h>
> +#include <asm/arch/power.h>
>  #include <asm/arch/pinmux.h>
>  #include <asm/arch/sromc.h>
> +#include <asm/arch/dp_info.h>
>  #include <pmic.h>
>
>  DECLARE_GLOBAL_DATA_PTR;
> @@ -181,6 +184,100 @@ static int board_uart_init(void)
>         return 0;
>  }
>
> +void cfg_lcd_gpio(void)
> +{
> +       struct exynos5_gpio_part1 *gpio1 =
> +               (struct exynos5_gpio_part1 *)
> samsung_get_base_gpio_part1();
> +
> +       /* For Backlight */
> +       s5p_gpio_cfg_pin(&gpio1->b2, 0, GPIO_OUTPUT);
> +       s5p_gpio_set_value(&gpio1->b2, 0, 1);
> +
> +       /* LCD power on */
> +       s5p_gpio_cfg_pin(&gpio1->x1, 5, GPIO_OUTPUT);
> +       s5p_gpio_set_value(&gpio1->x1, 5, 1);
> +
> +       /* Set Hotplug detect for DP */
> +       s5p_gpio_cfg_pin(&gpio1->x0, 7, GPIO_FUNC(0x3));
> +}
>
Cant this GPIO changes go to pinmux  file?

> +
> +vidinfo_t panel_info = {
> +       .vl_freq        = 60,
> +       .vl_col         = 2560,
> +       .vl_row         = 1600,
> +       .vl_width       = 2560,
> +       .vl_height      = 1600,
> +       .vl_clkp        = CONFIG_SYS_LOW,
> +       .vl_hsp         = CONFIG_SYS_LOW,
> +       .vl_vsp         = CONFIG_SYS_LOW,
> +       .vl_dp          = CONFIG_SYS_LOW,
> +       .vl_bpix        = 4,    /* LCD_BPP = 2^4, for output conosle on
> LCD */
> +
> +       /* wDP panel timing infomation */
> +       .vl_hspw        = 32,
> +       .vl_hbpd        = 80,
> +       .vl_hfpd        = 48,
> +
> +       .vl_vspw        = 6,
> +       .vl_vbpd        = 37,
> +       .vl_vfpd        = 3,
> +       .vl_cmd_allow_len = 0xf,
> +
> +       .win_id         = 3,
> +       .cfg_gpio       = cfg_lcd_gpio,
> +       .backlight_on   = NULL,
> +       .lcd_power_on   = NULL,
> +       .reset_lcd      = NULL,
> +       .dual_lcd_enabled = 0,
> +
> +       .init_delay     = 0,
> +       .power_on_delay = 0,
> +       .reset_delay    = 0,
> +       .interface_mode = FIMD_RGB_INTERFACE,
> +       .dp_enabled     = 1,
> +};
> +
> +static struct edp_device_info edp_info = {
> +       .disp_info = {
> +               .h_res = 2560,
> +               .h_sync_width = 32,
> +               .h_back_porch = 80,
> +               .h_front_porch = 48,
> +               .v_res = 1600,
> +               .v_sync_width  = 6,
> +               .v_back_porch = 37,
> +               .v_front_porch = 3,
> +               .v_sync_rate = 60,
> +       },
> +       .lt_info = {
> +               .lt_status = DP_LT_NONE,
> +       },
> +       .video_info = {
> +               .master_mode = 0,
> +               .bist_mode = DP_DISABLE,
> +               .bist_pattern = NO_PATTERN,
> +               .h_sync_polarity = 0,
> +               .v_sync_polarity = 0,
> +               .interlaced = 0,
> +               .color_space = COLOR_RGB,
> +               .dynamic_range = VESA,
> +               .ycbcr_coeff = COLOR_YCBCR601,
> +               .color_depth = COLOR_8,
> +       },
> +};
> +
> +static struct exynos_dp_platform_data dp_platform_data = {
> +       .phy_enable     = set_dp_phy_ctrl,
> +       .edp_dev_info   = &edp_info,
> +};
> +
> +void init_panel_info(vidinfo_t *vid)
> +{
> +       vid->rgb_mode   = MODE_RGB_P,
> +
> +       exynos_set_dp_platform_data(&dp_platform_data);
> +}
> +
>  #ifdef CONFIG_SYS_I2C_INIT_BOARD
>  static int board_i2c_init(void)
>  {
> diff --git a/include/configs/smdk5250.h b/include/configs/smdk5250.h
> index e412da8..a9b3b8b 100644
> --- a/include/configs/smdk5250.h
> +++ b/include/configs/smdk5250.h
> @@ -256,6 +256,14 @@
>  #define CONFIG_SOUND_WM8994
>  #endif
>
> +/* Display */
> +#define CONFIG_LCD
> +#define CONFIG_EXYNOS_FB
> +#define CONFIG_EXYNOS_DP
> +#define LCD_XRES                       2560
> +#define LCD_YRES                       1600
> +#define LCD_BPP                        LCD_COLOR16
> +
>  /* Enable devicetree support */
>  #define CONFIG_OF_LIBFDT
>
> --
> 1.7.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>



-- 
Regards,
Rajeshwari Shinde

[U-Boot] [PATCH V4 4/4] EXYNOS5: Add support for FIMD and DP

[Kyungmin Park]

On Friday, December 21, 2012, Rajeshwari Birje wrote:

> Hi Ajay
>
> On Fri, Dec 21, 2012 at 4:05 PM, Ajay Kumar <ajaykumar.rs@samsung.com<javascript:;>
> >wrote:
>
> > Add panel_info structure required by LCD driver
> > and DP panel platdata for SMDK5250.
> > Add GPIO configuration for LCD.
> > Enable FIMD and DP support on SMDK5250.
> > DP Panel size: 2560x1600.
> > We use 16BPP resolution to get LCD console.
> >
> > Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com <javascript:;>>
> > Acked-by: Simon Glass <sjg@chomium.org <javascript:;>>
> > ---
> >  board/samsung/smdk5250/smdk5250.c |   97
> > +++++++++++++++++++++++++++++++++++++
> >  include/configs/smdk5250.h        |    8 +++
> >  2 files changed, 105 insertions(+), 0 deletions(-)
> >
> > diff --git a/board/samsung/smdk5250/smdk5250.c
> > b/board/samsung/smdk5250/smdk5250.c
> > index 4c50342..46fd2a5 100644
> > --- a/board/samsung/smdk5250/smdk5250.c
> > +++ b/board/samsung/smdk5250/smdk5250.c
> > @@ -24,12 +24,15 @@
> >  #include <asm/io.h>
> >  #include <i2c.h>
> >  #include <netdev.h>
> > +#include <lcd.h>
> >  #include <spi.h>
> >  #include <asm/arch/cpu.h>
> >  #include <asm/arch/gpio.h>
> >  #include <asm/arch/mmc.h>
> > +#include <asm/arch/power.h>
> >  #include <asm/arch/pinmux.h>
> >  #include <asm/arch/sromc.h>
> > +#include <asm/arch/dp_info.h>
> >  #include <pmic.h>
> >
> >  DECLARE_GLOBAL_DATA_PTR;
> > @@ -181,6 +184,100 @@ static int board_uart_init(void)
> >         return 0;
> >  }
> >
> > +void cfg_lcd_gpio(void)
> > +{
> > +       struct exynos5_gpio_part1 *gpio1 =
> > +               (struct exynos5_gpio_part1 *)
> > samsung_get_base_gpio_part1();
> > +
> > +       /* For Backlight */
> > +       s5p_gpio_cfg_pin(&gpio1->b2, 0, GPIO_OUTPUT);
> > +       s5p_gpio_set_value(&gpio1->b2, 0, 1);
> > +
> > +       /* LCD power on */
> > +       s5p_gpio_cfg_pin(&gpio1->x1, 5, GPIO_OUTPUT);
> > +       s5p_gpio_set_value(&gpio1->x1, 5, 1);
> > +
> > +       /* Set Hotplug detect for DP */
> > +       s5p_gpio_cfg_pin(&gpio1->x0, 7, GPIO_FUNC(0x3));
> > +}
> >
> Cant this GPIO changes go to pinmux  file?
>
>
> No it's smdk5250 specific. Other board has different GPIOs.

Thank you,



Kyungmin Park

> > +
> > +vidinfo_t panel_info = {
> > +       .vl_freq        = 60,
> > +       .vl_col         = 2560,
> > +       .vl_row         = 1600,
> > +       .vl_width       = 2560,
> > +       .vl_height      = 1600,
> > +       .vl_clkp        = CONFIG_SYS_LOW,
> > +       .vl_hsp         = CONFIG_SYS_LOW,
> > +       .vl_vsp         = CONFIG_SYS_LOW,
> > +       .vl_dp          = CONFIG_SYS_LOW,
> > +       .vl_bpix        = 4,    /* LCD_BPP = 2^4, for output conosle on
> > LCD */
> > +
> > +       /* wDP panel timing infomation */
> > +       .vl_hspw        = 32,
> > +       .vl_hbpd        = 80,
> > +       .vl_hfpd        = 48,
> > +
> > +       .vl_vspw        = 6,
> > +       .vl_vbpd        = 37,
> > +       .vl_vfpd        = 3,
> > +       .vl_cmd_allow_len = 0xf,
> > +
> > +       .win_id         = 3,
> > +       .cfg_gpio       = cfg_lcd_gpio,
> > +       .backlight_on   = NULL,
> > +       .lcd_power_on   = NULL,
> > +       .reset_lcd      = NULL,
> > +       .dual_lcd_enabled = 0,
> > +
> > +       .init_delay     = 0,
> > +       .power_on_delay = 0,
> > +       .reset_delay    = 0,
> > +       .interface_mode = FIMD_RGB_INTERFACE,
> > +       .dp_enabled     = 1,
> > +};
> > +
> > +static struct edp_device_info edp_info = {
> > +       .disp_info = {
> > +               .h_res = 2560,
> > +               .h_sync_width = 32,
> > +               .h_back_porch = 80,
> > +               .h_front_porch = 48,
> > +               .v_res = 1600,
> > +               .v_sync_width  = 6,
> > +               .v_back_porch = 37,
> > +               .v_front_porch = 3,
> > +               .v_sync_rate = 60,
> > +       },
> > +       .lt_info = {
> > +               .lt_status = DP_LT_NONE,
> > +       },
> > +       .video_info = {
> > +               .master_mode = 0,
> > +               .bist_mode = DP_DISABLE,
> > +               .bist_pattern = NO_PATTERN,
> > +               .h_sync_polarity = 0,
> > +               .v_sync_polarity = 0,
> > +               .interlaced = 0,
> > +               .color_space = COLOR_RGB,
> > +               .dynamic_range = VESA,
> > +               .ycbcr_coeff = COLOR_YCBCR601,
> > +               .color_depth = COLOR_8,
> > +       },
> > +};
> > +
> > +static struct exynos_dp_platform_data dp_platform_data = {
> > +       .phy_enable     = set_dp_phy_ctrl,
> > +       .edp_dev_info   = &edp_info,
> > +};
> > +
> > +void init_panel_info(vidinfo_t *vid)
> > +{
> > +       vid->rgb_mode   = MODE_RGB_P,
> > +
> > +       exynos_set_dp_platform_data(&dp_platform_data);
> > +}
> > +
> >  #ifdef CONFIG_SYS_I2C_INIT_BOARD
> >  static int board_i2c_init(void)
> >  {
> > diff --git a/include/configs/smdk5250.h b/include/configs/smdk5250.h
> > index e412da8..a9b3b8b 100644
> > --- a/inc--
> Regards,
> Rajeshwari Shinde
>

[U-Boot] [PATCH V4 4/4] EXYNOS5: Add support for FIMD and DP

[Minkyu Kang]

Dear Rajeshwari,

On 21/12/12 20:47, Rajeshwari Birje wrote:
> Hi Ajay
> 
> On Fri, Dec 21, 2012 at 4:05 PM, Ajay Kumar <ajaykumar.rs@samsung.com>wrote:
> 
>> Add panel_info structure required by LCD driver
>> and DP panel platdata for SMDK5250.
>> Add GPIO configuration for LCD.
>> Enable FIMD and DP support on SMDK5250.
>> DP Panel size: 2560x1600.
>> We use 16BPP resolution to get LCD console.
>>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
>> Acked-by: Simon Glass <sjg@chomium.org>
>> ---
>>  board/samsung/smdk5250/smdk5250.c |   97
>> +++++++++++++++++++++++++++++++++++++
>>  include/configs/smdk5250.h        |    8 +++
>>  2 files changed, 105 insertions(+), 0 deletions(-)
>>
>> diff --git a/board/samsung/smdk5250/smdk5250.c
>> b/board/samsung/smdk5250/smdk5250.c
>> index 4c50342..46fd2a5 100644
>> --- a/board/samsung/smdk5250/smdk5250.c
>> +++ b/board/samsung/smdk5250/smdk5250.c
>> @@ -24,12 +24,15 @@
>>  #include <asm/io.h>
>>  #include <i2c.h>
>>  #include <netdev.h>
>> +#include <lcd.h>
>>  #include <spi.h>
>>  #include <asm/arch/cpu.h>
>>  #include <asm/arch/gpio.h>
>>  #include <asm/arch/mmc.h>
>> +#include <asm/arch/power.h>
>>  #include <asm/arch/pinmux.h>
>>  #include <asm/arch/sromc.h>
>> +#include <asm/arch/dp_info.h>
>>  #include <pmic.h>
>>
>>  DECLARE_GLOBAL_DATA_PTR;
>> @@ -181,6 +184,100 @@ static int board_uart_init(void)
>>         return 0;
>>  }
>>
>> +void cfg_lcd_gpio(void)
>> +{
>> +       struct exynos5_gpio_part1 *gpio1 =
>> +               (struct exynos5_gpio_part1 *)
>> samsung_get_base_gpio_part1();
>> +
>> +       /* For Backlight */
>> +       s5p_gpio_cfg_pin(&gpio1->b2, 0, GPIO_OUTPUT);
>> +       s5p_gpio_set_value(&gpio1->b2, 0, 1);
>> +
>> +       /* LCD power on */
>> +       s5p_gpio_cfg_pin(&gpio1->x1, 5, GPIO_OUTPUT);
>> +       s5p_gpio_set_value(&gpio1->x1, 5, 1);
>> +
>> +       /* Set Hotplug detect for DP */
>> +       s5p_gpio_cfg_pin(&gpio1->x0, 7, GPIO_FUNC(0x3));
>> +}
>>
> Cant this GPIO changes go to pinmux  file?
> 

No. It is a board specific feature.
So, can't be located in pinmux file.

Thanks.
Minkyu Kang.

[U-Boot] [PATCH V4 4/4] EXYNOS5: Add support for FIMD and DP

[Rajeshwari Birje]

Hi Minkyu,

Thank you for clarification.

On Fri, Dec 21, 2012 at 5:35 PM, Minkyu Kang <mk7.kang@samsung.com> wrote:

> Dear Rajeshwari,
>
> On 21/12/12 20:47, Rajeshwari Birje wrote:
> > Hi Ajay
> >
> > On Fri, Dec 21, 2012 at 4:05 PM, Ajay Kumar <ajaykumar.rs@samsung.com
> >wrote:
> >
> >> Add panel_info structure required by LCD driver
> >> and DP panel platdata for SMDK5250.
> >> Add GPIO configuration for LCD.
> >> Enable FIMD and DP support on SMDK5250.
> >> DP Panel size: 2560x1600.
> >> We use 16BPP resolution to get LCD console.
> >>
> >> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> >> Acked-by: Simon Glass <sjg@chomium.org>
> >> ---
> >>  board/samsung/smdk5250/smdk5250.c |   97
> >> +++++++++++++++++++++++++++++++++++++
> >>  include/configs/smdk5250.h        |    8 +++
> >>  2 files changed, 105 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/board/samsung/smdk5250/smdk5250.c
> >> b/board/samsung/smdk5250/smdk5250.c
> >> index 4c50342..46fd2a5 100644
> >> --- a/board/samsung/smdk5250/smdk5250.c
> >> +++ b/board/samsung/smdk5250/smdk5250.c
> >> @@ -24,12 +24,15 @@
> >>  #include <asm/io.h>
> >>  #include <i2c.h>
> >>  #include <netdev.h>
> >> +#include <lcd.h>
> >>  #include <spi.h>
> >>  #include <asm/arch/cpu.h>
> >>  #include <asm/arch/gpio.h>
> >>  #include <asm/arch/mmc.h>
> >> +#include <asm/arch/power.h>
> >>  #include <asm/arch/pinmux.h>
> >>  #include <asm/arch/sromc.h>
> >> +#include <asm/arch/dp_info.h>
> >>  #include <pmic.h>
> >>
> >>  DECLARE_GLOBAL_DATA_PTR;
> >> @@ -181,6 +184,100 @@ static int board_uart_init(void)
> >>         return 0;
> >>  }
> >>
> >> +void cfg_lcd_gpio(void)
> >> +{
> >> +       struct exynos5_gpio_part1 *gpio1 =
> >> +               (struct exynos5_gpio_part1 *)
> >> samsung_get_base_gpio_part1();
> >> +
> >> +       /* For Backlight */
> >> +       s5p_gpio_cfg_pin(&gpio1->b2, 0, GPIO_OUTPUT);
> >> +       s5p_gpio_set_value(&gpio1->b2, 0, 1);
> >> +
> >> +       /* LCD power on */
> >> +       s5p_gpio_cfg_pin(&gpio1->x1, 5, GPIO_OUTPUT);
> >> +       s5p_gpio_set_value(&gpio1->x1, 5, 1);
> >> +
> >> +       /* Set Hotplug detect for DP */
> >> +       s5p_gpio_cfg_pin(&gpio1->x0, 7, GPIO_FUNC(0x3));
> >> +}
> >>
> > Cant this GPIO changes go to pinmux  file?
> >
>
> No. It is a board specific feature.
> So, can't be located in pinmux file.
>
ok

>
> Thanks.
> Minkyu Kang.
>

-- 
Regards,
Rajeshwari Shinde

[U-Boot] [PATCH V4 3/4] video: Modify exynos_fimd driver to support LCD console

[Minkyu Kang]

Dear Ajay Kumar,

On 21/12/12 19:35, Ajay Kumar wrote:
> Currently, exynos FIMD driver is being used to support only TIZEN LOGOs.
> In order to get LCD console, we need to enable half word swap feature
> of FIMD and use 16 BPP.
> LCD console and proprietary Logo cannot be used simultaneously.
> We use logo_on field inside vidinfo_t structure to decide whether
> user wants Logo or Console.
> 
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> ---

Please add changelog here about what you changed since last version.

>  drivers/video/exynos_fb.c   |    7 +++++++
>  drivers/video/exynos_fimd.c |   12 ++++++++----
>  2 files changed, 15 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/video/exynos_fb.c b/drivers/video/exynos_fb.c
> index d9a3f9a..ee916be 100644
> --- a/drivers/video/exynos_fb.c
> +++ b/drivers/video/exynos_fb.c
> @@ -45,6 +45,13 @@ short console_row;
>  
>  static unsigned int panel_width, panel_height;
>  
> +#ifndef CONFIG_CMD_BMP
> +int bmp_display(ulong addr, int x, int y)
> +{
> +	return 0;
> +}
> +#endif

It's a common function of bmp command.
Please do not redefine such a function.

---
Thanks,
Minkyu Kang.

[U-Boot] [PATCH V4 4/4] EXYNOS5: Add support for FIMD and DP

[Minkyu Kang]

Dear Ajay,

On 21/12/12 19:35, Ajay Kumar wrote:
> Add panel_info structure required by LCD driver
> and DP panel platdata for SMDK5250.
> Add GPIO configuration for LCD.
> Enable FIMD and DP support on SMDK5250.
> DP Panel size: 2560x1600.
> We use 16BPP resolution to get LCD console.
> 
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> Acked-by: Simon Glass <sjg@chomium.org>
> ---

Need changelog here.

>  board/samsung/smdk5250/smdk5250.c |   97 +++++++++++++++++++++++++++++++++++++
>  include/configs/smdk5250.h        |    8 +++
>  2 files changed, 105 insertions(+), 0 deletions(-)
> 

Please rebase this patch.

---
Thanks.
Minkyu Kang.

[U-Boot] [PATCH V4 3/4] video: Modify exynos_fimd driver to support LCD console

[Ajay kumar]

Hi  Minkyu,

On Tue, Jan 8, 2013 at 8:05 AM, Minkyu Kang <mk7.kang@samsung.com> wrote:
> Dear Ajay Kumar,
>
> On 21/12/12 19:35, Ajay Kumar wrote:
>> Currently, exynos FIMD driver is being used to support only TIZEN LOGOs.
>> In order to get LCD console, we need to enable half word swap feature
>> of FIMD and use 16 BPP.
>> LCD console and proprietary Logo cannot be used simultaneously.
>> We use logo_on field inside vidinfo_t structure to decide whether
>> user wants Logo or Console.
>>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
>> ---
>
> Please add changelog here about what you changed since last version.
I will send V5 soon. Please see my explanation below.
>>  drivers/video/exynos_fb.c   |    7 +++++++
>>  drivers/video/exynos_fimd.c |   12 ++++++++----
>>  2 files changed, 15 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/video/exynos_fb.c b/drivers/video/exynos_fb.c
>> index d9a3f9a..ee916be 100644
>> --- a/drivers/video/exynos_fb.c
>> +++ b/drivers/video/exynos_fb.c
>> @@ -45,6 +45,13 @@ short console_row;
>>
>>  static unsigned int panel_width, panel_height;
>>
>> +#ifndef CONFIG_CMD_BMP
>> +int bmp_display(ulong addr, int x, int y)
>> +{
>> +     return 0;
>> +}
>> +#endif


> It's a common function of bmp command.
> Please do not redefine such a function.

I am using CONFIG_CMD_BMP to differentiate between LCD Logo and LCD console.
I select CONFIG_CMD_BMP only when I need Logo, and
I will not select CONFIG_CMD_BMP when I need console.
Lets consider that we want console. So we don't define CONFIG_CMD_BMP now.
And, exynos_fb.c has linking time dependency on "bmp_display", which
is not defined!
In such a case, I am left with 2 options:
1) Place an #ifdef CONFIG_CMD_BMP inside exynos_fb, where it makes a
call to "bmp_display".
2) Redefine "bmp_display" to do nothing inside a header file(That's
how it is done in this patch!)
Kindly let me know if you have a better way to do this.

> ---
> Thanks,
> Minkyu Kang.
> ___________
Regards,
Ajay Kumar
____________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH V4 4/4] EXYNOS5: Add support for FIMD and DP

[Ajay kumar]

On Tue, Jan 8, 2013 at 8:10 AM, Minkyu Kang <mk7.kang@samsung.com> wrote:
> Dear Ajay,
>
> On 21/12/12 19:35, Ajay Kumar wrote:
>> Add panel_info structure required by LCD driver
>> and DP panel platdata for SMDK5250.
>> Add GPIO configuration for LCD.
>> Enable FIMD and DP support on SMDK5250.
>> DP Panel size: 2560x1600.
>> We use 16BPP resolution to get LCD console.
>>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
>> Acked-by: Simon Glass <sjg@chomium.org>
>> ---
>
> Need changelog here.
>
>>  board/samsung/smdk5250/smdk5250.c |   97 +++++++++++++++++++++++++++++++++++++
>>  include/configs/smdk5250.h        |    8 +++
>>  2 files changed, 105 insertions(+), 0 deletions(-)
>>
>
> Please rebase this patch.
Ok. I will send V5 soon.
> ---
> Thanks.
> Minkyu Kang.

Ajay
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH V4 3/4] video: Modify exynos_fimd driver to support LCD console

[Minkyu Kang]

On 08/01/13 14:31, Ajay kumar wrote:
> Hi  Minkyu,
> 
> On Tue, Jan 8, 2013 at 8:05 AM, Minkyu Kang <mk7.kang@samsung.com> wrote:
>> Dear Ajay Kumar,
>>
>> On 21/12/12 19:35, Ajay Kumar wrote:
>>> Currently, exynos FIMD driver is being used to support only TIZEN LOGOs.
>>> In order to get LCD console, we need to enable half word swap feature
>>> of FIMD and use 16 BPP.
>>> LCD console and proprietary Logo cannot be used simultaneously.
>>> We use logo_on field inside vidinfo_t structure to decide whether
>>> user wants Logo or Console.
>>>
>>> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
>>> ---
>>
>> Please add changelog here about what you changed since last version.
> I will send V5 soon. Please see my explanation below.
>>>  drivers/video/exynos_fb.c   |    7 +++++++
>>>  drivers/video/exynos_fimd.c |   12 ++++++++----
>>>  2 files changed, 15 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/video/exynos_fb.c b/drivers/video/exynos_fb.c
>>> index d9a3f9a..ee916be 100644
>>> --- a/drivers/video/exynos_fb.c
>>> +++ b/drivers/video/exynos_fb.c
>>> @@ -45,6 +45,13 @@ short console_row;
>>>
>>>  static unsigned int panel_width, panel_height;
>>>
>>> +#ifndef CONFIG_CMD_BMP
>>> +int bmp_display(ulong addr, int x, int y)
>>> +{
>>> +     return 0;
>>> +}
>>> +#endif
> 
> 
>> It's a common function of bmp command.
>> Please do not redefine such a function.
> 
> I am using CONFIG_CMD_BMP to differentiate between LCD Logo and LCD console.
> I select CONFIG_CMD_BMP only when I need Logo, and
> I will not select CONFIG_CMD_BMP when I need console.
> Lets consider that we want console. So we don't define CONFIG_CMD_BMP now.
> And, exynos_fb.c has linking time dependency on "bmp_display", which
> is not defined!
> In such a case, I am left with 2 options:
> 1) Place an #ifdef CONFIG_CMD_BMP inside exynos_fb, where it makes a
> call to "bmp_display".
> 2) Redefine "bmp_display" to do nothing inside a header file(That's
> how it is done in this patch!)
> Kindly let me know if you have a better way to do this.
> 

I think, 1) is better.

Thanks.
Minkyu Kang.