All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Richard Zhao <linuxzsc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Prashant Gaikwad
	<pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Peter De Schrijver
	<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: tegra: cpufreq: move clk_get/put out of function tegra_cpu_init/exit
Date: Fri, 21 Dec 2012 14:27:43 -0700	[thread overview]
Message-ID: <50D4D44F.2080203@wwwdotorg.org> (raw)
In-Reply-To: <1356084595-17800-1-git-send-email-linuxzsc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On 12/21/2012 03:09 AM, Richard Zhao wrote:
> tegra_cpu_init/exit will be called every time one cpu core is online or
> offline. And all cpu cores share same clocks, redundant clk_get/put
> wast time,  so I move them out.

I think this is reasonable.

Prashant, Peter, any comments?

Is any other work in tegra_cpu_init() redundant? Is tegra_cpu_init()
supposed to be called due to hotplug, or is that a bug in the cpufreq core?

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: cpufreq: move clk_get/put out of function tegra_cpu_init/exit
Date: Fri, 21 Dec 2012 14:27:43 -0700	[thread overview]
Message-ID: <50D4D44F.2080203@wwwdotorg.org> (raw)
In-Reply-To: <1356084595-17800-1-git-send-email-linuxzsc@gmail.com>

On 12/21/2012 03:09 AM, Richard Zhao wrote:
> tegra_cpu_init/exit will be called every time one cpu core is online or
> offline. And all cpu cores share same clocks, redundant clk_get/put
> wast time,  so I move them out.

I think this is reasonable.

Prashant, Peter, any comments?

Is any other work in tegra_cpu_init() redundant? Is tegra_cpu_init()
supposed to be called due to hotplug, or is that a bug in the cpufreq core?

  parent reply	other threads:[~2012-12-21 21:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-21 10:09 [PATCH] ARM: tegra: cpufreq: move clk_get/put out of function tegra_cpu_init/exit Richard Zhao
2012-12-21 10:09 ` Richard Zhao
     [not found] ` <1356084595-17800-1-git-send-email-linuxzsc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-12-21 21:27   ` Stephen Warren [this message]
2012-12-21 21:27     ` Stephen Warren
     [not found]     ` <50D4D44F.2080203-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-12-23 10:35       ` Prashant Gaikwad
2012-12-23 10:35         ` Prashant Gaikwad
2012-12-24  2:26         ` Richard Zhao
2012-12-24  2:26           ` Richard Zhao
     [not found]         ` <50D6DE6E.4060106-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-02 12:20           ` Peter De Schrijver
2013-01-02 12:20             ` Peter De Schrijver
2013-01-02 12:30       ` Peter De Schrijver
2013-01-02 12:30         ` Peter De Schrijver
2013-01-02 19:36   ` Stephen Warren
2013-01-02 19:36     ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50D4D44F.2080203@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linuxzsc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.