From: pgaikwad@nvidia.com (Prashant Gaikwad)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: debug clock tree
Date: Sun, 23 Dec 2012 15:56:22 +0530 [thread overview]
Message-ID: <50D6DC4E.9020205@nvidia.com> (raw)
In-Reply-To: <CAPtuhTgytOHGpVQ+vXQMpgFhuUo+y0H-QqpLg5cff2cdC-Rkzg@mail.gmail.com>
On Saturday 22 December 2012 04:26 AM, Mike Turquette wrote:
> On Wed, Dec 19, 2012 at 11:53 PM, Prashant Gaikwad <pgaikwad@nvidia.com> wrote:
>> On Thursday 13 December 2012 11:31 PM, Stephen Warren wrote:
>>> On 12/13/2012 09:27 AM, Mike Turquette wrote:
>>>> On Wed, Dec 12, 2012 at 7:49 PM, Prashant Gaikwad <pgaikwad@nvidia.com>
>>>> wrote:
>>>>> Adds debug file "clock_tree" in /sys/kernel/debug/clk dir.
>>>>> It helps to view all the clock registered in tree format.
>>>>>
>>>> Prashant,
>>>>
>>>> Thanks for submitting this. We've been talking about having a single
>>>> file for representing the tree for some time.
>>>>
>>>> Regarding the output format had you considered using a well known
>>>> format which can be parsed using well known parsing libs? This avoids
>>>> needing a custom parser just for this one file. JSON springs to mind
>>>> as something lightweight and well-understood.
>>> One advantage of the format below is that it's very easily
>>> human-readable, and it's not too hard to parse (although I guess you'd
>>> have to parse the indent level to get parent/child relation, which would
>>> suck a bit). Is there room to provide both? Otherwise, I guess the
>>> kernel could include a script to convert from JSON/whatever into the
>>> format below.
>>>
>>>>> For example:
>>>>> clock enable_cnt prepare_cnt rate
>>>>> ---------------------------------------------------------------------
>>>>> i2s0_sync 0 0 24000000
>>>>> spdif_in_sync 0 0 24000000
>>>>> spdif_mux 0 0 24000000
>>>>> spdif 0 0 24000000
>>>>> spdif_doubler 0 0 48000000
>>>>> spdif_div 0 0 48000000
>>>>> spdif_2x 0 0 48000000
>>>
>> Even I think that output must be easily human-readable. How about adding
>> sysfs to switch between human-readable and machine-readable format?
>> I will try come up with a implementation.
>>
> Do you mean a sysfs file which controls the output format? How about
> just two different files? One can be clk-dump (machine readable) and
> the other is clk-summary (human readable).
It is also fine. Is this patch ok for human-readable format? or any
suggestions?
I will change the file name to clk-summary.
>
> Regards,
> Mike
WARNING: multiple messages have this Message-ID (diff)
From: Prashant Gaikwad <pgaikwad@nvidia.com>
To: Mike Turquette <mturquette@linaro.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Stephen Warren <swarren@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] clk: debug clock tree
Date: Sun, 23 Dec 2012 15:56:22 +0530 [thread overview]
Message-ID: <50D6DC4E.9020205@nvidia.com> (raw)
In-Reply-To: <CAPtuhTgytOHGpVQ+vXQMpgFhuUo+y0H-QqpLg5cff2cdC-Rkzg@mail.gmail.com>
On Saturday 22 December 2012 04:26 AM, Mike Turquette wrote:
> On Wed, Dec 19, 2012 at 11:53 PM, Prashant Gaikwad <pgaikwad@nvidia.com> wrote:
>> On Thursday 13 December 2012 11:31 PM, Stephen Warren wrote:
>>> On 12/13/2012 09:27 AM, Mike Turquette wrote:
>>>> On Wed, Dec 12, 2012 at 7:49 PM, Prashant Gaikwad <pgaikwad@nvidia.com>
>>>> wrote:
>>>>> Adds debug file "clock_tree" in /sys/kernel/debug/clk dir.
>>>>> It helps to view all the clock registered in tree format.
>>>>>
>>>> Prashant,
>>>>
>>>> Thanks for submitting this. We've been talking about having a single
>>>> file for representing the tree for some time.
>>>>
>>>> Regarding the output format had you considered using a well known
>>>> format which can be parsed using well known parsing libs? This avoids
>>>> needing a custom parser just for this one file. JSON springs to mind
>>>> as something lightweight and well-understood.
>>> One advantage of the format below is that it's very easily
>>> human-readable, and it's not too hard to parse (although I guess you'd
>>> have to parse the indent level to get parent/child relation, which would
>>> suck a bit). Is there room to provide both? Otherwise, I guess the
>>> kernel could include a script to convert from JSON/whatever into the
>>> format below.
>>>
>>>>> For example:
>>>>> clock enable_cnt prepare_cnt rate
>>>>> ---------------------------------------------------------------------
>>>>> i2s0_sync 0 0 24000000
>>>>> spdif_in_sync 0 0 24000000
>>>>> spdif_mux 0 0 24000000
>>>>> spdif 0 0 24000000
>>>>> spdif_doubler 0 0 48000000
>>>>> spdif_div 0 0 48000000
>>>>> spdif_2x 0 0 48000000
>>>
>> Even I think that output must be easily human-readable. How about adding
>> sysfs to switch between human-readable and machine-readable format?
>> I will try come up with a implementation.
>>
> Do you mean a sysfs file which controls the output format? How about
> just two different files? One can be clk-dump (machine readable) and
> the other is clk-summary (human readable).
It is also fine. Is this patch ok for human-readable format? or any
suggestions?
I will change the file name to clk-summary.
>
> Regards,
> Mike
next prev parent reply other threads:[~2012-12-23 10:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 3:49 [PATCH] clk: debug clock tree Prashant Gaikwad
2012-12-13 3:49 ` Prashant Gaikwad
2012-12-13 16:27 ` Mike Turquette
2012-12-13 16:27 ` Mike Turquette
2012-12-13 18:01 ` Stephen Warren
2012-12-13 18:01 ` Stephen Warren
2012-12-14 10:43 ` Peter De Schrijver
2012-12-14 10:43 ` Peter De Schrijver
2012-12-14 16:43 ` Mike Turquette
2012-12-14 16:43 ` Mike Turquette
2012-12-20 5:53 ` Prashant Gaikwad
2012-12-20 5:53 ` Prashant Gaikwad
2012-12-21 22:56 ` Mike Turquette
2012-12-21 22:56 ` Mike Turquette
2012-12-23 10:26 ` Prashant Gaikwad [this message]
2012-12-23 10:26 ` Prashant Gaikwad
2012-12-24 17:37 ` Mike Turquette
2012-12-24 17:37 ` Mike Turquette
2012-12-25 4:52 ` Prashant Gaikwad
2012-12-25 4:52 ` Prashant Gaikwad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D6DC4E.9020205@nvidia.com \
--to=pgaikwad@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.