From: Alex Elder <elder@inktank.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: drivers/block/rbd.c:2170:19: sparse: symbol 'rbd_dev_create' was not declared. Should it be static?
Date: Sun, 23 Dec 2012 10:27:48 -0600 [thread overview]
Message-ID: <50D73104.7020805@inktank.com> (raw)
In-Reply-To: <20121223013756.GB11275@localhost>
On 12/22/2012 07:37 PM, Fengguang Wu wrote:
> Hi Alex,
>
> FYI, there are new sparse warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus
> head: c3e946ce7276faf0b302acd25c7b874edbeba661
> commit: c53d589337e9a211413484a604c76072e8474dc0 rbd: define rbd_dev_{create,destroy}() helpers
> date: 7 weeks ago
Quote a few of these have been addressed already in some upcoming
patches that didn't get reviewed in time for this cycle. I appreciate
the notice though, and I'll fix this up soon.
Thanks a lot.
-Alex
> drivers/block/rbd.c:1293:42: sparse: Using plain integer as NULL pointer
> drivers/block/rbd.c:1341:26: sparse: incorrect type in assignment (different base types)
> drivers/block/rbd.c:1341:26: expected unsigned long long [unsigned] [usertype] ver
> drivers/block/rbd.c:1341:26: got restricted __le64 [usertype] <noident>
> drivers/block/rbd.c:1351:46: sparse: Using plain integer as NULL pointer
> drivers/block/rbd.c:1395:26: sparse: incorrect type in assignment (different base types)
> drivers/block/rbd.c:1395:26: expected unsigned long long [unsigned] [usertype] ver
> drivers/block/rbd.c:1395:26: got restricted __le64 [usertype] <noident>
> drivers/block/rbd.c:1396:29: sparse: incorrect type in assignment (different base types)
> drivers/block/rbd.c:1396:29: expected unsigned long long [unsigned] [usertype] cookie
> drivers/block/rbd.c:1396:29: got restricted __le64 [usertype] <noident>
> drivers/block/rbd.c:1434:29: sparse: incorrect type in assignment (different base types)
> drivers/block/rbd.c:1434:29: expected unsigned long long [unsigned] [usertype] cookie
> drivers/block/rbd.c:1434:29: got restricted __le64 [usertype] <noident>
> + drivers/block/rbd.c:2170:19: sparse: symbol 'rbd_dev_create' was not declared. Should it be static?
> drivers/block/rbd.c:2529:17: sparse: incorrect type in assignment (different base types)
> drivers/block/rbd.c:2529:17: expected restricted __le64 [usertype] snap_id
> drivers/block/rbd.c:2529:17: got unsigned long long [unsigned] [long] [long long] <noident>
> drivers/block/rbd.c:2530:46: sparse: incorrect type in argument 2 (different base types)
> drivers/block/rbd.c:2530:46: expected unsigned long long [unsigned] [usertype] snap_id
> drivers/block/rbd.c:2530:46: got restricted __le64 [usertype] snap_id
> drivers/block/rbd.c:2533:50: sparse: incorrect type in argument 2 (different base types)
> drivers/block/rbd.c:2533:50: expected unsigned long long [unsigned] [usertype] snap_id
> drivers/block/rbd.c:2533:50: got restricted __le64 [usertype] snap_id
> drivers/block/rbd.c:1551:32: sparse: context imbalance in 'rbd_rq_fn' - unexpected unlock
>
> Please consider folding the attached diff :-)
>
> ---
> 0-DAY kernel build testing backend Open Source Technology Center
> Fengguang Wu, Yuanhan Liu Intel Corporation
>
prev parent reply other threads:[~2012-12-23 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50d3c4c4.+GYegH2UzJwRTkBr%yuanhan.liu@linux.intel.com>
2012-12-23 1:37 ` drivers/block/rbd.c:2170:19: sparse: symbol 'rbd_dev_create' was not declared. Should it be static? Fengguang Wu
2012-12-23 16:27 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D73104.7020805@inktank.com \
--to=elder@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=fengguang.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.