* drivers/block/rbd.c:2170:19: sparse: symbol 'rbd_dev_create' was not declared. Should it be static? [not found] <50d3c4c4.+GYegH2UzJwRTkBr%yuanhan.liu@linux.intel.com> @ 2012-12-23 1:37 ` Fengguang Wu 2012-12-23 16:27 ` Alex Elder 0 siblings, 1 reply; 2+ messages in thread From: Fengguang Wu @ 2012-12-23 1:37 UTC (permalink / raw) To: Alex Elder; +Cc: ceph-devel [-- Attachment #1: Type: text/plain, Size: 2616 bytes --] Hi Alex, FYI, there are new sparse warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus head: c3e946ce7276faf0b302acd25c7b874edbeba661 commit: c53d589337e9a211413484a604c76072e8474dc0 rbd: define rbd_dev_{create,destroy}() helpers date: 7 weeks ago drivers/block/rbd.c:1293:42: sparse: Using plain integer as NULL pointer drivers/block/rbd.c:1341:26: sparse: incorrect type in assignment (different base types) drivers/block/rbd.c:1341:26: expected unsigned long long [unsigned] [usertype] ver drivers/block/rbd.c:1341:26: got restricted __le64 [usertype] <noident> drivers/block/rbd.c:1351:46: sparse: Using plain integer as NULL pointer drivers/block/rbd.c:1395:26: sparse: incorrect type in assignment (different base types) drivers/block/rbd.c:1395:26: expected unsigned long long [unsigned] [usertype] ver drivers/block/rbd.c:1395:26: got restricted __le64 [usertype] <noident> drivers/block/rbd.c:1396:29: sparse: incorrect type in assignment (different base types) drivers/block/rbd.c:1396:29: expected unsigned long long [unsigned] [usertype] cookie drivers/block/rbd.c:1396:29: got restricted __le64 [usertype] <noident> drivers/block/rbd.c:1434:29: sparse: incorrect type in assignment (different base types) drivers/block/rbd.c:1434:29: expected unsigned long long [unsigned] [usertype] cookie drivers/block/rbd.c:1434:29: got restricted __le64 [usertype] <noident> + drivers/block/rbd.c:2170:19: sparse: symbol 'rbd_dev_create' was not declared. Should it be static? drivers/block/rbd.c:2529:17: sparse: incorrect type in assignment (different base types) drivers/block/rbd.c:2529:17: expected restricted __le64 [usertype] snap_id drivers/block/rbd.c:2529:17: got unsigned long long [unsigned] [long] [long long] <noident> drivers/block/rbd.c:2530:46: sparse: incorrect type in argument 2 (different base types) drivers/block/rbd.c:2530:46: expected unsigned long long [unsigned] [usertype] snap_id drivers/block/rbd.c:2530:46: got restricted __le64 [usertype] snap_id drivers/block/rbd.c:2533:50: sparse: incorrect type in argument 2 (different base types) drivers/block/rbd.c:2533:50: expected unsigned long long [unsigned] [usertype] snap_id drivers/block/rbd.c:2533:50: got restricted __le64 [usertype] snap_id drivers/block/rbd.c:1551:32: sparse: context imbalance in 'rbd_rq_fn' - unexpected unlock Please consider folding the attached diff :-) --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu Intel Corporation [-- Attachment #2: make-it-static-c53d589.diff --] [-- Type: text/x-diff, Size: 412 bytes --] diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index a8ad8f8..077e177 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -2167,7 +2167,7 @@ static void rbd_spec_free(struct kref *kref) kfree(spec); } -struct rbd_device *rbd_dev_create(struct rbd_client *rbdc, +static struct rbd_device *rbd_dev_create(struct rbd_client *rbdc, struct rbd_spec *spec) { struct rbd_device *rbd_dev; ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: drivers/block/rbd.c:2170:19: sparse: symbol 'rbd_dev_create' was not declared. Should it be static? 2012-12-23 1:37 ` drivers/block/rbd.c:2170:19: sparse: symbol 'rbd_dev_create' was not declared. Should it be static? Fengguang Wu @ 2012-12-23 16:27 ` Alex Elder 0 siblings, 0 replies; 2+ messages in thread From: Alex Elder @ 2012-12-23 16:27 UTC (permalink / raw) To: Fengguang Wu; +Cc: ceph-devel On 12/22/2012 07:37 PM, Fengguang Wu wrote: > Hi Alex, > > FYI, there are new sparse warnings show up in > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus > head: c3e946ce7276faf0b302acd25c7b874edbeba661 > commit: c53d589337e9a211413484a604c76072e8474dc0 rbd: define rbd_dev_{create,destroy}() helpers > date: 7 weeks ago Quote a few of these have been addressed already in some upcoming patches that didn't get reviewed in time for this cycle. I appreciate the notice though, and I'll fix this up soon. Thanks a lot. -Alex > drivers/block/rbd.c:1293:42: sparse: Using plain integer as NULL pointer > drivers/block/rbd.c:1341:26: sparse: incorrect type in assignment (different base types) > drivers/block/rbd.c:1341:26: expected unsigned long long [unsigned] [usertype] ver > drivers/block/rbd.c:1341:26: got restricted __le64 [usertype] <noident> > drivers/block/rbd.c:1351:46: sparse: Using plain integer as NULL pointer > drivers/block/rbd.c:1395:26: sparse: incorrect type in assignment (different base types) > drivers/block/rbd.c:1395:26: expected unsigned long long [unsigned] [usertype] ver > drivers/block/rbd.c:1395:26: got restricted __le64 [usertype] <noident> > drivers/block/rbd.c:1396:29: sparse: incorrect type in assignment (different base types) > drivers/block/rbd.c:1396:29: expected unsigned long long [unsigned] [usertype] cookie > drivers/block/rbd.c:1396:29: got restricted __le64 [usertype] <noident> > drivers/block/rbd.c:1434:29: sparse: incorrect type in assignment (different base types) > drivers/block/rbd.c:1434:29: expected unsigned long long [unsigned] [usertype] cookie > drivers/block/rbd.c:1434:29: got restricted __le64 [usertype] <noident> > + drivers/block/rbd.c:2170:19: sparse: symbol 'rbd_dev_create' was not declared. Should it be static? > drivers/block/rbd.c:2529:17: sparse: incorrect type in assignment (different base types) > drivers/block/rbd.c:2529:17: expected restricted __le64 [usertype] snap_id > drivers/block/rbd.c:2529:17: got unsigned long long [unsigned] [long] [long long] <noident> > drivers/block/rbd.c:2530:46: sparse: incorrect type in argument 2 (different base types) > drivers/block/rbd.c:2530:46: expected unsigned long long [unsigned] [usertype] snap_id > drivers/block/rbd.c:2530:46: got restricted __le64 [usertype] snap_id > drivers/block/rbd.c:2533:50: sparse: incorrect type in argument 2 (different base types) > drivers/block/rbd.c:2533:50: expected unsigned long long [unsigned] [usertype] snap_id > drivers/block/rbd.c:2533:50: got restricted __le64 [usertype] snap_id > drivers/block/rbd.c:1551:32: sparse: context imbalance in 'rbd_rq_fn' - unexpected unlock > > Please consider folding the attached diff :-) > > --- > 0-DAY kernel build testing backend Open Source Technology Center > Fengguang Wu, Yuanhan Liu Intel Corporation > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-23 16:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <50d3c4c4.+GYegH2UzJwRTkBr%yuanhan.liu@linux.intel.com>
2012-12-23 1:37 ` drivers/block/rbd.c:2170:19: sparse: symbol 'rbd_dev_create' was not declared. Should it be static? Fengguang Wu
2012-12-23 16:27 ` Alex Elder
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.