From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Kevin Hilman <khilman@deeprootsystems.com>,
Tony Lindgren <tony@atomide.com>, Felipe Balbi <balbi@ti.com>,
Vaibhav Hiremath <hvaibhav@ti.com>
Subject: Re: [PATCH 1/3] ARM: OMAP: 32k counter: resolve sparse warnings
Date: Tue, 25 Dec 2012 21:52:14 +0530 [thread overview]
Message-ID: <50D9D2B6.4060906@ti.com> (raw)
In-Reply-To: <20121224012456.13698.41839.stgit@dusk.lan>
On Monday 24 December 2012 06:54 AM, Paul Walmsley wrote:
> Commit 1fe97c8f6a1de67a5f56e029a818903d5bed8017 ("ARM: OMAP: Make OMAP
> clocksource source selection using kernel param") results in a new warning
> from sparse:
>
> arch/arm/plat-omap/counter_32k.c:86:12: warning: symbol 'omap_init_clocksource_32k' was not declared. Should it be static?
>
> Fix by adding a temporary header file, needed until the 32k counter
> code is moved to drivers/.
> arch/arm/plat-omap/include/plat/counter-32k.h can't be added due to
> ARM CONFIG_ARCH_MULTIPLATFORM restrictions on the use of the "plat/"
> include path shortcut.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
Looks good to my eyes.
Acked-by : Santosh Shilimkar <santosh.shilimkar@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: OMAP: 32k counter: resolve sparse warnings
Date: Tue, 25 Dec 2012 21:52:14 +0530 [thread overview]
Message-ID: <50D9D2B6.4060906@ti.com> (raw)
In-Reply-To: <20121224012456.13698.41839.stgit@dusk.lan>
On Monday 24 December 2012 06:54 AM, Paul Walmsley wrote:
> Commit 1fe97c8f6a1de67a5f56e029a818903d5bed8017 ("ARM: OMAP: Make OMAP
> clocksource source selection using kernel param") results in a new warning
> from sparse:
>
> arch/arm/plat-omap/counter_32k.c:86:12: warning: symbol 'omap_init_clocksource_32k' was not declared. Should it be static?
>
> Fix by adding a temporary header file, needed until the 32k counter
> code is moved to drivers/.
> arch/arm/plat-omap/include/plat/counter-32k.h can't be added due to
> ARM CONFIG_ARCH_MULTIPLATFORM restrictions on the use of the "plat/"
> include path shortcut.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
Looks good to my eyes.
Acked-by : Santosh Shilimkar <santosh.shilimkar@ti.com>
next prev parent reply other threads:[~2012-12-25 16:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-24 1:24 [PATCH 0/3] ARM: OMAP: resolve sparse warnings with v3.8-rc1 Paul Walmsley
2012-12-24 1:24 ` Paul Walmsley
2012-12-24 1:24 ` [PATCH 1/3] ARM: OMAP: 32k counter: resolve sparse warnings Paul Walmsley
2012-12-24 1:24 ` Paul Walmsley
2012-12-25 16:22 ` Santosh Shilimkar [this message]
2012-12-25 16:22 ` Santosh Shilimkar
2013-01-01 18:13 ` Tony Lindgren
2013-01-01 18:13 ` Tony Lindgren
2013-01-02 19:36 ` Paul Walmsley
2013-01-02 19:36 ` Paul Walmsley
2012-12-24 1:25 ` [PATCH 2/3] ARM: OMAP AM33xx: hwmod data: " Paul Walmsley
2012-12-24 1:25 ` Paul Walmsley
2012-12-26 4:10 ` Mugunthan V N
2012-12-26 4:10 ` Mugunthan V N
2012-12-24 1:25 ` [PATCH 3/3] ARM: OMAP: SRAM: " Paul Walmsley
2012-12-24 1:25 ` Paul Walmsley
2013-01-01 18:15 ` Tony Lindgren
2013-01-01 18:15 ` Tony Lindgren
2013-01-02 19:37 ` Paul Walmsley
2013-01-02 19:37 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D9D2B6.4060906@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=balbi@ti.com \
--cc=hvaibhav@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.