* [perf PATCH] Fix possible (unlikely) buffer overflow
@ 2012-12-25 16:23 Thomas Jarosch
2013-01-25 11:30 ` [tip:perf/core] perf tools: " tip-bot for Thomas Jarosch
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Jarosch @ 2012-12-25 16:23 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: linux-kernel
cppcheck reported:
[tools/perf/util/sysfs.c:50]: (error) Width 4096 given in format string
(no. 1) is larger than destination buffer 'sysfs_mountpoint[4096]',
use %4095s to prevent overflowing it
-> All other places in the kernel that use STR(PATH_MAX)
have a buffer size of PATH_MAX+1.
Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
---
tools/perf/util/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/sysfs.c b/tools/perf/util/sysfs.c
index 48c6902..606f884 100644
--- a/tools/perf/util/sysfs.c
+++ b/tools/perf/util/sysfs.c
@@ -8,7 +8,7 @@ static const char * const sysfs_known_mountpoints[] = {
};
static int sysfs_found;
-char sysfs_mountpoint[PATH_MAX];
+char sysfs_mountpoint[PATH_MAX+1];
static int sysfs_valid_mountpoint(const char *sysfs)
{
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:perf/core] perf tools: Fix possible (unlikely) buffer overflow
2012-12-25 16:23 [perf PATCH] Fix possible (unlikely) buffer overflow Thomas Jarosch
@ 2013-01-25 11:30 ` tip-bot for Thomas Jarosch
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Thomas Jarosch @ 2013-01-25 11:30 UTC (permalink / raw)
To: linux-tip-commits; +Cc: acme, linux-kernel, hpa, mingo, thomas.jarosch, tglx
Commit-ID: a65c23420668f7112395abf9c6f22c6450567bf0
Gitweb: http://git.kernel.org/tip/a65c23420668f7112395abf9c6f22c6450567bf0
Author: Thomas Jarosch <thomas.jarosch@intra2net.com>
AuthorDate: Tue, 25 Dec 2012 17:23:39 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 24 Jan 2013 16:40:18 -0300
perf tools: Fix possible (unlikely) buffer overflow
cppcheck reported:
[tools/perf/util/sysfs.c:50]: (error) Width 4096 given in format string
(no. 1) is larger than destination buffer 'sysfs_mountpoint[4096]',
use %4095s to prevent overflowing it
-> All other places in the kernel that use STR(PATH_MAX)
have a buffer size of PATH_MAX + 1.
Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Link: http://lkml.kernel.org/r/50D9D30B.8090002@intra2net.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/sysfs.c b/tools/perf/util/sysfs.c
index 48c6902..f71e9ea 100644
--- a/tools/perf/util/sysfs.c
+++ b/tools/perf/util/sysfs.c
@@ -8,7 +8,7 @@ static const char * const sysfs_known_mountpoints[] = {
};
static int sysfs_found;
-char sysfs_mountpoint[PATH_MAX];
+char sysfs_mountpoint[PATH_MAX + 1];
static int sysfs_valid_mountpoint(const char *sysfs)
{
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-25 11:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-25 16:23 [perf PATCH] Fix possible (unlikely) buffer overflow Thomas Jarosch
2013-01-25 11:30 ` [tip:perf/core] perf tools: " tip-bot for Thomas Jarosch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.