* [PATCH v2 0/2] cpts fixes for v3.8-rc2
@ 2012-12-24 7:19 ` Richard Cochran
0 siblings, 0 replies; 14+ messages in thread
From: Richard Cochran @ 2012-12-24 7:19 UTC (permalink / raw)
To: netdev
Cc: linux-arm-kernel, linux-omap, David Miller, Cyril Chemparathy,
Mugunthan V N, Sergei Shtylyov
Changed in v2:
Use clk_prepare_enable instead of clk_prepare + clk_enable.
The new cpts driver has two small issues, but it otherwise seems to be
working in -rc1.
Thanks,
Richard
Richard Cochran (2):
cpts: fix build error by removing useless code.
cpts: fix a run time warn_on.
drivers/net/ethernet/ti/cpts.c | 3 +--
drivers/net/ethernet/ti/cpts.h | 1 -
2 files changed, 1 insertions(+), 3 deletions(-)
--
1.7.2.5
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 0/2] cpts fixes for v3.8-rc2
@ 2012-12-24 7:19 ` Richard Cochran
0 siblings, 0 replies; 14+ messages in thread
From: Richard Cochran @ 2012-12-24 7:19 UTC (permalink / raw)
To: linux-arm-kernel
Changed in v2:
Use clk_prepare_enable instead of clk_prepare + clk_enable.
The new cpts driver has two small issues, but it otherwise seems to be
working in -rc1.
Thanks,
Richard
Richard Cochran (2):
cpts: fix build error by removing useless code.
cpts: fix a run time warn_on.
drivers/net/ethernet/ti/cpts.c | 3 +--
drivers/net/ethernet/ti/cpts.h | 1 -
2 files changed, 1 insertions(+), 3 deletions(-)
--
1.7.2.5
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 1/2] cpts: fix build error by removing useless code.
2012-12-24 7:19 ` Richard Cochran
(?)
@ 2012-12-24 7:19 ` Richard Cochran
-1 siblings, 0 replies; 14+ messages in thread
From: Richard Cochran @ 2012-12-24 7:19 UTC (permalink / raw)
To: netdev
Cc: linux-arm-kernel, linux-omap, David Miller, Cyril Chemparathy,
Mugunthan V N, Sergei Shtylyov
The cpts driver tries to obtain the input clock frequency by calling the
clock's internal 'recalc' method. Since <plat/clock.h> has been removed,
this code can no longer compile.
However, the driver never makes use of the frequency value, so this patch
fixes the issue by removing the offending code altogether.
Signed-off-by: Richard Cochran <richardcochran@gmail.com>
---
drivers/net/ethernet/ti/cpts.c | 1 -
drivers/net/ethernet/ti/cpts.h | 1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
index 5e62c1a..5ab8fb4 100644
--- a/drivers/net/ethernet/ti/cpts.c
+++ b/drivers/net/ethernet/ti/cpts.c
@@ -248,7 +248,6 @@ static void cpts_clk_init(struct cpts *cpts)
return;
}
clk_enable(cpts->refclk);
- cpts->freq = cpts->refclk->recalc(cpts->refclk);
}
static void cpts_clk_release(struct cpts *cpts)
diff --git a/drivers/net/ethernet/ti/cpts.h b/drivers/net/ethernet/ti/cpts.h
index e1bba3a..fe993cd 100644
--- a/drivers/net/ethernet/ti/cpts.h
+++ b/drivers/net/ethernet/ti/cpts.h
@@ -120,7 +120,6 @@ struct cpts {
struct delayed_work overflow_work;
int phc_index;
struct clk *refclk;
- unsigned long freq;
struct list_head events;
struct list_head pool;
struct cpts_event pool_data[CPTS_MAX_EVENTS];
--
1.7.2.5
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 1/2] cpts: fix build error by removing useless code.
@ 2012-12-24 7:19 ` Richard Cochran
0 siblings, 0 replies; 14+ messages in thread
From: Richard Cochran @ 2012-12-24 7:19 UTC (permalink / raw)
To: netdev
Cc: linux-arm-kernel, linux-omap, David Miller, Cyril Chemparathy,
Mugunthan V N, Sergei Shtylyov
The cpts driver tries to obtain the input clock frequency by calling the
clock's internal 'recalc' method. Since <plat/clock.h> has been removed,
this code can no longer compile.
However, the driver never makes use of the frequency value, so this patch
fixes the issue by removing the offending code altogether.
Signed-off-by: Richard Cochran <richardcochran@gmail.com>
---
drivers/net/ethernet/ti/cpts.c | 1 -
drivers/net/ethernet/ti/cpts.h | 1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
index 5e62c1a..5ab8fb4 100644
--- a/drivers/net/ethernet/ti/cpts.c
+++ b/drivers/net/ethernet/ti/cpts.c
@@ -248,7 +248,6 @@ static void cpts_clk_init(struct cpts *cpts)
return;
}
clk_enable(cpts->refclk);
- cpts->freq = cpts->refclk->recalc(cpts->refclk);
}
static void cpts_clk_release(struct cpts *cpts)
diff --git a/drivers/net/ethernet/ti/cpts.h b/drivers/net/ethernet/ti/cpts.h
index e1bba3a..fe993cd 100644
--- a/drivers/net/ethernet/ti/cpts.h
+++ b/drivers/net/ethernet/ti/cpts.h
@@ -120,7 +120,6 @@ struct cpts {
struct delayed_work overflow_work;
int phc_index;
struct clk *refclk;
- unsigned long freq;
struct list_head events;
struct list_head pool;
struct cpts_event pool_data[CPTS_MAX_EVENTS];
--
1.7.2.5
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 1/2] cpts: fix build error by removing useless code.
@ 2012-12-24 7:19 ` Richard Cochran
0 siblings, 0 replies; 14+ messages in thread
From: Richard Cochran @ 2012-12-24 7:19 UTC (permalink / raw)
To: linux-arm-kernel
The cpts driver tries to obtain the input clock frequency by calling the
clock's internal 'recalc' method. Since <plat/clock.h> has been removed,
this code can no longer compile.
However, the driver never makes use of the frequency value, so this patch
fixes the issue by removing the offending code altogether.
Signed-off-by: Richard Cochran <richardcochran@gmail.com>
---
drivers/net/ethernet/ti/cpts.c | 1 -
drivers/net/ethernet/ti/cpts.h | 1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
index 5e62c1a..5ab8fb4 100644
--- a/drivers/net/ethernet/ti/cpts.c
+++ b/drivers/net/ethernet/ti/cpts.c
@@ -248,7 +248,6 @@ static void cpts_clk_init(struct cpts *cpts)
return;
}
clk_enable(cpts->refclk);
- cpts->freq = cpts->refclk->recalc(cpts->refclk);
}
static void cpts_clk_release(struct cpts *cpts)
diff --git a/drivers/net/ethernet/ti/cpts.h b/drivers/net/ethernet/ti/cpts.h
index e1bba3a..fe993cd 100644
--- a/drivers/net/ethernet/ti/cpts.h
+++ b/drivers/net/ethernet/ti/cpts.h
@@ -120,7 +120,6 @@ struct cpts {
struct delayed_work overflow_work;
int phc_index;
struct clk *refclk;
- unsigned long freq;
struct list_head events;
struct list_head pool;
struct cpts_event pool_data[CPTS_MAX_EVENTS];
--
1.7.2.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 2/2] cpts: fix a run time warn_on.
2012-12-24 7:19 ` Richard Cochran
(?)
@ 2012-12-24 7:19 ` Richard Cochran
-1 siblings, 0 replies; 14+ messages in thread
From: Richard Cochran @ 2012-12-24 7:19 UTC (permalink / raw)
To: netdev
Cc: linux-arm-kernel, linux-omap, David Miller, Cyril Chemparathy,
Mugunthan V N, Sergei Shtylyov
This patch fixes a warning in clk_enable by calling clk_prepare_enable
instead.
Signed-off-by: Richard Cochran <richardcochran@gmail.com>
---
drivers/net/ethernet/ti/cpts.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
index 5ab8fb4..463597f 100644
--- a/drivers/net/ethernet/ti/cpts.c
+++ b/drivers/net/ethernet/ti/cpts.c
@@ -247,7 +247,7 @@ static void cpts_clk_init(struct cpts *cpts)
cpts->refclk = NULL;
return;
}
- clk_enable(cpts->refclk);
+ clk_prepare_enable(cpts->refclk);
}
static void cpts_clk_release(struct cpts *cpts)
--
1.7.2.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 2/2] cpts: fix a run time warn_on.
@ 2012-12-24 7:19 ` Richard Cochran
0 siblings, 0 replies; 14+ messages in thread
From: Richard Cochran @ 2012-12-24 7:19 UTC (permalink / raw)
To: netdev
Cc: linux-arm-kernel, linux-omap, David Miller, Cyril Chemparathy,
Mugunthan V N, Sergei Shtylyov
This patch fixes a warning in clk_enable by calling clk_prepare_enable
instead.
Signed-off-by: Richard Cochran <richardcochran@gmail.com>
---
drivers/net/ethernet/ti/cpts.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
index 5ab8fb4..463597f 100644
--- a/drivers/net/ethernet/ti/cpts.c
+++ b/drivers/net/ethernet/ti/cpts.c
@@ -247,7 +247,7 @@ static void cpts_clk_init(struct cpts *cpts)
cpts->refclk = NULL;
return;
}
- clk_enable(cpts->refclk);
+ clk_prepare_enable(cpts->refclk);
}
static void cpts_clk_release(struct cpts *cpts)
--
1.7.2.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 2/2] cpts: fix a run time warn_on.
@ 2012-12-24 7:19 ` Richard Cochran
0 siblings, 0 replies; 14+ messages in thread
From: Richard Cochran @ 2012-12-24 7:19 UTC (permalink / raw)
To: linux-arm-kernel
This patch fixes a warning in clk_enable by calling clk_prepare_enable
instead.
Signed-off-by: Richard Cochran <richardcochran@gmail.com>
---
drivers/net/ethernet/ti/cpts.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
index 5ab8fb4..463597f 100644
--- a/drivers/net/ethernet/ti/cpts.c
+++ b/drivers/net/ethernet/ti/cpts.c
@@ -247,7 +247,7 @@ static void cpts_clk_init(struct cpts *cpts)
cpts->refclk = NULL;
return;
}
- clk_enable(cpts->refclk);
+ clk_prepare_enable(cpts->refclk);
}
static void cpts_clk_release(struct cpts *cpts)
--
1.7.2.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/2] cpts fixes for v3.8-rc2
2012-12-24 7:19 ` Richard Cochran
(?)
@ 2012-12-26 4:12 ` Mugunthan V N
-1 siblings, 0 replies; 14+ messages in thread
From: Mugunthan V N @ 2012-12-26 4:12 UTC (permalink / raw)
To: Richard Cochran
Cc: netdev, linux-arm-kernel, linux-omap, David Miller,
Cyril Chemparathy, Sergei Shtylyov
On 12/24/2012 12:49 PM, Richard Cochran wrote:
> Changed in v2:
> Use clk_prepare_enable instead of clk_prepare + clk_enable.
>
> The new cpts driver has two small issues, but it otherwise seems to be
> working in -rc1.
>
> Thanks,
> Richard
>
> Richard Cochran (2):
> cpts: fix build error by removing useless code.
> cpts: fix a run time warn_on.
>
> drivers/net/ethernet/ti/cpts.c | 3 +--
> drivers/net/ethernet/ti/cpts.h | 1 -
> 2 files changed, 1 insertions(+), 3 deletions(-)
>
Looks good to me.
Acked-by : Mugunthan V N <mugunthanvnm@ti.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/2] cpts fixes for v3.8-rc2
@ 2012-12-26 4:12 ` Mugunthan V N
0 siblings, 0 replies; 14+ messages in thread
From: Mugunthan V N @ 2012-12-26 4:12 UTC (permalink / raw)
To: Richard Cochran
Cc: netdev, linux-arm-kernel, linux-omap, David Miller,
Cyril Chemparathy, Sergei Shtylyov
On 12/24/2012 12:49 PM, Richard Cochran wrote:
> Changed in v2:
> Use clk_prepare_enable instead of clk_prepare + clk_enable.
>
> The new cpts driver has two small issues, but it otherwise seems to be
> working in -rc1.
>
> Thanks,
> Richard
>
> Richard Cochran (2):
> cpts: fix build error by removing useless code.
> cpts: fix a run time warn_on.
>
> drivers/net/ethernet/ti/cpts.c | 3 +--
> drivers/net/ethernet/ti/cpts.h | 1 -
> 2 files changed, 1 insertions(+), 3 deletions(-)
>
Looks good to me.
Acked-by : Mugunthan V N <mugunthanvnm@ti.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 0/2] cpts fixes for v3.8-rc2
@ 2012-12-26 4:12 ` Mugunthan V N
0 siblings, 0 replies; 14+ messages in thread
From: Mugunthan V N @ 2012-12-26 4:12 UTC (permalink / raw)
To: linux-arm-kernel
On 12/24/2012 12:49 PM, Richard Cochran wrote:
> Changed in v2:
> Use clk_prepare_enable instead of clk_prepare + clk_enable.
>
> The new cpts driver has two small issues, but it otherwise seems to be
> working in -rc1.
>
> Thanks,
> Richard
>
> Richard Cochran (2):
> cpts: fix build error by removing useless code.
> cpts: fix a run time warn_on.
>
> drivers/net/ethernet/ti/cpts.c | 3 +--
> drivers/net/ethernet/ti/cpts.h | 1 -
> 2 files changed, 1 insertions(+), 3 deletions(-)
>
Looks good to me.
Acked-by : Mugunthan V N <mugunthanvnm@ti.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/2] cpts fixes for v3.8-rc2
2012-12-24 7:19 ` Richard Cochran
@ 2012-12-26 22:15 ` David Miller
-1 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2012-12-26 22:15 UTC (permalink / raw)
To: richardcochran
Cc: netdev, linux-arm-kernel, linux-omap, cyril, mugunthanvnm,
sshtylyov
From: Richard Cochran <richardcochran@gmail.com>
Date: Mon, 24 Dec 2012 08:19:08 +0100
> Changed in v2:
> Use clk_prepare_enable instead of clk_prepare + clk_enable.
>
> The new cpts driver has two small issues, but it otherwise seems to be
> working in -rc1.
Both applied, thanks.
^ permalink raw reply [flat|nested] 14+ messages in thread