From: Chris Ferron <chris.e.ferron at linux.intel.com>
To: powertop@lists.01.org
Subject: [Powertop] Fwd: RE: [RFC] [PATCHv2 00/10] Code deduplication in cpu/*
Date: Wed, 26 Dec 2012 12:56:08 -0800 [thread overview]
Message-ID: <50DB6468.5050804@linux.intel.com> (raw)
In-Reply-To: E351AD52FA1E154C8FFF4F9FCD2CA8431B3CD913@ORSMSX108.amr.corp.intel.com
[-- Attachment #1: Type: text/plain, Size: 2609 bytes --]
Arjan,
Can you take a look at this patch set. It looks good to me, but I
wanted to make sure I am not missing something. There is duplication
there, but not all.
I have built and run some tests. Seems OK at a glance.
-Chris
-------- Original Message --------
Subject: RE: [Powertop] [RFC] [PATCHv2 00/10] Code deduplication in cpu/*
Date: Mon, 24 Dec 2012 20:17:54 +0000
From: Ferron, Chris E <chris.e.ferron(a)intel.com>
To: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>, Chris Ferron
<chris.e.ferron(a)linux.intel.com>
CC: powertop(a)lists.01.org <powertop(a)lists.01.org>
Thanks, I will attend to outstanding patches on Wednesday (GMT+8) when I return to the office.
-Chris
-----Original Message-----
From: powertop-bounces(a)lists.01.org [mailto:powertop-bounces(a)lists.01.org] On Behalf Of Sergey Senozhatsky
Sent: Monday, December 24, 2012 8:25 AM
To: Chris Ferron
Cc: powertop(a)lists.01.org
Subject: Re: [Powertop] [RFC] [PATCHv2 00/10] Code deduplication in cpu/*
On (12/24/12 03:08), Ivan Shapovalov wrote:
> This is a resend (unchanged but rebased) of the patch series about
> refactoring code in cpu/* by deduplication. From this series, only the
> last bugfix patch has been applied so far due to a code freeze.
>
> Ivan Shapovalov (10):
> Fix includes: do not include intel_cpus.h inside cpu.h
> Deduplication: move is_turbo() function to lib
> Deduplication: move all instances of account_freq() to abstract_cpu::account_freq()
> Deduplication: remove nhm_cpu::account_freq() almost identical to abstract_cpu::account_freq()
> Deduplication: remove nhm_{cpu,core,package}::change_effective_frequency() identical to cpu_{linux,core,package}::change_effective_frequency()
> Deduplication: merge cpu_{core,linux,package}::change_effective_frequency() into abstract_cpu::change_effective_frequency()
> Deduplication: remove {cpu,nhm}_core::calculate_freq() identical to abstract_cpu::calculate_freq()
> Deduplication: remove nhm_package::calculate_freq() identical to cpu_package::calculate_freq()
> Deduplication: properly merge cpu_package::calculate_freq() into abstract_cpu::calculate_freq()
> Deduplication: merge go_idle()/go_unidle()/change_freq()
> overrides into abstract_cpu() class
>
Hello Chris,
patch series looks good to me. thanks to Ivan.
please note V3 of 02 and 03 patches.
-ss
_______________________________________________
PowerTop mailing list
PowerTop(a)lists.01.org
https://lists.01.org/mailman/listinfo/powertop
reply other threads:[~2012-12-26 20:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50DB6468.5050804@linux.intel.com \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.