All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: xen-devel@lists.xensource.com, konrad.wilk@oracle.com,
	andrew.cooper3@citrix.com, x86@kernel.org,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, mingo@redhat.com,
	ebiederm@xmission.com, jbeulich@suse.com,
	maxim.uvarov@oracle.com, tglx@linutronix.de, vgoyal@redhat.com
Subject: Re: [PATCH v3 00/11] xen: Initial kexec/kdump implementation
Date: Wed, 26 Dec 2012 20:02:30 -0800	[thread overview]
Message-ID: <50DBC856.6030208@zytor.com> (raw)
In-Reply-To: <1356574740-6806-1-git-send-email-daniel.kiper@oracle.com>

On 12/26/2012 06:18 PM, Daniel Kiper wrote:
> Hi,
>
> This set of patches contains initial kexec/kdump implementation for Xen v3.
> Currently only dom0 is supported, however, almost all infrustructure
> required for domU support is ready.
>
> Jan Beulich suggested to merge Xen x86 assembler code with baremetal x86 code.
> This could simplify and reduce a bit size of kernel code. However, this solution
> requires some changes in baremetal x86 code. First of all code which establishes
> transition page table should be moved back from machine_kexec_$(BITS).c to
> relocate_kernel_$(BITS).S. Another important thing which should be changed in that
> case is format of page_list array. Xen kexec hypercall requires to alternate physical
> addresses with virtual ones. These and other required stuff have not been done in that
> version because I am not sure that solution will be accepted by kexec/kdump maintainers.
> I hope that this email spark discussion about that topic.
>

I want a detailed list of the constraints that this assumes and 
therefore imposes on the native implementation as a result of this.  We 
have had way too many patches where Xen PV hacks effectively nailgun 
arbitrary, and sometimes poor, design decisions in place and now we 
can't fix them.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: xen-devel@lists.xensource.com, konrad.wilk@oracle.com,
	andrew.cooper3@citrix.com, x86@kernel.org,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, mingo@redhat.com,
	ebiederm@xmission.com, jbeulich@suse.com,
	maxim.uvarov@oracle.com, tglx@linutronix.de, vgoyal@redhat.com
Subject: Re: [PATCH v3 00/11] xen: Initial kexec/kdump implementation
Date: Wed, 26 Dec 2012 20:02:30 -0800	[thread overview]
Message-ID: <50DBC856.6030208@zytor.com> (raw)
In-Reply-To: <1356574740-6806-1-git-send-email-daniel.kiper@oracle.com>

On 12/26/2012 06:18 PM, Daniel Kiper wrote:
> Hi,
>
> This set of patches contains initial kexec/kdump implementation for Xen v3.
> Currently only dom0 is supported, however, almost all infrustructure
> required for domU support is ready.
>
> Jan Beulich suggested to merge Xen x86 assembler code with baremetal x86 code.
> This could simplify and reduce a bit size of kernel code. However, this solution
> requires some changes in baremetal x86 code. First of all code which establishes
> transition page table should be moved back from machine_kexec_$(BITS).c to
> relocate_kernel_$(BITS).S. Another important thing which should be changed in that
> case is format of page_list array. Xen kexec hypercall requires to alternate physical
> addresses with virtual ones. These and other required stuff have not been done in that
> version because I am not sure that solution will be accepted by kexec/kdump maintainers.
> I hope that this email spark discussion about that topic.
>

I want a detailed list of the constraints that this assumes and 
therefore imposes on the native implementation as a result of this.  We 
have had way too many patches where Xen PV hacks effectively nailgun 
arbitrary, and sometimes poor, design decisions in place and now we 
can't fix them.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: andrew.cooper3@citrix.com, ebiederm@xmission.com,
	jbeulich@suse.com, konrad.wilk@oracle.com,
	maxim.uvarov@oracle.com, mingo@redhat.com, tglx@linutronix.de,
	vgoyal@redhat.com, x86@kernel.org, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xensource.com
Subject: Re: [PATCH v3 00/11] xen: Initial kexec/kdump implementation
Date: Wed, 26 Dec 2012 20:02:30 -0800	[thread overview]
Message-ID: <50DBC856.6030208@zytor.com> (raw)
In-Reply-To: <1356574740-6806-1-git-send-email-daniel.kiper@oracle.com>

On 12/26/2012 06:18 PM, Daniel Kiper wrote:
> Hi,
>
> This set of patches contains initial kexec/kdump implementation for Xen v3.
> Currently only dom0 is supported, however, almost all infrustructure
> required for domU support is ready.
>
> Jan Beulich suggested to merge Xen x86 assembler code with baremetal x86 code.
> This could simplify and reduce a bit size of kernel code. However, this solution
> requires some changes in baremetal x86 code. First of all code which establishes
> transition page table should be moved back from machine_kexec_$(BITS).c to
> relocate_kernel_$(BITS).S. Another important thing which should be changed in that
> case is format of page_list array. Xen kexec hypercall requires to alternate physical
> addresses with virtual ones. These and other required stuff have not been done in that
> version because I am not sure that solution will be accepted by kexec/kdump maintainers.
> I hope that this email spark discussion about that topic.
>

I want a detailed list of the constraints that this assumes and 
therefore imposes on the native implementation as a result of this.  We 
have had way too many patches where Xen PV hacks effectively nailgun 
arbitrary, and sometimes poor, design decisions in place and now we 
can't fix them.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.


  parent reply	other threads:[~2012-12-27  4:02 UTC|newest]

Thread overview: 194+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-27  2:18 [PATCH v3 00/11] xen: Initial kexec/kdump implementation Daniel Kiper
2012-12-27  2:18 ` Daniel Kiper
2012-12-27  2:18 ` [PATCH v3 01/11] kexec: introduce kexec firmware support Daniel Kiper
2012-12-27  2:18   ` Daniel Kiper
2012-12-27  2:18   ` [PATCH v3 02/11] x86/kexec: Add extra pointers to transition page table PGD, PUD, PMD and PTE Daniel Kiper
2012-12-27  2:18   ` Daniel Kiper
2012-12-27  2:18     ` Daniel Kiper
2012-12-27  2:18     ` [PATCH v3 03/11] xen: Introduce architecture independent data for kexec/kdump Daniel Kiper
2012-12-27  2:18       ` Daniel Kiper
2012-12-27  2:18       ` [PATCH v3 04/11] x86/xen: Introduce architecture dependent " Daniel Kiper
2012-12-27  2:18       ` Daniel Kiper
2012-12-27  2:18         ` Daniel Kiper
2012-12-27  2:18         ` [PATCH v3 05/11] x86/xen: Register resources required by kexec-tools Daniel Kiper
2012-12-27  2:18           ` Daniel Kiper
2012-12-27  2:18           ` [PATCH v3 06/11] x86/xen: Add i386 kexec/kdump implementation Daniel Kiper
2012-12-27  2:18           ` Daniel Kiper
2012-12-27  2:18             ` Daniel Kiper
2012-12-27  2:18             ` [PATCH v3 07/11] x86/xen: Add x86_64 " Daniel Kiper
2012-12-27  2:18             ` Daniel Kiper
2012-12-27  2:18               ` Daniel Kiper
2012-12-27  2:18               ` [PATCH v3 08/11] x86/xen: Add kexec/kdump Kconfig and makefile rules Daniel Kiper
2012-12-27  2:18               ` Daniel Kiper
2012-12-27  2:18                 ` Daniel Kiper
2012-12-27  2:18                 ` [PATCH v3 09/11] x86/xen/enlighten: Add init and crash kexec/kdump hooks Daniel Kiper
2012-12-27  2:18                   ` Daniel Kiper
2012-12-27  2:18                   ` [PATCH v3 10/11] drivers/xen: Export vmcoreinfo through sysfs Daniel Kiper
2012-12-27  2:18                     ` Daniel Kiper
2012-12-27  2:19                     ` [PATCH v3 11/11] x86: Add Xen kexec control code size check to linker script Daniel Kiper
2012-12-27  2:19                       ` Daniel Kiper
2012-12-27  2:19                     ` Daniel Kiper
2012-12-27  2:18                   ` [PATCH v3 10/11] drivers/xen: Export vmcoreinfo through sysfs Daniel Kiper
2012-12-27 18:53                   ` [PATCH v3 09/11] x86/xen/enlighten: Add init and crash kexec/kdump hooks H. Peter Anvin
2012-12-27 18:53                     ` H. Peter Anvin
2012-12-27 18:53                     ` H. Peter Anvin
2012-12-27  2:18                 ` Daniel Kiper
2012-12-27  4:00             ` [PATCH v3 06/11] x86/xen: Add i386 kexec/kdump implementation H. Peter Anvin
2012-12-27  4:00               ` H. Peter Anvin
2012-12-27  4:00               ` H. Peter Anvin
2012-12-27  2:18         ` [PATCH v3 05/11] x86/xen: Register resources required by kexec-tools Daniel Kiper
2012-12-27  2:18     ` [PATCH v3 03/11] xen: Introduce architecture independent data for kexec/kdump Daniel Kiper
2012-12-27  3:33     ` [PATCH v3 02/11] x86/kexec: Add extra pointers to transition page table PGD, PUD, PMD and PTE H. Peter Anvin
2012-12-27  3:33       ` H. Peter Anvin
2013-01-03  9:34     ` Jan Beulich
2013-01-03  9:34       ` Jan Beulich
2013-01-03  9:34       ` Jan Beulich
2013-01-04 15:15       ` Daniel Kiper
2013-01-04 15:15         ` Daniel Kiper
2013-01-04 15:15         ` Daniel Kiper
2013-01-04 16:12         ` Jan Beulich
2013-01-04 16:12           ` Jan Beulich
2013-01-04 16:12           ` Jan Beulich
2013-01-04 17:25           ` Daniel Kiper
2013-01-04 17:25             ` Daniel Kiper
2013-01-04 17:25             ` Daniel Kiper
2013-01-07  9:48             ` Jan Beulich
2013-01-07  9:48             ` Jan Beulich
2013-01-07  9:48               ` Jan Beulich
2013-01-07 12:52               ` Daniel Kiper
2013-01-07 12:52                 ` Daniel Kiper
2013-01-07 12:52                 ` Daniel Kiper
2013-01-07 13:05                 ` Jan Beulich
2013-01-07 13:05                   ` Jan Beulich
2013-01-07 13:05                   ` Jan Beulich
2013-01-09 18:42                   ` Daniel Kiper
2013-01-09 18:42                   ` Daniel Kiper
2013-01-09 18:42                     ` Daniel Kiper
2013-01-10 14:07         ` [Xen-devel] " David Vrabel
2013-01-10 14:07           ` David Vrabel
2013-01-10 14:07           ` David Vrabel
2013-01-11 13:36           ` Daniel Kiper
2013-01-11 13:36             ` Daniel Kiper
2013-01-11 13:36             ` Daniel Kiper
2012-12-27  4:46   ` [PATCH v3 01/11] kexec: introduce kexec firmware support Eric W. Biederman
2012-12-27  4:46     ` Eric W. Biederman
2012-12-27  4:46     ` Eric W. Biederman
2012-12-27  2:18 ` Daniel Kiper
2012-12-27  4:02 ` H. Peter Anvin [this message]
2012-12-27  4:02   ` [PATCH v3 00/11] xen: Initial kexec/kdump implementation H. Peter Anvin
2012-12-27  4:02   ` H. Peter Anvin
2012-12-27  7:53   ` Eric W. Biederman
2012-12-27  7:53     ` Eric W. Biederman
2012-12-27  7:53     ` Eric W. Biederman
2012-12-27 14:18     ` Andrew Cooper
2012-12-27 14:18       ` Andrew Cooper
2012-12-27 14:18       ` Andrew Cooper
2012-12-27 18:02       ` Eric W. Biederman
2012-12-27 18:02         ` Eric W. Biederman
2012-12-27 18:02         ` Eric W. Biederman
2013-01-02 11:26         ` [Xen-devel] " Andrew Cooper
2013-01-02 11:26           ` Andrew Cooper
2013-01-02 11:26           ` Andrew Cooper
2013-01-02 11:47           ` Eric W. Biederman
2013-01-02 11:47             ` Eric W. Biederman
2013-01-02 11:47             ` Eric W. Biederman
2013-01-03  9:31           ` Jan Beulich
2013-01-03  9:31             ` Jan Beulich
2013-01-03  9:31             ` Jan Beulich
2013-01-04 14:22           ` Daniel Kiper
2013-01-04 14:22             ` Daniel Kiper
2013-01-04 14:22             ` Daniel Kiper
2013-01-04 14:34             ` Konrad Rzeszutek Wilk
2013-01-04 14:34               ` Konrad Rzeszutek Wilk
2013-01-04 14:34               ` Konrad Rzeszutek Wilk
2013-01-04 14:34             ` Ian Campbell
2013-01-04 14:34               ` Ian Campbell
2013-01-04 14:34               ` Ian Campbell
2013-01-04 14:38             ` David Vrabel
2013-01-04 14:38             ` David Vrabel
2013-01-04 14:38               ` David Vrabel
2013-01-04 17:01               ` Daniel Kiper
2013-01-04 17:01                 ` Daniel Kiper
2013-01-04 17:01                 ` Daniel Kiper
2013-01-10 14:19                 ` David Vrabel
2013-01-10 14:19                   ` David Vrabel
2013-01-10 14:19                   ` David Vrabel
2013-01-11 13:22                   ` Daniel Kiper
2013-01-11 13:22                     ` Daniel Kiper
2013-01-11 13:22                     ` Daniel Kiper
2013-01-11 15:22                     ` David Vrabel
2013-01-11 15:22                       ` David Vrabel
2013-01-11 15:22                       ` David Vrabel
2013-01-11 17:34                       ` Daniel Kiper
2013-01-11 17:34                         ` Daniel Kiper
2013-01-11 17:34                         ` Daniel Kiper
2013-01-11 20:05                       ` Eric W. Biederman
2013-01-11 20:05                         ` Eric W. Biederman
2013-01-11 20:05                         ` Eric W. Biederman
2013-01-04 14:41             ` Jan Beulich
2013-01-04 14:41               ` Jan Beulich
2013-01-04 14:41               ` Jan Beulich
2013-01-04 17:07               ` Daniel Kiper
2013-01-04 17:07               ` Daniel Kiper
2013-01-04 17:07                 ` Daniel Kiper
2013-01-04 19:11                 ` Konrad Rzeszutek Wilk
2013-01-04 19:11                   ` Konrad Rzeszutek Wilk
2013-01-04 19:11                   ` Konrad Rzeszutek Wilk
2013-01-07 10:25                   ` Ian Campbell
2013-01-07 10:25                     ` Ian Campbell
2013-01-07 10:46                     ` Andrew Cooper
2013-01-07 10:46                       ` Andrew Cooper
2013-01-07 10:46                       ` Andrew Cooper
2013-01-07 10:54                       ` Ian Campbell
2013-01-07 10:54                         ` Ian Campbell
2013-01-07 10:54                         ` Ian Campbell
2013-01-07 10:25                   ` Ian Campbell
2013-01-07 12:34                   ` Daniel Kiper
2013-01-07 12:34                     ` Daniel Kiper
2013-01-07 12:34                     ` Daniel Kiper
2013-01-07 13:49                     ` Ian Campbell
2013-01-07 13:49                     ` Ian Campbell
2013-01-07 13:49                       ` Ian Campbell
2013-01-11 13:47                       ` Daniel Kiper
2013-01-11 13:47                         ` Daniel Kiper
2013-01-11 13:47                         ` Daniel Kiper
2013-01-07 16:20                     ` Konrad Rzeszutek Wilk
2013-01-07 16:20                       ` Konrad Rzeszutek Wilk
2013-01-07 16:20                       ` Konrad Rzeszutek Wilk
2013-01-11  4:16                       ` Eric W. Biederman
2013-01-11  4:16                         ` Eric W. Biederman
2013-01-11  4:16                         ` Eric W. Biederman
2013-01-11 16:55                         ` Konrad Rzeszutek Wilk
2013-01-11 16:55                           ` Konrad Rzeszutek Wilk
2013-01-11 16:55                           ` Konrad Rzeszutek Wilk
2013-01-11 20:26                           ` H. Peter Anvin
2013-01-11 20:26                             ` H. Peter Anvin
2013-01-11 20:26                             ` H. Peter Anvin
2013-01-11 20:43                             ` Vivek Goyal
2013-01-11 20:43                               ` Vivek Goyal
2013-01-11 20:43                               ` Vivek Goyal
2013-01-11 20:26                           ` Eric W. Biederman
2013-01-11 20:26                             ` Eric W. Biederman
2013-01-11 20:26                             ` Eric W. Biederman
2013-01-11 20:52                             ` Vivek Goyal
2013-01-11 20:52                               ` Vivek Goyal
2013-01-11 20:52                               ` Vivek Goyal
2013-01-11 21:03                               ` H. Peter Anvin
2013-01-11 21:03                                 ` H. Peter Anvin
2013-01-11 21:08                                 ` Vivek Goyal
2013-01-11 21:08                                 ` Vivek Goyal
2013-01-11 21:08                                   ` Vivek Goyal
2013-01-11 21:14                                   ` H. Peter Anvin
2013-01-11 21:14                                     ` H. Peter Anvin
2013-01-11 21:14                                     ` H. Peter Anvin
2013-01-11 21:03                               ` H. Peter Anvin
2013-01-02 15:27       ` Ian Campbell
2013-01-02 15:27         ` Ian Campbell
2013-01-02 15:27       ` Ian Campbell
  -- strict thread matches above, loose matches on Subject: below --
2012-12-28  0:53 Daniel Kiper
2012-12-28  0:53 ` Daniel Kiper
2012-12-28  0:53 ` Daniel Kiper
2012-12-27 23:40 Daniel Kiper
2012-12-27 23:40 ` Daniel Kiper
2012-12-27 23:40 Daniel Kiper
2012-12-27  2:18 Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50DBC856.6030208@zytor.com \
    --to=hpa@zytor.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=daniel.kiper@oracle.com \
    --cc=ebiederm@xmission.com \
    --cc=jbeulich@suse.com \
    --cc=kexec@lists.infradead.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxim.uvarov@oracle.com \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=vgoyal@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.