All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Fabio Estevam <fabio.estevam@freescale.com>,
	Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH 1/3 V2] iio: mxs: Remove unused struct mxs_lradc_chan
Date: Thu, 27 Dec 2012 11:25:14 +0000	[thread overview]
Message-ID: <50DC301A.4040103@kernel.org> (raw)
In-Reply-To: <1355449598-15980-1-git-send-email-marex@denx.de>

On 12/14/2012 01:46 AM, Marek Vasut wrote:
> This structure definition seems to be some kind of remnant from
> previous development that accidentally made it mainline. Remove
> it as it's unused.
> 
> Remove unused "enable" field from struct mxs_lradc as well. This
> seems to be remnant of early development too.
> 
Added to togreg branch of

git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git

Jonathan
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> ---
>  drivers/staging/iio/adc/mxs-lradc.c |    7 -------
>  1 file changed, 7 deletions(-)
> 
> V2: The patch is now combination of previously two separate patches:
> [PATCH 1/4] iio: mxs: Remove unused struct mxs_lradc_chan
> [PATCH 2/4] iio: mxs: Remove unused fields from mxs_lradc
> 
> diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
> index ca7c1fa..6249957 100644
> --- a/drivers/staging/iio/adc/mxs-lradc.c
> +++ b/drivers/staging/iio/adc/mxs-lradc.c
> @@ -75,11 +75,6 @@ static const char * const mxs_lradc_irq_name[] = {
>  	"mxs-lradc-button1",
>  };
>  
> -struct mxs_lradc_chan {
> -	uint8_t				slot;
> -	uint8_t				flags;
> -};
> -
>  struct mxs_lradc {
>  	struct device		*dev;
>  	void __iomem		*base;
> @@ -90,8 +85,6 @@ struct mxs_lradc {
>  
>  	struct mutex		lock;
>  
> -	uint8_t			enable;
> -
>  	struct completion	completion;
>  };
>  
> 

WARNING: multiple messages have this Message-ID (diff)
From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3 V2] iio: mxs: Remove unused struct mxs_lradc_chan
Date: Thu, 27 Dec 2012 11:25:14 +0000	[thread overview]
Message-ID: <50DC301A.4040103@kernel.org> (raw)
In-Reply-To: <1355449598-15980-1-git-send-email-marex@denx.de>

On 12/14/2012 01:46 AM, Marek Vasut wrote:
> This structure definition seems to be some kind of remnant from
> previous development that accidentally made it mainline. Remove
> it as it's unused.
> 
> Remove unused "enable" field from struct mxs_lradc as well. This
> seems to be remnant of early development too.
> 
Added to togreg branch of

git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git

Jonathan
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> ---
>  drivers/staging/iio/adc/mxs-lradc.c |    7 -------
>  1 file changed, 7 deletions(-)
> 
> V2: The patch is now combination of previously two separate patches:
> [PATCH 1/4] iio: mxs: Remove unused struct mxs_lradc_chan
> [PATCH 2/4] iio: mxs: Remove unused fields from mxs_lradc
> 
> diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
> index ca7c1fa..6249957 100644
> --- a/drivers/staging/iio/adc/mxs-lradc.c
> +++ b/drivers/staging/iio/adc/mxs-lradc.c
> @@ -75,11 +75,6 @@ static const char * const mxs_lradc_irq_name[] = {
>  	"mxs-lradc-button1",
>  };
>  
> -struct mxs_lradc_chan {
> -	uint8_t				slot;
> -	uint8_t				flags;
> -};
> -
>  struct mxs_lradc {
>  	struct device		*dev;
>  	void __iomem		*base;
> @@ -90,8 +85,6 @@ struct mxs_lradc {
>  
>  	struct mutex		lock;
>  
> -	uint8_t			enable;
> -
>  	struct completion	completion;
>  };
>  
> 

  parent reply	other threads:[~2012-12-27 11:25 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-14  1:46 [PATCH 1/3 V2] iio: mxs: Remove unused struct mxs_lradc_chan Marek Vasut
2012-12-14  1:46 ` Marek Vasut
2012-12-14  1:46 ` [PATCH 2/3 V2] iio: mxs: Implement support for touchscreen Marek Vasut
2012-12-14  1:46   ` Marek Vasut
2012-12-14  1:58   ` Fabio Estevam
2012-12-14  1:58     ` Fabio Estevam
2012-12-14  2:04     ` Marek Vasut
2012-12-14  2:04       ` Marek Vasut
2012-12-19 17:01   ` Marek Vasut
2012-12-19 17:01     ` Marek Vasut
2012-12-27 12:16     ` Jonathan Cameron
2012-12-27 12:16       ` Jonathan Cameron
2013-01-08 19:28       ` Marek Vasut
2013-01-08 19:28         ` Marek Vasut
2013-01-09 20:01         ` Jonathan Cameron
2013-01-09 20:01           ` Jonathan Cameron
2013-01-09 20:17           ` Marek Vasut
2013-01-09 20:17             ` Marek Vasut
2013-01-09 21:38             ` Jonathan Cameron
2013-01-09 21:38               ` Jonathan Cameron
2013-01-09 21:54               ` Marek Vasut
2013-01-09 21:54                 ` Marek Vasut
2013-01-10  0:57     ` Dmitry Torokhov
2013-01-10  0:57       ` Dmitry Torokhov
2013-01-10  9:48       ` Marek Vasut
2013-01-10  9:48         ` Marek Vasut
2013-01-10 17:46         ` Dmitry Torokhov
2013-01-10 17:46           ` Dmitry Torokhov
2013-01-10 18:19           ` Lars-Peter Clausen
2013-01-10 18:19             ` Lars-Peter Clausen
2013-01-10 18:44             ` Dmitry Torokhov
2013-01-10 18:44               ` Dmitry Torokhov
2012-12-27 11:31   ` Jonathan Cameron
2012-12-27 11:31     ` Jonathan Cameron
     [not found]     ` <50DC319B.1050607-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-12-27 18:19       ` Marek Vasut
2012-12-27 18:19         ` Marek Vasut
2012-12-27 18:19         ` Marek Vasut
2012-12-14  1:46 ` [PATCH 3/3] iio: mxs: Enable touchscreen on m28evk Marek Vasut
2012-12-14  1:46   ` Marek Vasut
2012-12-27 11:25 ` Jonathan Cameron [this message]
2012-12-27 11:25   ` [PATCH 1/3 V2] iio: mxs: Remove unused struct mxs_lradc_chan Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50DC301A.4040103@kernel.org \
    --to=jic23@kernel.org \
    --cc=fabio.estevam@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.