All of lore.kernel.org
 help / color / mirror / Atom feed
From: m.szyprowski@samsung.com (Marek Szyprowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: dma mapping: export arm iommu functions
Date: Thu, 27 Dec 2012 15:15:40 +0100	[thread overview]
Message-ID: <50DC580C.7080507@samsung.com> (raw)
In-Reply-To: <1356592458-11077-1-git-send-email-prathyush.k@samsung.com>

Hello,

On 12/27/2012 8:14 AM, Prathyush K wrote:
> This patch adds EXPORT_SYMBOL calls to the three arm iommu
> functions - arm_iommu_create_mapping, arm_iommu_free_mapping
> and arm_iommu_attach_device. These functions can now be called
> from dynamic modules.

Could You describe a bit more why those functions might be needed by 
dynamic modules?

> Signed-off-by: Prathyush K <prathyush.k@samsung.com>
> ---
>   arch/arm/mm/dma-mapping.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index 6b2fb87..c0f0f43 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -1797,6 +1797,7 @@ err2:
>   err:
>   	return ERR_PTR(err);
>   }
> +EXPORT_SYMBOL(arm_iommu_create_mapping);

EXPORT_SYMOBL_GPL() ?

>   static void release_iommu_mapping(struct kref *kref)
>   {
> @@ -1813,6 +1814,7 @@ void arm_iommu_release_mapping(struct dma_iommu_mapping *mapping)
>   	if (mapping)
>   		kref_put(&mapping->kref, release_iommu_mapping);
>   }
> +EXPORT_SYMBOL(arm_iommu_release_mapping);
>   
>   /**
>    * arm_iommu_attach_device
> @@ -1841,5 +1843,6 @@ int arm_iommu_attach_device(struct device *dev,
>   	pr_debug("Attached IOMMU controller to %s device.\n", dev_name(dev));
>   	return 0;
>   }
> +EXPORT_SYMBOL(arm_iommu_attach_device);
>   
>   #endif

Best regards
-- 
Marek Szyprowski
Samsung Poland R&D Center

WARNING: multiple messages have this Message-ID (diff)
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Prathyush K <prathyush.k@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org,
	prathyush@chromium.org
Subject: Re: [PATCH] arm: dma mapping: export arm iommu functions
Date: Thu, 27 Dec 2012 15:15:40 +0100	[thread overview]
Message-ID: <50DC580C.7080507@samsung.com> (raw)
In-Reply-To: <1356592458-11077-1-git-send-email-prathyush.k@samsung.com>

Hello,

On 12/27/2012 8:14 AM, Prathyush K wrote:
> This patch adds EXPORT_SYMBOL calls to the three arm iommu
> functions - arm_iommu_create_mapping, arm_iommu_free_mapping
> and arm_iommu_attach_device. These functions can now be called
> from dynamic modules.

Could You describe a bit more why those functions might be needed by 
dynamic modules?

> Signed-off-by: Prathyush K <prathyush.k@samsung.com>
> ---
>   arch/arm/mm/dma-mapping.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index 6b2fb87..c0f0f43 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -1797,6 +1797,7 @@ err2:
>   err:
>   	return ERR_PTR(err);
>   }
> +EXPORT_SYMBOL(arm_iommu_create_mapping);

EXPORT_SYMOBL_GPL() ?

>   static void release_iommu_mapping(struct kref *kref)
>   {
> @@ -1813,6 +1814,7 @@ void arm_iommu_release_mapping(struct dma_iommu_mapping *mapping)
>   	if (mapping)
>   		kref_put(&mapping->kref, release_iommu_mapping);
>   }
> +EXPORT_SYMBOL(arm_iommu_release_mapping);
>   
>   /**
>    * arm_iommu_attach_device
> @@ -1841,5 +1843,6 @@ int arm_iommu_attach_device(struct device *dev,
>   	pr_debug("Attached IOMMU controller to %s device.\n", dev_name(dev));
>   	return 0;
>   }
> +EXPORT_SYMBOL(arm_iommu_attach_device);
>   
>   #endif

Best regards
-- 
Marek Szyprowski
Samsung Poland R&D Center


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-12-27 14:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-27  7:14 [PATCH] arm: dma mapping: export arm iommu functions Prathyush K
2012-12-27  7:14 ` Prathyush K
2012-12-27 14:15 ` Marek Szyprowski [this message]
2012-12-27 14:15   ` Marek Szyprowski
2012-12-28  4:23   ` Prathyush K
2012-12-28  4:23     ` Prathyush K
2012-12-29  6:53     ` Olof Johansson
2012-12-29  6:53       ` Olof Johansson
2013-01-01  1:07       ` Subash Patel
2013-01-01  1:07         ` Subash Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50DC580C.7080507@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.