[Xenomai] Kernel compilation error due to Adeos patch error in 'io_apic.c'

[Xenomai] Kernel compilation error due to Adeos patch error in 'io_apic.c'

[Stephen Bryant]

 Hello,

I have searched the mailing lists to find out if this has already been
raised and have not found anything, so apologies if this is a known issue.

Vanilla Kernel: 3.2.21
Adeos Patch: ipipe-core-3.2.21-x86-1.patch
gcc --version: 4.7.0
Xenomai Version: 2.6.1

Patch applies itself cleanly.

Compilation error during initial kernel 'make':
arch/x86/kernel/apic/io_apic.c: In function
‘irq_remap_modify_chip_defaults’:
arch/x86/kernel/apic/io_apic.c:2763:1: error: expected expression before
‘}’ token

Problem:
Commas instead of semi-colons at the end of lines inside CONFIG_IPIPE 'if'
directives in 'io_apic.c'.

Solution:
Update the ipipe patch to replace commas with semi-colons (please let me
know if you want this diff in a different format):

*** ksrc/arch/x86/patches/ipipe-core-3.2.21-x86-1.patch    2012-07-10
19:42:46.000000000 +0100
--- ksrc/arch/x86/patches/ipipe-core-3.2.21-x86-1-new.patch    2012-08-08
11:44:48.472207969 +0100
*************** index 6d939d7..9bbe781 100644
*** 1751,1762 ****
   #ifdef CONFIG_SMP
          chip->irq_set_affinity = ir_ioapic_set_affinity;
  +#ifdef CONFIG_IPIPE
! +       chip->irq_move = move_xxapic_irq,
  +#endif
  +#endif
  +#ifdef CONFIG_IPIPE
! +       chip->irq_hold = hold_ioapic_irq,
! +       chip->irq_release = release_ioapic_irq,
   #endif
   }
   #endif /* CONFIG_IRQ_REMAP */
--- 1751,1762 ----
   #ifdef CONFIG_SMP
          chip->irq_set_affinity = ir_ioapic_set_affinity;
  +#ifdef CONFIG_IPIPE
! +       chip->irq_move = move_xxapic_irq;
  +#endif
  +#endif
  +#ifdef CONFIG_IPIPE
! +       chip->irq_hold = hold_ioapic_irq;
! +       chip->irq_release = release_ioapic_irq;
   #endif
   }
   #endif /* CONFIG_IRQ_REMAP */

Steve

Re: [Xenomai] Kernel compilation error due to Adeos patch error in 'io_apic.c'

[Wim]

 
> Vanilla Kernel: 3.2.21
> Adeos Patch: ipipe-core-3.2.21-x86-1.patch
> gcc --version: 4.7.0
> Xenomai Version: 2.6.1
> 
> Patch applies itself cleanly.
> 
> Compilation error during initial kernel 'make':
> arch/x86/kernel/apic/io_apic.c: In function
> ‘irq_remap_modify_chip_defaults’:
> arch/x86/kernel/apic/io_apic.c:2763:1: error: expected expression before
> ‘}’ token
> 
> Problem:
> Commas instead of semi-colons at the end of lines inside CONFIG_IPIPE 'if'
> directives in 'io_apic.c'.



Thanks Steve, this really helped!  

I can confirm that this problem still exists with yesterday's  
stable Xenomai release 2.6.2, ipipe-core-3.2.21-x86-2.patch, a vanilla 3.2.21 
kernel, ang gcc 4.6.3 on Ubuntu 12.04.

Re: [Xenomai] Kernel compilation error due to Adeos patch error in 'io_apic.c'

[Gilles Chanteperdrix]

On 12/27/2012 08:06 PM, Wim wrote:

>  
>> Vanilla Kernel: 3.2.21
>> Adeos Patch: ipipe-core-3.2.21-x86-1.patch
>> gcc --version: 4.7.0
>> Xenomai Version: 2.6.1
>>
>> Patch applies itself cleanly.
>>
>> Compilation error during initial kernel 'make':
>> arch/x86/kernel/apic/io_apic.c: In function
>> ‘irq_remap_modify_chip_defaults’:
>> arch/x86/kernel/apic/io_apic.c:2763:1: error: expected expression before
>> ‘}’ token
>>
>> Problem:
>> Commas instead of semi-colons at the end of lines inside CONFIG_IPIPE 'if'
>> directives in 'io_apic.c'.
> 
> 
> 
> Thanks Steve, this really helped!  
> 
> I can confirm that this problem still exists with yesterday's  
> stable Xenomai release 2.6.2, ipipe-core-3.2.21-x86-2.patch, a vanilla 3.2.21 
> kernel, ang gcc 4.6.3 on Ubuntu 12.04.


Ok, do you have the issue with I-pipe core 3.4 and 3.5 ?


-- 
                                                                Gilles.

Re: [Xenomai] Kernel compilation error due to Adeos patch error in 'io_apic.c'

[Philippe Gerum]

On 12/27/2012 08:35 PM, Gilles Chanteperdrix wrote:
> On 12/27/2012 08:06 PM, Wim wrote:
>
>>
>>> Vanilla Kernel: 3.2.21
>>> Adeos Patch: ipipe-core-3.2.21-x86-1.patch
>>> gcc --version: 4.7.0
>>> Xenomai Version: 2.6.1
>>>
>>> Patch applies itself cleanly.
>>>
>>> Compilation error during initial kernel 'make':
>>> arch/x86/kernel/apic/io_apic.c: In function
>>> ‘irq_remap_modify_chip_defaults’:
>>> arch/x86/kernel/apic/io_apic.c:2763:1: error: expected expression before
>>> ‘}’ token
>>>
>>> Problem:
>>> Commas instead of semi-colons at the end of lines inside CONFIG_IPIPE 'if'
>>> directives in 'io_apic.c'.
>>
>>
>>
>> Thanks Steve, this really helped!
>>
>> I can confirm that this problem still exists with yesterday's
>> stable Xenomai release 2.6.2, ipipe-core-3.2.21-x86-2.patch, a vanilla 3.2.21
>> kernel, ang gcc 4.6.3 on Ubuntu 12.04.
>
>
> Ok, do you have the issue with I-pipe core 3.4 and 3.5 ?
>
>

No, it's fixed there. This patch was not backported to 3.2.
2.6.2.1 is likely on its way.

-- 
Philippe.

Re: [Xenomai] Kernel compilation error due to Adeos patch error in 'io_apic.c'

[Gilles Chanteperdrix]

On 12/27/2012 10:38 PM, Wim Meeussen wrote:

>>> I can confirm that this problem still exists with yesterday's
>>> stable Xenomai release 2.6.2, ipipe-core-3.2.21-x86-2.patch, a vanilla 3.2.21
>>> kernel, ang gcc 4.6.3 on Ubuntu 12.04.
> 
>> Ok, do you have the issue with I-pipe core 3.4 and 3.5 ?
> 
> 
> With Xenomai 2.6.2, ipipe-core-3.5.3-x86-2.patch, linux 3.5.3 and gcc
> 4.6.3, I have a different problem, which I haven't been able to solve
> yet (that's why I started using the older 3.2.21 kernel, and ran into
> the problem described above).
> 
> Running "make CONFIG_DEBUG_SECTION_MISMATCH=y -j4" on the 3.5.3 kernel
> sources gives me the result below.  The
> "CONFIG_DEBUG_SECTION_MISMATCH" parameter was suggested by the
> previous build that failed, to get more information on the failure.
> 
> 
> WARNING: drivers/scsi/fcoe/libfcoe.o(.init.text+0x1e): Section
> mismatch in reference from the function init_module() to the function
> .exit.text:fcoe_transport_exit()
> The function __init init_module() references
> a function __exit fcoe_transport_exit().
> This is often seen when error handling in the init function
> uses functionality in the exit path.
> The fix is often to remove the __exit annotation of
> fcoe_transport_exit() so it may be used outside an exit section.
> 


Are you sure this error is related to xenomai?


-- 
                                                                Gilles.

Re: [Xenomai] Kernel compilation error due to Adeos patch error in 'io_apic.c'

[Jeff Webb]

On 12/27/2012 03:42 PM, Gilles Chanteperdrix wrote:
> On 12/27/2012 10:38 PM, Wim Meeussen wrote:
>
>>>> I can confirm that this problem still exists with yesterday's
>>>> stable Xenomai release 2.6.2, ipipe-core-3.2.21-x86-2.patch, a vanilla 3.2.21
>>>> kernel, ang gcc 4.6.3 on Ubuntu 12.04.
>>
>>> Ok, do you have the issue with I-pipe core 3.4 and 3.5 ?
>>
>>
>> With Xenomai 2.6.2, ipipe-core-3.5.3-x86-2.patch, linux 3.5.3 and gcc
>> 4.6.3, I have a different problem, which I haven't been able to solve
>> yet (that's why I started using the older 3.2.21 kernel, and ran into
>> the problem described above).
>>
>> Running "make CONFIG_DEBUG_SECTION_MISMATCH=y -j4" on the 3.5.3 kernel
>> sources gives me the result below.  The
>> "CONFIG_DEBUG_SECTION_MISMATCH" parameter was suggested by the
>> previous build that failed, to get more information on the failure.
>>
>>
>> WARNING: drivers/scsi/fcoe/libfcoe.o(.init.text+0x1e): Section
>> mismatch in reference from the function init_module() to the function
>> .exit.text:fcoe_transport_exit()
>> The function __init init_module() references
>> a function __exit fcoe_transport_exit().
>> This is often seen when error handling in the init function
>> uses functionality in the exit path.
>> The fix is often to remove the __exit annotation of
>> fcoe_transport_exit() so it may be used outside an exit section.
>>
>
>
> Are you sure this error is related to xenomai?
>

For what it's worth, I would guess no.  I had similar problems when compiling a 3.4 series kernel under Ubuntu 12.04.  I solved the problem by disabling the modules that CONFIG_DEBUG_SECTION_MISMATCH was complaining about.  This all had nothing to do with Xenomai.

-Jeff

Re: [Xenomai] Kernel compilation error due to Adeos patch error in 'io_apic.c'

[Wim Meeussen]

>>> Ok, do you have the issue with I-pipe core 3.4 and 3.5 ?

>> With Xenomai 2.6.2, ipipe-core-3.5.3-x86-2.patch, linux 3.5.3 and gcc
>> 4.6.3, I have a different problem, which I haven't been able to solve
>> yet (that's why I started using the older 3.2.21 kernel, and ran into
>> the problem described above).
>>
>> Running "make CONFIG_DEBUG_SECTION_MISMATCH=y -j4" on the 3.5.3 kernel
>> sources gives me the result below.  The
>> "CONFIG_DEBUG_SECTION_MISMATCH" parameter was suggested by the
>> previous build that failed, to get more information on the failure.
>>
>>
>> WARNING: drivers/scsi/fcoe/libfcoe.o(.init.text+0x1e): Section
>> mismatch in reference from the function init_module() to the function
>> .exit.text:fcoe_transport_exit()
>> The function __init init_module() references
>> a function __exit fcoe_transport_exit().
>> This is often seen when error handling in the init function
>> uses functionality in the exit path.
>> The fix is often to remove the __exit annotation of
>> fcoe_transport_exit() so it may be used outside an exit section.


> Are you sure this error is related to xenomai?

I still have to dig a little deeper to check what is causing this
problem, that's why I hadn't reported this before. I'll try to compile
the 3.5.3 kernel with the same configuration, but without the Adeos
patch. I'll follow up on this email when I can confirm the problem is
related to Xenomai.

Thanks for the response!
Wim




--
Wim Meeussen
CTO, hiDOF Inc.
650-529-4522
http://hidof.com