From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: ahemaily@gmail.com
Cc: tony@atomide.com, linux-omap@vger.kernel.org,
linux@arm.linux.org.uk, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] arm :omap :DMA: fix a bug on reserving the omap SDMA channels
Date: Sun, 30 Dec 2012 11:54:42 +0530 [thread overview]
Message-ID: <50DFDE2A.3070800@ti.com> (raw)
In-Reply-To: <1356813800-4705-1-git-send-email-ahemaily@gmail.com>
$subject
s/arm:omap/ARM: OMAP:
On Sunday 30 December 2012 02:13 AM, ahemaily@gmail.com wrote:
> From: ahemaily <ahemaily@gmail.com>
>
> The variable dma_lch_count used for comparison (omap_dma_reserve_channels <= dma_lch_count)
> before it initialized to the value from omap_dma_dev_attr : d->lch_count.
s/it/it is
> I change the place of dma_lch_count initialization to be before the comparison.
>
s/I change the place of dma_lch_count initialization to be before the
comparison./ Initialize dma_lch_count before it is being used for
comparison.
> Signed-off-by: Abdelrahman Hemaily <ahemaily@gmail.com>
> ---
Change looks good to my eyes o.w
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] arm :omap :DMA: fix a bug on reserving the omap SDMA channels
Date: Sun, 30 Dec 2012 11:54:42 +0530 [thread overview]
Message-ID: <50DFDE2A.3070800@ti.com> (raw)
In-Reply-To: <1356813800-4705-1-git-send-email-ahemaily@gmail.com>
$subject
s/arm:omap/ARM: OMAP:
On Sunday 30 December 2012 02:13 AM, ahemaily at gmail.com wrote:
> From: ahemaily <ahemaily@gmail.com>
>
> The variable dma_lch_count used for comparison (omap_dma_reserve_channels <= dma_lch_count)
> before it initialized to the value from omap_dma_dev_attr : d->lch_count.
s/it/it is
> I change the place of dma_lch_count initialization to be before the comparison.
>
s/I change the place of dma_lch_count initialization to be before the
comparison./ Initialize dma_lch_count before it is being used for
comparison.
> Signed-off-by: Abdelrahman Hemaily <ahemaily@gmail.com>
> ---
Change looks good to my eyes o.w
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: <ahemaily@gmail.com>
Cc: <tony@atomide.com>, <linux-omap@vger.kernel.org>,
<linux@arm.linux.org.uk>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/1] arm :omap :DMA: fix a bug on reserving the omap SDMA channels
Date: Sun, 30 Dec 2012 11:54:42 +0530 [thread overview]
Message-ID: <50DFDE2A.3070800@ti.com> (raw)
In-Reply-To: <1356813800-4705-1-git-send-email-ahemaily@gmail.com>
$subject
s/arm:omap/ARM: OMAP:
On Sunday 30 December 2012 02:13 AM, ahemaily@gmail.com wrote:
> From: ahemaily <ahemaily@gmail.com>
>
> The variable dma_lch_count used for comparison (omap_dma_reserve_channels <= dma_lch_count)
> before it initialized to the value from omap_dma_dev_attr : d->lch_count.
s/it/it is
> I change the place of dma_lch_count initialization to be before the comparison.
>
s/I change the place of dma_lch_count initialization to be before the
comparison./ Initialize dma_lch_count before it is being used for
comparison.
> Signed-off-by: Abdelrahman Hemaily <ahemaily@gmail.com>
> ---
Change looks good to my eyes o.w
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
next prev parent reply other threads:[~2012-12-30 6:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-29 20:43 [PATCH 1/1] arm :omap :DMA: fix a bug on reserving the omap SDMA channels ahemaily
2012-12-29 20:43 ` ahemaily
2012-12-29 20:43 ` ahemaily at gmail.com
2012-12-30 6:24 ` Santosh Shilimkar [this message]
2012-12-30 6:24 ` Santosh Shilimkar
2012-12-30 6:24 ` Santosh Shilimkar
2012-12-30 13:09 ` Abdulrahman Hemaily
2012-12-30 13:09 ` Abdulrahman Hemaily
2013-01-03 7:28 ` R Sricharan
2013-01-03 7:28 ` R Sricharan
2013-01-03 7:28 ` R Sricharan
2013-01-03 8:38 ` Santosh Shilimkar
2013-01-03 8:38 ` Santosh Shilimkar
2013-01-03 8:38 ` Santosh Shilimkar
2013-01-03 9:10 ` Igor Grinberg
2013-01-03 9:10 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50DFDE2A.3070800@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=ahemaily@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.