* [PATCH 0/2] Add missing fixed regulators on Origen board
@ 2012-12-28 8:34 Tushar Behera
2012-12-28 8:34 ` [PATCH 1/2] ARM: EXYNOS: Add vmmc regulator for " Tushar Behera
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Tushar Behera @ 2012-12-28 8:34 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: kgene.kim
This patchset adds vmmc and hdmi-en regulators for Origen board.
Tushar Behera (2):
ARM: EXYNOS: Add vmmc regulator for Origen board
ARM: EXYNOS: Add hdmi-en regulator for Origen board
arch/arm/mach-exynos/mach-origen.c | 44 ++++++++++++++++++++++++++++++++++++
1 files changed, 44 insertions(+), 0 deletions(-)
--
1.7.4.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] ARM: EXYNOS: Add vmmc regulator for Origen board 2012-12-28 8:34 [PATCH 0/2] Add missing fixed regulators on Origen board Tushar Behera @ 2012-12-28 8:34 ` Tushar Behera 2012-12-28 8:34 ` [PATCH 2/2] ARM: EXYNOS: Add hdmi-en " Tushar Behera 2012-12-30 6:25 ` [PATCH 0/2] Add missing fixed regulators on " Olof Johansson 2 siblings, 0 replies; 6+ messages in thread From: Tushar Behera @ 2012-12-28 8:34 UTC (permalink / raw) To: linux-samsung-soc; +Cc: kgene.kim SD/MMC driver requires an optional vmmc regulator. Enable this regulator for Origen board. Signed-off-by: Tushar Behera <tushar.behera@linaro.org> --- arch/arm/mach-exynos/mach-origen.c | 36 ++++++++++++++++++++++++++++++++++++ 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/mach-origen.c b/arch/arm/mach-exynos/mach-origen.c index 5e34b9c..4d290e8 100644 --- a/arch/arm/mach-exynos/mach-origen.c +++ b/arch/arm/mach-exynos/mach-origen.c @@ -20,6 +20,7 @@ #include <linux/gpio_keys.h> #include <linux/i2c.h> #include <linux/regulator/machine.h> +#include <linux/regulator/fixed.h> #include <linux/mfd/max8997.h> #include <linux/lcd.h> #include <linux/rfkill-gpio.h> @@ -65,6 +66,10 @@ S5PV210_UFCON_TXTRIG4 | \ S5PV210_UFCON_RXTRIG4) +enum fixed_regulator_id { + FIXED_REG_ID_MMC = 0, +}; + static struct s3c2410_uartcfg origen_uartcfgs[] __initdata = { [0] = { .hwport = 0, @@ -475,6 +480,36 @@ static struct i2c_board_info i2c0_devs[] __initdata = { }, }; +static struct regulator_consumer_supply mmc_supplies[] = { + REGULATOR_SUPPLY("vmmc", "exynos4-sdhci.0"), + REGULATOR_SUPPLY("vmmc", "exynos4-sdhci.2"), +}; + +static struct regulator_init_data mmc_fixed_voltage_init_data = { + .constraints = { + .name = "VMEM_VDD_2.8V", + .valid_ops_mask = REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies = ARRAY_SIZE(mmc_supplies), + .consumer_supplies = mmc_supplies, +}; + +static struct fixed_voltage_config mmc_fixed_voltage_config = { + .supply_name = "MMC_POWER_EN", + .microvolts = 2800000, + .gpio = EXYNOS4_GPX1(1), + .enable_high = true, + .init_data = &mmc_fixed_voltage_init_data, +}; + +static struct platform_device mmc_fixed_voltage = { + .name = "reg-fixed-voltage", + .id = FIXED_REG_ID_MMC, + .dev = { + .platform_data = &mmc_fixed_voltage_config, + }, +}; + static struct s3c_sdhci_platdata origen_hsmmc0_pdata __initdata = { .cd_type = S3C_SDHCI_CD_INTERNAL, }; @@ -690,6 +725,7 @@ static struct platform_device origen_device_bluetooth = { }; static struct platform_device *origen_devices[] __initdata = { + &mmc_fixed_voltage, &s3c_device_hsmmc2, &s3c_device_hsmmc0, &s3c_device_i2c0, -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] ARM: EXYNOS: Add hdmi-en regulator for Origen board 2012-12-28 8:34 [PATCH 0/2] Add missing fixed regulators on Origen board Tushar Behera 2012-12-28 8:34 ` [PATCH 1/2] ARM: EXYNOS: Add vmmc regulator for " Tushar Behera @ 2012-12-28 8:34 ` Tushar Behera 2012-12-30 6:25 ` [PATCH 0/2] Add missing fixed regulators on " Olof Johansson 2 siblings, 0 replies; 6+ messages in thread From: Tushar Behera @ 2012-12-28 8:34 UTC (permalink / raw) To: linux-samsung-soc; +Cc: kgene.kim HDMI driver requires hdmi-en regulator for enabling power to HDMI connector. A fixed 5V line is used on Origen board for this purpose. Signed-off-by: Tushar Behera <tushar.behera@linaro.org> --- arch/arm/mach-exynos/mach-origen.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/mach-origen.c b/arch/arm/mach-exynos/mach-origen.c index 4d290e8..12429f9 100644 --- a/arch/arm/mach-exynos/mach-origen.c +++ b/arch/arm/mach-exynos/mach-origen.c @@ -68,6 +68,7 @@ enum fixed_regulator_id { FIXED_REG_ID_MMC = 0, + FIXED_REG_ID_5V, }; static struct s3c2410_uartcfg origen_uartcfgs[] __initdata = { @@ -101,6 +102,10 @@ static struct s3c2410_uartcfg origen_uartcfgs[] __initdata = { }, }; +static struct regulator_consumer_supply __initdata fixed_5v_supply[] = { + REGULATOR_SUPPLY("hdmi-en", "exynos4-hdmi"), /* HDMI */ +}; + static struct regulator_consumer_supply __initdata ldo3_consumer[] = { REGULATOR_SUPPLY("vddcore", "s5p-mipi-csis.0"), /* MIPI */ REGULATOR_SUPPLY("vdd", "exynos4-hdmi"), /* HDMI */ @@ -836,6 +841,9 @@ static void __init origen_machine_init(void) s5p_fimd0_set_platdata(&origen_lcd_pdata); #endif + regulator_register_always_on(FIXED_REG_ID_5V, "Fixed 5V", + fixed_5v_supply, ARRAY_SIZE(fixed_5v_supply), 5000000); + platform_add_devices(origen_devices, ARRAY_SIZE(origen_devices)); pwm_add_table(origen_pwm_lookup, ARRAY_SIZE(origen_pwm_lookup)); -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Add missing fixed regulators on Origen board 2012-12-28 8:34 [PATCH 0/2] Add missing fixed regulators on Origen board Tushar Behera 2012-12-28 8:34 ` [PATCH 1/2] ARM: EXYNOS: Add vmmc regulator for " Tushar Behera 2012-12-28 8:34 ` [PATCH 2/2] ARM: EXYNOS: Add hdmi-en " Tushar Behera @ 2012-12-30 6:25 ` Olof Johansson 2012-12-31 2:53 ` Tushar Behera 2 siblings, 1 reply; 6+ messages in thread From: Olof Johansson @ 2012-12-30 6:25 UTC (permalink / raw) To: Tushar Behera; +Cc: linux-samsung-soc, kgene.kim Hi, On Fri, Dec 28, 2012 at 12:34 AM, Tushar Behera <tushar.behera@linaro.org> wrote: > This patchset adds vmmc and hdmi-en regulators for Origen board. > > Tushar Behera (2): > ARM: EXYNOS: Add vmmc regulator for Origen board > ARM: EXYNOS: Add hdmi-en regulator for Origen board The vmmc one seems to already be there in the dts file for origen. It looks like the HDMI one is still needed though. Please move to using DT board files instead of expanding the legacy board files. -Olof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Add missing fixed regulators on Origen board 2012-12-30 6:25 ` [PATCH 0/2] Add missing fixed regulators on " Olof Johansson @ 2012-12-31 2:53 ` Tushar Behera 2013-01-02 19:28 ` Olof Johansson 0 siblings, 1 reply; 6+ messages in thread From: Tushar Behera @ 2012-12-31 2:53 UTC (permalink / raw) To: Olof Johansson; +Cc: linux-samsung-soc, kgene.kim On 12/30/2012 11:55 AM, Olof Johansson wrote: > Hi, > > On Fri, Dec 28, 2012 at 12:34 AM, Tushar Behera > <tushar.behera@linaro.org> wrote: >> This patchset adds vmmc and hdmi-en regulators for Origen board. >> >> Tushar Behera (2): >> ARM: EXYNOS: Add vmmc regulator for Origen board >> ARM: EXYNOS: Add hdmi-en regulator for Origen board > > The vmmc one seems to already be there in the dts file for origen. It > looks like the HDMI one is still needed though. > DT enablement patches for HDMI driver were posted sometime back, but they have not yet been merged in trunk. So HDMI regulator entry for DT will be added after that. > Please move to using DT board files instead of expanding the legacy board files. > Sure, the focus would be on adding DT support. Legacy board support for Origen is pretty much complete with support for various multimedia drivers, so it provides a good environment for testing different features. It would be good to get these patches in for enabling HDMI support, which otherwise would be broken if REGULATOR_DUMMY is not defined. > > -Olof > -- Tushar Behera ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Add missing fixed regulators on Origen board 2012-12-31 2:53 ` Tushar Behera @ 2013-01-02 19:28 ` Olof Johansson 0 siblings, 0 replies; 6+ messages in thread From: Olof Johansson @ 2013-01-02 19:28 UTC (permalink / raw) To: Tushar Behera; +Cc: linux-samsung-soc, kgene.kim On Mon, Dec 31, 2012 at 08:23:22AM +0530, Tushar Behera wrote: > On 12/30/2012 11:55 AM, Olof Johansson wrote: > > Hi, > > > > On Fri, Dec 28, 2012 at 12:34 AM, Tushar Behera > > <tushar.behera@linaro.org> wrote: > >> This patchset adds vmmc and hdmi-en regulators for Origen board. > >> > >> Tushar Behera (2): > >> ARM: EXYNOS: Add vmmc regulator for Origen board > >> ARM: EXYNOS: Add hdmi-en regulator for Origen board > > > > The vmmc one seems to already be there in the dts file for origen. It > > looks like the HDMI one is still needed though. > > > > DT enablement patches for HDMI driver were posted sometime back, but > they have not yet been merged in trunk. So HDMI regulator entry for DT > will be added after that. > > > Please move to using DT board files instead of expanding the legacy board files. > > > > Sure, the focus would be on adding DT support. > > Legacy board support for Origen is pretty much complete with support for > various multimedia drivers, so it provides a good environment for > testing different features. It would be good to get these patches in for > enabling HDMI support, which otherwise would be broken if > REGULATOR_DUMMY is not defined. Ok. Sounds like the work to mostly remove legacy board files is planned to happen soon, so if this helps things meanwhile I guess it's ok. I just prefer to avoid seeing churn that's just going to be removed soon anyway. -Olof ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-02 19:28 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-12-28 8:34 [PATCH 0/2] Add missing fixed regulators on Origen board Tushar Behera 2012-12-28 8:34 ` [PATCH 1/2] ARM: EXYNOS: Add vmmc regulator for " Tushar Behera 2012-12-28 8:34 ` [PATCH 2/2] ARM: EXYNOS: Add hdmi-en " Tushar Behera 2012-12-30 6:25 ` [PATCH 0/2] Add missing fixed regulators on " Olof Johansson 2012-12-31 2:53 ` Tushar Behera 2013-01-02 19:28 ` Olof Johansson
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.