From: Jon Hunter <jon-hunter@ti.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Tero Kristo <t-kristo@ti.com>, Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH 1/2] ARM: OMAP4: clock data: ABE DPLL need to be locked on all revisions
Date: Thu, 3 Jan 2013 12:58:50 -0600 [thread overview]
Message-ID: <50E5D4EA.5030001@ti.com> (raw)
In-Reply-To: <1357220811-29904-2-git-send-email-peter.ujfalusi@ti.com>
Hi Peter,
On 01/03/2013 07:46 AM, Peter Ujfalusi wrote:
> We need to lock ABE DPPL on al OMAP4 revisions, not only for OMAP446x
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> arch/arm/mach-omap2/cclock44xx_data.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/cclock44xx_data.c b/arch/arm/mach-omap2/cclock44xx_data.c
> index 5789a5e..79c32ce 100644
> --- a/arch/arm/mach-omap2/cclock44xx_data.c
> +++ b/arch/arm/mach-omap2/cclock44xx_data.c
> @@ -2023,17 +2023,15 @@ int __init omap4xxx_clk_init(void)
> ARRAY_SIZE(enable_init_clks));
>
> /*
> - * On OMAP4460 the ABE DPLL fails to turn on if in idle low-power
> + * On OMAP4 the ABE DPLL fails to turn on if in idle low-power
> * state when turning the ABE clock domain. Workaround this by
> * locking the ABE DPLL on boot.
I am not sure that this change to the comment is completely accurate. On
OMAP4430 I did not see any issues with the DPLL failing to turn on if
the DPLL was not locked. I only saw this particular problem on the 4460.
Therefore, it may be better to leave the comment as-is and add an
additional sentence to state that the DPLL should be locked for all
OMAP4 devices for audio to work correctly.
Cheers
Jon
WARNING: multiple messages have this Message-ID (diff)
From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: OMAP4: clock data: ABE DPLL need to be locked on all revisions
Date: Thu, 3 Jan 2013 12:58:50 -0600 [thread overview]
Message-ID: <50E5D4EA.5030001@ti.com> (raw)
In-Reply-To: <1357220811-29904-2-git-send-email-peter.ujfalusi@ti.com>
Hi Peter,
On 01/03/2013 07:46 AM, Peter Ujfalusi wrote:
> We need to lock ABE DPPL on al OMAP4 revisions, not only for OMAP446x
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> arch/arm/mach-omap2/cclock44xx_data.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/cclock44xx_data.c b/arch/arm/mach-omap2/cclock44xx_data.c
> index 5789a5e..79c32ce 100644
> --- a/arch/arm/mach-omap2/cclock44xx_data.c
> +++ b/arch/arm/mach-omap2/cclock44xx_data.c
> @@ -2023,17 +2023,15 @@ int __init omap4xxx_clk_init(void)
> ARRAY_SIZE(enable_init_clks));
>
> /*
> - * On OMAP4460 the ABE DPLL fails to turn on if in idle low-power
> + * On OMAP4 the ABE DPLL fails to turn on if in idle low-power
> * state when turning the ABE clock domain. Workaround this by
> * locking the ABE DPLL on boot.
I am not sure that this change to the comment is completely accurate. On
OMAP4430 I did not see any issues with the DPLL failing to turn on if
the DPLL was not locked. I only saw this particular problem on the 4460.
Therefore, it may be better to leave the comment as-is and add an
additional sentence to state that the DPLL should be locked for all
OMAP4 devices for audio to work correctly.
Cheers
Jon
next prev parent reply other threads:[~2013-01-03 18:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 13:46 [PATCH 0/2] ARM: OMAP4: Audio regression fix for 3.8 kernel Peter Ujfalusi
2013-01-03 13:46 ` Peter Ujfalusi
2013-01-03 13:46 ` [PATCH 1/2] ARM: OMAP4: clock data: ABE DPLL need to be locked on all revisions Peter Ujfalusi
2013-01-03 13:46 ` Peter Ujfalusi
2013-01-03 18:58 ` Jon Hunter [this message]
2013-01-03 18:58 ` Jon Hunter
2013-01-03 23:26 ` Paul Walmsley
2013-01-03 23:26 ` Paul Walmsley
2013-01-04 9:59 ` Peter Ujfalusi
2013-01-04 9:59 ` Peter Ujfalusi
2013-01-03 13:46 ` [PATCH 2/2] ARM: OMAP4: hwmod_data: Correct IDLEMODE for McPDM Peter Ujfalusi
2013-01-03 13:46 ` Peter Ujfalusi
2013-01-03 17:56 ` [PATCH 0/2] ARM: OMAP4: Audio regression fix for 3.8 kernel Paul Walmsley
2013-01-03 17:56 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E5D4EA.5030001@ti.com \
--to=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=peter.ujfalusi@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.