From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>,
iwamatsu@nigauri.org, linux-pm@vger.kernel.org,
Sebastian Hesselbarth <sebastian.hesselbarth@googlemail.com>,
jgunthorpe@obsidianresearch.com,
linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] thermal: Add support for thermal sensor for Orion SoC
Date: Fri, 4 Jan 2013 11:47:53 +0200 [thread overview]
Message-ID: <50E6A549.5050407@ti.com> (raw)
In-Reply-To: <50E6A378.90503@ti.com>
Hello again,
On 04-01-2013 11:40, Eduardo Valentin wrote:
> Hey Andrew,
>
> On 14-12-2012 13:03, Andrew Lunn wrote:
>> From: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
<cut>
>
> I believe you forgot to request this memory. I suggest you do:
> + thermal_dev->base_addr = devm_request_and_ioremap(&pdev->dev,
> res->start,
> + res);
>
small fix:
+ thermal_dev->base_addr = devm_request_and_ioremap(&pdev->dev,
+ res);
WARNING: multiple messages have this Message-ID (diff)
From: eduardo.valentin@ti.com (Eduardo Valentin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] thermal: Add support for thermal sensor for Orion SoC
Date: Fri, 4 Jan 2013 11:47:53 +0200 [thread overview]
Message-ID: <50E6A549.5050407@ti.com> (raw)
In-Reply-To: <50E6A378.90503@ti.com>
Hello again,
On 04-01-2013 11:40, Eduardo Valentin wrote:
> Hey Andrew,
>
> On 14-12-2012 13:03, Andrew Lunn wrote:
>> From: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
<cut>
>
> I believe you forgot to request this memory. I suggest you do:
> + thermal_dev->base_addr = devm_request_and_ioremap(&pdev->dev,
> res->start,
> + res);
>
small fix:
+ thermal_dev->base_addr = devm_request_and_ioremap(&pdev->dev,
+ res);
next prev parent reply other threads:[~2013-01-04 9:48 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 11:03 [PATCH 0/2] Thermal sensor for Orion/Kirkwood Andrew Lunn
2012-12-14 11:03 ` Andrew Lunn
2012-12-14 11:03 ` [PATCH 1/2] thermal: Add support for thermal sensor for Orion SoC Andrew Lunn
2012-12-14 11:03 ` Andrew Lunn
2012-12-14 11:30 ` R, Durgadoss
2012-12-14 11:30 ` R, Durgadoss
2012-12-14 11:50 ` Andrew Lunn
2012-12-14 11:50 ` Andrew Lunn
2012-12-14 22:03 ` Nobuhiro Iwamatsu
2012-12-14 22:03 ` Nobuhiro Iwamatsu
2012-12-14 18:13 ` Jason Gunthorpe
2012-12-14 18:13 ` Jason Gunthorpe
2012-12-14 21:54 ` Nobuhiro Iwamatsu
2012-12-14 21:54 ` Nobuhiro Iwamatsu
2012-12-14 22:11 ` Andrew Lunn
2012-12-14 22:11 ` Andrew Lunn
2013-01-04 7:33 ` Zhang Rui
2013-01-04 7:33 ` Zhang Rui
2013-01-04 8:15 ` Andrew Lunn
2013-01-04 8:15 ` Andrew Lunn
2013-01-04 9:40 ` Eduardo Valentin
2013-01-04 9:40 ` Eduardo Valentin
2013-01-04 9:47 ` Eduardo Valentin [this message]
2013-01-04 9:47 ` Eduardo Valentin
2013-01-04 15:35 ` Andrew Lunn
2013-01-04 15:35 ` Andrew Lunn
2013-01-07 10:06 ` Eduardo Valentin
2013-01-07 10:06 ` Eduardo Valentin
2013-01-07 10:16 ` Andrew Lunn
2013-01-07 10:16 ` Andrew Lunn
2012-12-14 11:03 ` [PATCH 2/2] ARM: Kirkwood: Add support thermal sensor for 88F6282 and 88F6283 Andrew Lunn
2012-12-14 11:03 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E6A549.5050407@ti.com \
--to=eduardo.valentin@ti.com \
--cc=andrew@lunn.ch \
--cc=iwamatsu@nigauri.org \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=sebastian.hesselbarth@googlemail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.