All of lore.kernel.org
 help / color / mirror / Atom feed
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/9] Migrate Tegra to common clock framework
Date: Fri, 04 Jan 2013 10:22:45 -0700	[thread overview]
Message-ID: <50E70FE5.9010001@wwwdotorg.org> (raw)
In-Reply-To: <1357292453-28418-1-git-send-email-pgaikwad@nvidia.com>

On 01/04/2013 02:40 AM, Prashant Gaikwad wrote:
> This patchset does following:
> 1. Decompose single tegra clock structure into multiple clocks.
> 2. Try to use standard clock types supported by common clock framework.
> 3. Use dynamic initialization.
> 4. Move all clock code to drivers/clk/tegra from mach-tegra.
> 5. Add device tree support for Tegra20 and Tegra30 clocks.
> 6. Remove all legacy clock code from mach-tegra.

I think there are bugs here. I applied all your clock patches on top of
Tegra's for-next (see list below), and found that the following don't
work on Springbank:

* HDMI display
* Audio playback
* WiFi

I imagine the same issue would be seen on Harmony or Ventana since
they're very similar. All of those functions work fine with Tegra's
for-next branch (commit 5e30b49 "Merge branch 'for-3.9/defconfig' into
for-next").

I didn't try Tegra30. I assume you'll test both SoCs...

864e964 clk: vexpress: Use common of_clk_init() function
c4e8389 clk: zynq: Use common of_clk_init() function
2c9ff0c clk: vt8500: Use common of_clk_init() function
db9c59c clk: highbank: Use common of_clk_init() function
b40949b clk: sunxi: Use common of_clk_init() function
f6d1492 clk: tegra: Use common of_clk_init() function
f6fd2eb clk: add common of_clk_init() function
70a8ea3 clk: tegra30: remove unused TEGRA_CLK_DUPLICATE()s
3945e4f clk: tegra20: remove unused TEGRA_CLK_DUPLICATE()s
587bcca arm: tegra30: remove auxdata
52b982f arm: tegra20: remove auxdata
3381359 ASoC: tegra: remove auxdata
d31ea1b ARM: dt: tegra30: Add clock information
542ddb5 ARM: dt: tegra20: Add clock information
dd19f5f arm: tegra: Remove legacy clock code
aaf17b6 arm: tegra: Migrate to new clock code
458a3ae clk: tegra: add clock support for tegra30
edb65f1 clk: tegra: add clock support for tegra20
1786e1f ARM: Tegra: Define Tegra30 CAR binding
7d77415 ARM: tegra: Define Tegra20 CAR binding
a4798fa arm: tegra: Move tegra_cpu_car.h to linux/clk/tegra.h
df05a02 clk: tegra: Add tegra specific clocks
ad00a81 ARM: tegra: Add function to read chipid

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Prashant Gaikwad <pgaikwad@nvidia.com>
Cc: mturquette@linaro.org, swarren@nvidia.com,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/9] Migrate Tegra to common clock framework
Date: Fri, 04 Jan 2013 10:22:45 -0700	[thread overview]
Message-ID: <50E70FE5.9010001@wwwdotorg.org> (raw)
In-Reply-To: <1357292453-28418-1-git-send-email-pgaikwad@nvidia.com>

On 01/04/2013 02:40 AM, Prashant Gaikwad wrote:
> This patchset does following:
> 1. Decompose single tegra clock structure into multiple clocks.
> 2. Try to use standard clock types supported by common clock framework.
> 3. Use dynamic initialization.
> 4. Move all clock code to drivers/clk/tegra from mach-tegra.
> 5. Add device tree support for Tegra20 and Tegra30 clocks.
> 6. Remove all legacy clock code from mach-tegra.

I think there are bugs here. I applied all your clock patches on top of
Tegra's for-next (see list below), and found that the following don't
work on Springbank:

* HDMI display
* Audio playback
* WiFi

I imagine the same issue would be seen on Harmony or Ventana since
they're very similar. All of those functions work fine with Tegra's
for-next branch (commit 5e30b49 "Merge branch 'for-3.9/defconfig' into
for-next").

I didn't try Tegra30. I assume you'll test both SoCs...

864e964 clk: vexpress: Use common of_clk_init() function
c4e8389 clk: zynq: Use common of_clk_init() function
2c9ff0c clk: vt8500: Use common of_clk_init() function
db9c59c clk: highbank: Use common of_clk_init() function
b40949b clk: sunxi: Use common of_clk_init() function
f6d1492 clk: tegra: Use common of_clk_init() function
f6fd2eb clk: add common of_clk_init() function
70a8ea3 clk: tegra30: remove unused TEGRA_CLK_DUPLICATE()s
3945e4f clk: tegra20: remove unused TEGRA_CLK_DUPLICATE()s
587bcca arm: tegra30: remove auxdata
52b982f arm: tegra20: remove auxdata
3381359 ASoC: tegra: remove auxdata
d31ea1b ARM: dt: tegra30: Add clock information
542ddb5 ARM: dt: tegra20: Add clock information
dd19f5f arm: tegra: Remove legacy clock code
aaf17b6 arm: tegra: Migrate to new clock code
458a3ae clk: tegra: add clock support for tegra30
edb65f1 clk: tegra: add clock support for tegra20
1786e1f ARM: Tegra: Define Tegra30 CAR binding
7d77415 ARM: tegra: Define Tegra20 CAR binding
a4798fa arm: tegra: Move tegra_cpu_car.h to linux/clk/tegra.h
df05a02 clk: tegra: Add tegra specific clocks
ad00a81 ARM: tegra: Add function to read chipid


  parent reply	other threads:[~2013-01-04 17:22 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-04  9:40 [PATCH v3 0/9] Migrate Tegra to common clock framework Prashant Gaikwad
2013-01-04  9:40 ` Prashant Gaikwad
2013-01-04  9:40 ` [PATCH v3 1/9] ARM: tegra: Add function to read chipid Prashant Gaikwad
2013-01-04  9:40   ` Prashant Gaikwad
2013-01-04  9:40 ` [PATCH v3 2/9] clk: tegra: Add tegra specific clocks Prashant Gaikwad
2013-01-04  9:40   ` Prashant Gaikwad
2013-01-04  9:40 ` [PATCH v3 3/9] arm: tegra: Move tegra_cpu_car.h to linux/clk/tegra.h Prashant Gaikwad
2013-01-04  9:40   ` Prashant Gaikwad
2013-01-04  9:40 ` [PATCH v3 4/9] ARM: tegra: Define Tegra20 CAR binding Prashant Gaikwad
2013-01-04  9:40   ` Prashant Gaikwad
2013-01-04  9:40 ` [PATCH v3 5/9] ARM: Tegra: Define Tegra30 " Prashant Gaikwad
2013-01-04  9:40   ` Prashant Gaikwad
2013-01-04  9:40 ` [PATCH v3 6/9] clk: tegra: add clock support for tegra20 Prashant Gaikwad
2013-01-04  9:40   ` Prashant Gaikwad
2013-01-04  9:40 ` [PATCH v3 7/9] clk: tegra: add clock support for tegra30 Prashant Gaikwad
2013-01-04  9:40   ` Prashant Gaikwad
2013-01-04  9:40 ` [PATCH v3 8/9] arm: tegra: Migrate to new clock code Prashant Gaikwad
2013-01-04  9:40   ` Prashant Gaikwad
2013-01-04  9:40 ` [PATCH v3 9/9] arm: tegra: Remove legacy " Prashant Gaikwad
2013-01-04  9:40   ` Prashant Gaikwad
2013-01-04 11:20 ` [PATCH v3 0/9] Migrate Tegra to common clock framework Joseph Lo
2013-01-04 11:20   ` Joseph Lo
2013-01-04 17:22 ` Stephen Warren [this message]
2013-01-04 17:22   ` Stephen Warren
     [not found]   ` <50E70FE5.9010001-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-08  0:10     ` Stephen Warren
2013-01-08  0:10       ` Stephen Warren
     [not found]       ` <50EB6403.5090300-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-08 13:19         ` Prashant Gaikwad
2013-01-08 13:19           ` Prashant Gaikwad
     [not found]           ` <50EC1CD3.3070308-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-08 18:49             ` Stephen Warren
2013-01-08 18:49               ` Stephen Warren
     [not found]               ` <50EC6A37.4000206-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-08 21:01                 ` Stephen Warren
2013-01-08 21:01                   ` Stephen Warren
     [not found]                   ` <50EC8947.4080704-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-09 10:59                     ` Prashant Gaikwad
2013-01-09 10:59                       ` Prashant Gaikwad
     [not found]                       ` <50ED4DA9.3090406-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-09 17:34                         ` Stephen Warren
2013-01-09 17:34                           ` Stephen Warren
     [not found]                           ` <50EDAA39.3040609-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-09 20:44                             ` Stephen Warren
2013-01-09 20:44                               ` Stephen Warren
     [not found]                               ` <50EDD693.2060905-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-11  8:10                                 ` Prashant Gaikwad
2013-01-11  8:10                                   ` Prashant Gaikwad
     [not found]                                   ` <50EFC8DB.6090903-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-11 15:59                                     ` Marc Dietrich
2013-01-11 15:59                                       ` Marc Dietrich
2013-01-11 18:23                                       ` Stephen Warren
2013-01-11 18:23                                         ` Stephen Warren
     [not found]                                         ` <50F058BC.9090909-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-11 19:52                                           ` Marc Dietrich
2013-01-11 19:52                                             ` Marc Dietrich
2013-01-11  8:12                             ` Prashant Gaikwad
2013-01-11  8:12                               ` Prashant Gaikwad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50E70FE5.9010001@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.