All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Holler <holler@ahsoftware.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Borislav Petkov <bp@alien8.de>, Shawn Guo <shawn.guo@linaro.org>,
	Sasha Levin <levinsasha928@gmail.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Josh Boyer <jwboyer@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Florian Tobias Schandinat <florianSchandinat@gmx.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fbdev@vger.kernel.org,
	Bernie Thompson <bernie@plugable.com>,
	Steve Glendinning <steve.glendinning@shawell.net>,
	Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH] fb: Rework locking to fix lock ordering on takeover
Date: Sat, 05 Jan 2013 12:06:59 +0000	[thread overview]
Message-ID: <50E81763.1070501@ahsoftware.de> (raw)
In-Reply-To: <20130105120729.7677c333@pyramind.ukuu.org.uk>

Am 05.01.2013 13:07, schrieb Alan Cox:
>> So to add such an "I am crap" flag my idea would be to add an
>> .fb_handle_damage to struct fb_ops and then call that (if exists)
>> whenever something was changed.
>
> I was thinking much higher level - ie at the printk kind of level
>
>> My patch (for udlfb) follows as an reply to this message. If that patch
>> is ok, it should be applied to smscufx too (I would make it). In regard
>> to udl I don't know, I haven't had a deeper look at it nor used it up to
>> now.
>
> Looks pretty clean as a solution to me.

Thanks and sorry for the two empty lines in the patch. I swear I had a 
look at the patch before sending it out, but haven't seen them.

So should I make the same patch for smscufx  and while beeing there, 
send out at v2 without those 2 empty lines?

Regards,

Alexander



WARNING: multiple messages have this Message-ID (diff)
From: Alexander Holler <holler@ahsoftware.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Borislav Petkov <bp@alien8.de>, Shawn Guo <shawn.guo@linaro.org>,
	Sasha Levin <levinsasha928@gmail.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Josh Boyer <jwboyer@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Florian Tobias Schandinat <florianSchandinat@gmx.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fbdev@vger.kernel.org,
	Bernie Thompson <bernie@plugable.com>,
	Steve Glendinning <steve.glendinning@shawell.net>,
	Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH] fb: Rework locking to fix lock ordering on takeover
Date: Sat, 05 Jan 2013 13:06:59 +0100	[thread overview]
Message-ID: <50E81763.1070501@ahsoftware.de> (raw)
In-Reply-To: <20130105120729.7677c333@pyramind.ukuu.org.uk>

Am 05.01.2013 13:07, schrieb Alan Cox:
>> So to add such an "I am crap" flag my idea would be to add an
>> .fb_handle_damage to struct fb_ops and then call that (if exists)
>> whenever something was changed.
>
> I was thinking much higher level - ie at the printk kind of level
>
>> My patch (for udlfb) follows as an reply to this message. If that patch
>> is ok, it should be applied to smscufx too (I would make it). In regard
>> to udl I don't know, I haven't had a deeper look at it nor used it up to
>> now.
>
> Looks pretty clean as a solution to me.

Thanks and sorry for the two empty lines in the patch. I swear I had a 
look at the patch before sending it out, but haven't seen them.

So should I make the same patch for smscufx  and while beeing there, 
send out at v2 without those 2 empty lines?

Regards,

Alexander



  reply	other threads:[~2013-01-05 12:06 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-16 19:27 [PATCH] fb: Rework locking to fix lock ordering on takeover Alan Cox
2012-11-21 12:45 ` Josh Boyer
2012-11-21 12:53   ` Alan Cox
2012-12-18 15:20     ` Josh Boyer
2012-12-25 16:08       ` Sasha Levin
2012-12-26  2:41         ` Cong Wang
2012-12-26 18:09           ` Sasha Levin
2012-12-27  4:53             ` Borislav Petkov
2012-12-28 11:50               ` Shawn Guo
2012-12-28 12:40                 ` Borislav Petkov
2013-01-04 12:50                   ` Alexander Holler
2013-01-04 12:50                     ` Alexander Holler
2013-01-04 13:25                     ` Alan Cox
2013-01-04 13:25                       ` Alan Cox
2013-01-04 13:36                       ` Alexander Holler
2013-01-04 13:36                         ` Alexander Holler
2013-01-05 11:41                         ` Alexander Holler
2013-01-05 11:41                           ` Alexander Holler
2013-01-05 11:42                           ` [PATCH] fb: udlfb: fix scheduling while atomic Alexander Holler
2013-01-05 11:42                             ` Alexander Holler
2013-01-06 12:46                             ` Alexander Holler
2013-01-06 12:46                               ` Alexander Holler
2013-01-09 13:47                               ` [PATCH v2] " Alexander Holler
2013-01-09 13:47                                 ` Alexander Holler
2013-01-05 12:07                           ` [PATCH] fb: Rework locking to fix lock ordering on takeover Alan Cox
2013-01-05 12:07                             ` Alan Cox
2013-01-05 12:06                             ` Alexander Holler [this message]
2013-01-05 12:06                               ` Alexander Holler
2013-01-07  9:37                   ` Jiri Kosina
2013-01-12 18:36                     ` Borislav Petkov
2013-01-12 20:51                       ` Linus Torvalds
2013-01-12 21:05                         ` Alan Cox
2013-01-12 21:13                         ` Andrew Morton
2013-01-13  0:02                           ` Borislav Petkov
2013-01-15 12:06                             ` Maarten Lankhorst
2013-01-15 15:12                               ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50E81763.1070501@ahsoftware.de \
    --to=holler@ahsoftware.de \
    --cc=airlied@redhat.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bernie@plugable.com \
    --cc=bp@alien8.de \
    --cc=florianSchandinat@gmx.de \
    --cc=jwboyer@gmail.com \
    --cc=levinsasha928@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=steve.glendinning@shawell.net \
    --cc=torvalds@linux-foundation.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.