All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeroen Hofstee <jeroen@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] global variables from comon/lcd.c
Date: Sat, 05 Jan 2013 19:16:28 +0100	[thread overview]
Message-ID: <50E86DFC.20304@myspectrum.nl> (raw)

Hi,

While looking at the common/lcd.c I fail to understand why it declares
and uses global variables like lcd_color_fg, lcd_color_color_bg, lcd_base
and relies on the drivers / boards to provide them, leading to code
duplication. It also provides getters / setters for some of these variables.

To me it seems more logical to have these variables in lcd.c itself. This
construction has been around since at least 2004 though, so I tend to
think I am missing something.

Does someone know the reason why these variables are not part
of lcd.c itself?

Regards,
Jeroen

             reply	other threads:[~2013-01-05 18:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-05 18:16 Jeroen Hofstee [this message]
2013-01-05 19:40 ` [U-Boot] global variables from comon/lcd.c Wolfgang Denk
2013-01-05 19:45 ` [U-Boot] [PATCH] common/lcd.c: cleanup use of global variables Wolfgang Denk
2013-01-05 19:50   ` Wolfgang Denk
2013-01-06 22:43     ` Jeroen Hofstee
2013-01-12 17:07       ` Simon Glass
2013-01-06 23:33     ` Anatolij Gustschin
2013-01-12 17:06   ` Simon Glass
2013-01-25 21:26   ` Jeroen Hofstee
2013-03-29 10:56   ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50E86DFC.20304@myspectrum.nl \
    --to=jeroen@myspectrum.nl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.