From: Jeroen Hofstee <jeroen@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common/lcd.c: cleanup use of global variables
Date: Fri, 25 Jan 2013 22:26:13 +0100 [thread overview]
Message-ID: <5102F875.8030309@myspectrum.nl> (raw)
In-Reply-To: <1357415148-9243-1-git-send-email-wd@denx.de>
On 01/05/2013 08:45 PM, Wolfgang Denk wrote:
> lcd_color_fg and lcd_color_bg had to be declared in board specific
> code, but were not actually used there; in addition, we have getter /
> setter functions for these, which were not used either.
>
> Get rid of the global variables, and use the getter function where
> needed (so far no setter calls are needed).
>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Alessandro Rubini <rubini@unipv.it>
> Cc: Anatolij Gustschin <agust@denx.de>
> Cc: Bo Shen <voice.shen@atmel.com>
> Cc: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Nikita Kiryanov <nikita@compulab.co.il>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Stelian Pop <stelian@popies.net>
> Cc: Tom Warren <twarren@nvidia.com>
> ---
>
Acked-by: Jeroen Hofstee <jeroen@myspectrum.nl>
next prev parent reply other threads:[~2013-01-25 21:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-05 18:16 [U-Boot] global variables from comon/lcd.c Jeroen Hofstee
2013-01-05 19:40 ` Wolfgang Denk
2013-01-05 19:45 ` [U-Boot] [PATCH] common/lcd.c: cleanup use of global variables Wolfgang Denk
2013-01-05 19:50 ` Wolfgang Denk
2013-01-06 22:43 ` Jeroen Hofstee
2013-01-12 17:07 ` Simon Glass
2013-01-06 23:33 ` Anatolij Gustschin
2013-01-12 17:06 ` Simon Glass
2013-01-25 21:26 ` Jeroen Hofstee [this message]
2013-03-29 10:56 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5102F875.8030309@myspectrum.nl \
--to=jeroen@myspectrum.nl \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.