All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <elder@inktank.com>
To: linux-sctp@vger.kernel.org
Subject: [PATCH] sctp: fix Kconfig bug in default cookie hmac selection
Date: Mon, 07 Jan 2013 16:47:46 +0000	[thread overview]
Message-ID: <50EAFC32.9030104@inktank.com> (raw)

The following commit added a "choice" to the sctp Kconfig file.  It
introduced a bug which led to an infinite loop when while running
"make oldconfig".

    0d0863b0 sctp: Change defaults on cookie hmac selection

The problem is that the wrong symbol was defined as the default
value for the choice.  Using the correct value gets rid of the
infinite loop.

Note:  if CONFIG_SCTP_COOKIE_HMAC_SHA1=y was present in the input
config file, both that and CONFIG_SCTP_COOKIE_HMAC_MD5=y be present
in the generated config file.

Signed-off-by: Alex Elder <elder@inktank.com>
---
 net/sctp/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sctp/Kconfig b/net/sctp/Kconfig
index c262106..7521d94 100644
--- a/net/sctp/Kconfig
+++ b/net/sctp/Kconfig
@@ -68,7 +68,7 @@ config SCTP_DBG_OBJCNT
 	  If unsure, say N
 choice
 	prompt "Default SCTP cookie HMAC encoding"
-	default SCTP_COOKIE_HMAC_MD5
+	default SCTP_DEFAULT_COOKIE_HMAC_MD5
 	help
 	  This option sets the default sctp cookie hmac algorithm
 	  when in doubt select 'md5'
-- 
1.7.9.5


             reply	other threads:[~2013-01-07 16:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07 16:47 Alex Elder [this message]
2013-01-07 17:41 ` [PATCH] sctp: fix Kconfig bug in default cookie hmac selection Neil Horman
2013-01-07 17:53 ` Alex Elder
2013-01-07 17:53 ` Vlad Yasevich
2013-01-07 18:04 ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50EAFC32.9030104@inktank.com \
    --to=elder@inktank.com \
    --cc=linux-sctp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.