Re: [PATCH] sctp: fix Kconfig bug in default cookie hmac selection

[Vlad Yasevich <vyasevich@gmail.com>]

On 01/07/2013 11:47 AM, Alex Elder wrote:
> The following commit added a "choice" to the sctp Kconfig file.  It
> introduced a bug which led to an infinite loop when while running
> "make oldconfig".
>
>      0d0863b0 sctp: Change defaults on cookie hmac selection
>
> The problem is that the wrong symbol was defined as the default
> value for the choice.  Using the correct value gets rid of the
> infinite loop.
>
> Note:  if CONFIG_SCTP_COOKIE_HMAC_SHA1=y was present in the input
> config file, both that and CONFIG_SCTP_COOKIE_HMAC_MD5=y be present
> in the generated config file.
>
> Signed-off-by: Alex Elder <elder@inktank.com>
> ---
>   net/sctp/Kconfig |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sctp/Kconfig b/net/sctp/Kconfig
> index c262106..7521d94 100644
> --- a/net/sctp/Kconfig
> +++ b/net/sctp/Kconfig
> @@ -68,7 +68,7 @@ config SCTP_DBG_OBJCNT
>   	  If unsure, say N
>   choice
>   	prompt "Default SCTP cookie HMAC encoding"
> -	default SCTP_COOKIE_HMAC_MD5
> +	default SCTP_DEFAULT_COOKIE_HMAC_MD5
>   	help
>   	  This option sets the default sctp cookie hmac algorithm
>   	  when in doubt select 'md5'
>

Tested-by: Vlad Yasevich <vyasevich@gmail.com>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>

This does resolve the loop and makes the oldconfig behavior consistent 
with menuconfig.

-vlad