Re: [Qemu-devel] [PATCH 2/3] qga: add guest-get-time command

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

On 01/06/2013 03:06 AM, Lei Li wrote:
> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> ---
>  qga/commands-posix.c |   12 ++++++++++++
>  qga/qapi-schema.json |   17 +++++++++++++++++
>  2 files changed, 29 insertions(+), 0 deletions(-)
> 

> +++ b/qga/qapi-schema.json
> @@ -100,6 +100,23 @@
>               'utc-offset': 'int' } }
>  
>  ##
> +# @guest-get-time:
> +#
> +# Get the information about host time in UTC and the
> +# UTC offset.

About the host time, or about the guest time?  In other words, doesn't
this command exist for the host to ask the guest what time the _guest_
thinks it is, so that the host can then decide whether to issue a
followup command to tell the guest to adjust its time?

> +#
> +# This command tries to get the host time which is
> +# presumably correct, since need to be able to resynchronize
> +# clock to host in guest.
> +#
> +# Returns: @HostTimeInfo on success.

For that matter, should we name the type in patch 1/3 'TimeInfo',
instead of 'HostTimeInfo', as it is not intrinsically tied to host or
guest, but more a function of who is being queried?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]