Re: [Qemu-devel] [PATCH 2/3] qga: add guest-get-time command

[Lei Li <lilei@linux.vnet.ibm.com>]

On 01/09/2013 09:33 PM, Luiz Capitulino wrote:
> On Sun,  6 Jan 2013 18:06:59 +0800
> Lei Li <lilei@linux.vnet.ibm.com> wrote:
>
>> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
>> ---
>>   qga/commands-posix.c |   12 ++++++++++++
>>   qga/qapi-schema.json |   17 +++++++++++++++++
>>   2 files changed, 29 insertions(+), 0 deletions(-)
>>
>> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
>> index 26b0fa0..190199d 100644
>> --- a/qga/commands-posix.c
>> +++ b/qga/commands-posix.c
>> @@ -109,6 +109,18 @@ static HostTimeInfo *get_host_time(void)
>>       return host_time;
>>   }
>>   
>> +struct HostTimeInfo *qmp_guest_get_time(Error **errp)
>> +{
>> +    HostTimeInfo *host_time = get_host_time();
> The command is called guest_get_time() and runs in the guest, but it returns
> HostTimeInfo. Is this correct?

Okay, looks like this 'HostTimeInfo' brings a lots of confusion. I will change it
to 'TimeInfo' as I replied to another patch.

>> +
>> +    if (!host_time) {
>> +        error_set(errp, QERR_QGA_COMMAND_FAILED, "Failed to get host time");
>> +        return NULL;
>> +    }
>> +
>> +    return host_time;
>> +}
>> +
>>   typedef struct GuestFileHandle {
>>       uint64_t id;
>>       FILE *fh;
>> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
>> index 7793aff..4a8b93c 100644
>> --- a/qga/qapi-schema.json
>> +++ b/qga/qapi-schema.json
>> @@ -100,6 +100,23 @@
>>                'utc-offset': 'int' } }
>>   
>>   ##
>> +# @guest-get-time:
>> +#
>> +# Get the information about host time in UTC and the
>> +# UTC offset.
>> +#
>> +# This command tries to get the host time which is
>> +# presumably correct, since need to be able to resynchronize
>> +# clock to host in guest.
>> +#
>> +# Returns: @HostTimeInfo on success.
>> +#
>> +# Since 1.4
>> +##
>> +{ 'command': 'guest-get-time',
>> +  'returns': 'HostTimeInfo' }
>> +
>> +##
>>   # @GuestAgentCommandInfo:
>>   #
>>   # Information about guest agent commands.


-- 
Lei