Missing DT code in FSMC driver?

Missing DT code in FSMC driver?

[Linus Walleij]

Hi Vipin,

I just found this in the SPEAr devicetree for FSMC:

(...)
	reg-names = "fsmc_regs", "nand_data", "nand_addr", "nand_cmd";
	st,mode = <2>;
	status = "okay";
(...)

st,mode?

I guess this is for setting e.g. DMA mode, but there is no code for parsing
this in the current FSMC driver, so it seems the device tree is out of sync
with the code in the driver.

Also there seems to be no bindings for setting the timings from device
tree.

Do you want me to look into this or do you have code waiting to be
submitted? (I would guess you have some code since you have added
that property to the device tree...)
Documentation/devicetree/bindings/mtd/fsmc-nand.txt need to be
fixed too I guess.

Yours,
Linus Walleij

Re: Missing DT code in FSMC driver?

[Vipin Kumar]

On 1/6/2013 2:43 AM, Linus Walleij wrote:
> Hi Vipin,
>

Hi Linus,

Happy new year

> I just found this in the SPEAr devicetree for FSMC:
>
> (...)
> 	reg-names = "fsmc_regs", "nand_data", "nand_addr", "nand_cmd";
> 	st,mode =<2>;
> 	status = "okay";
> (...)
>
> st,mode?
>
> I guess this is for setting e.g. DMA mode, but there is no code for parsing
> this in the current FSMC driver, so it seems the device tree is out of sync
> with the code in the driver.
>

Yes, I notice it now.
I would send few patches. I have been sitting on them for quite long now :(

> Also there seems to be no bindings for setting the timings from device
> tree.
>

Would correct these as well

> Do you want me to look into this or do you have code waiting to be
> submitted? (I would guess you have some code since you have added
> that property to the device tree...)
> Documentation/devicetree/bindings/mtd/fsmc-nand.txt need to be
> fixed too I guess.
>

Let me send out the patch and then we can re-discuss if there is more to 
be done

Regards
Vipin

> Yours,
> Linus Walleij
> .
>