All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] qla4xxx: Updates for scsi "misc" branch
@ 2012-12-29  7:24 vikas.chaudhary
  2012-12-29  7:24 ` [PATCH 1/3] qla4xxx: Pass correct function param to qla4_8xxx_rd_direct vikas.chaudhary
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: vikas.chaudhary @ 2012-12-29  7:24 UTC (permalink / raw)
  To: jbottomley, michaelc
  Cc: linux-scsi, vikas.chaudhary, lalit.chandivade, ravi.anand

From: Vikas Chaudhary <vikas.chaudhary@qlogic.com>

James,

Please apply the following patches to the scsi tree at your earliest
convenience.

Thanks,
Vikas.

Nilesh Javali (1):
      qla4xxx: Correct the validation to check in get_sys_info mailbox

Vikas Chaudhary (2):
      qla4xxx: Pass correct function param to qla4_8xxx_rd_direct
      qla4xxx: Update driver version to 5.03.00-k3

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/3] qla4xxx: Pass correct function param to qla4_8xxx_rd_direct
  2012-12-29  7:24 [PATCH 0/3] qla4xxx: Updates for scsi "misc" branch vikas.chaudhary
@ 2012-12-29  7:24 ` vikas.chaudhary
  2012-12-29  7:24 ` [PATCH 2/3] qla4xxx: Correct the validation to check in get_sys_info mailbox vikas.chaudhary
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: vikas.chaudhary @ 2012-12-29  7:24 UTC (permalink / raw)
  To: jbottomley, michaelc
  Cc: linux-scsi, vikas.chaudhary, lalit.chandivade, ravi.anand

From: Vikas Chaudhary <vikas.chaudhary@qlogic.com>

Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
---
 drivers/scsi/qla4xxx/ql4_os.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index 6096866..640d257 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -5271,7 +5271,7 @@ static int __devinit qla4xxx_probe_adapter(struct pci_dev *pdev,
 		if (is_qla80XX(ha)) {
 			ha->isp_ops->idc_lock(ha);
 			dev_state = qla4_8xxx_rd_direct(ha,
-							QLA82XX_CRB_DEV_STATE);
+							QLA8XXX_CRB_DEV_STATE);
 			ha->isp_ops->idc_unlock(ha);
 			if (dev_state == QLA8XXX_DEV_FAILED) {
 				ql4_printk(KERN_WARNING, ha, "%s: don't retry "
-- 
1.7.8.GIT


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/3] qla4xxx: Correct the validation to check in get_sys_info mailbox
  2012-12-29  7:24 [PATCH 0/3] qla4xxx: Updates for scsi "misc" branch vikas.chaudhary
  2012-12-29  7:24 ` [PATCH 1/3] qla4xxx: Pass correct function param to qla4_8xxx_rd_direct vikas.chaudhary
@ 2012-12-29  7:24 ` vikas.chaudhary
  2012-12-29  7:24 ` [PATCH 3/3] qla4xxx: Update driver version to 5.03.00-k3 vikas.chaudhary
  2013-01-08  6:12 ` [PATCH 0/3] qla4xxx: Updates for scsi "misc" branch Mike Christie
  3 siblings, 0 replies; 5+ messages in thread
From: vikas.chaudhary @ 2012-12-29  7:24 UTC (permalink / raw)
  To: jbottomley, michaelc
  Cc: linux-scsi, vikas.chaudhary, lalit.chandivade, ravi.anand,
	Nilesh Javali

From: Nilesh Javali <nilesh.javali@qlogic.com>

Check mbox_sts[3] instead of mbox_sts[4] for ISP83xx to validate size
of data returned

Signed-off-by: Nilesh Javali <nilesh.javali@qlogic.com>
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
---
 drivers/scsi/qla4xxx/ql4_nx.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c
index 491668d..b3d6dab 100644
--- a/drivers/scsi/qla4xxx/ql4_nx.c
+++ b/drivers/scsi/qla4xxx/ql4_nx.c
@@ -3427,11 +3427,11 @@ int qla4_8xxx_get_sys_info(struct scsi_qla_host *ha)
 	}
 
 	/* Make sure we receive the minimum required data to cache internally */
-	if (mbox_sts[4] < offsetof(struct mbx_sys_info, reserved)) {
+	if ((is_qla8032(ha) ? mbox_sts[3] : mbox_sts[4]) <
+	    offsetof(struct mbx_sys_info, reserved)) {
 		DEBUG2(printk("scsi%ld: %s: GET_SYS_INFO data receive"
 		    " error (%x)\n", ha->host_no, __func__, mbox_sts[4]));
 		goto exit_validate_mac82;
-
 	}
 
 	/* Save M.A.C. address & serial_number */
-- 
1.7.8.GIT


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 3/3] qla4xxx: Update driver version to 5.03.00-k3
  2012-12-29  7:24 [PATCH 0/3] qla4xxx: Updates for scsi "misc" branch vikas.chaudhary
  2012-12-29  7:24 ` [PATCH 1/3] qla4xxx: Pass correct function param to qla4_8xxx_rd_direct vikas.chaudhary
  2012-12-29  7:24 ` [PATCH 2/3] qla4xxx: Correct the validation to check in get_sys_info mailbox vikas.chaudhary
@ 2012-12-29  7:24 ` vikas.chaudhary
  2013-01-08  6:12 ` [PATCH 0/3] qla4xxx: Updates for scsi "misc" branch Mike Christie
  3 siblings, 0 replies; 5+ messages in thread
From: vikas.chaudhary @ 2012-12-29  7:24 UTC (permalink / raw)
  To: jbottomley, michaelc
  Cc: linux-scsi, vikas.chaudhary, lalit.chandivade, ravi.anand

From: Vikas Chaudhary <vikas.chaudhary@qlogic.com>

Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
---
 drivers/scsi/qla4xxx/ql4_version.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/qla4xxx/ql4_version.h b/drivers/scsi/qla4xxx/ql4_version.h
index 4a20b88..765bb77 100644
--- a/drivers/scsi/qla4xxx/ql4_version.h
+++ b/drivers/scsi/qla4xxx/ql4_version.h
@@ -5,4 +5,4 @@
  * See LICENSE.qla4xxx for copyright and licensing details.
  */
 
-#define QLA4XXX_DRIVER_VERSION	"5.03.00-k2"
+#define QLA4XXX_DRIVER_VERSION	"5.03.00-k3"
-- 
1.7.8.GIT


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/3] qla4xxx: Updates for scsi "misc" branch
  2012-12-29  7:24 [PATCH 0/3] qla4xxx: Updates for scsi "misc" branch vikas.chaudhary
                   ` (2 preceding siblings ...)
  2012-12-29  7:24 ` [PATCH 3/3] qla4xxx: Update driver version to 5.03.00-k3 vikas.chaudhary
@ 2013-01-08  6:12 ` Mike Christie
  3 siblings, 0 replies; 5+ messages in thread
From: Mike Christie @ 2013-01-08  6:12 UTC (permalink / raw)
  To: vikas.chaudhary; +Cc: jbottomley, linux-scsi, lalit.chandivade, ravi.anand

On 12/29/2012 01:24 AM, vikas.chaudhary@qlogic.com wrote:
> From: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
> 
> James,
> 
> Please apply the following patches to the scsi tree at your earliest
> convenience.
> 
> Thanks,
> Vikas.
> 
> Nilesh Javali (1):
>       qla4xxx: Correct the validation to check in get_sys_info mailbox
> 
> Vikas Chaudhary (2):
>       qla4xxx: Pass correct function param to qla4_8xxx_rd_direct
>       qla4xxx: Update driver version to 5.03.00-k3
> 

Look ok to me.

Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-01-08  6:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-29  7:24 [PATCH 0/3] qla4xxx: Updates for scsi "misc" branch vikas.chaudhary
2012-12-29  7:24 ` [PATCH 1/3] qla4xxx: Pass correct function param to qla4_8xxx_rd_direct vikas.chaudhary
2012-12-29  7:24 ` [PATCH 2/3] qla4xxx: Correct the validation to check in get_sys_info mailbox vikas.chaudhary
2012-12-29  7:24 ` [PATCH 3/3] qla4xxx: Update driver version to 5.03.00-k3 vikas.chaudhary
2013-01-08  6:12 ` [PATCH 0/3] qla4xxx: Updates for scsi "misc" branch Mike Christie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.