From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Alessandro Rubini <rubini@gnudd.com>,
federico.vaga@gmail.com, mchehab@infradead.org, pawel@osciak.com,
hans.verkuil@cisco.com, giancarlo.asnaghi@st.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
s.nawrocki@samsung.com
Subject: Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator
Date: Tue, 08 Jan 2013 07:50:41 +0100 [thread overview]
Message-ID: <50EBC1C1.3060208@samsung.com> (raw)
In-Reply-To: <20130107181500.24c56803@redhat.com>
On 1/7/2013 9:15 PM, Mauro Carvalho Chehab wrote:
> Em Mon, 7 Jan 2013 12:40:50 -0700
> Jonathan Corbet <corbet@lwn.net> escreveu:
>
> > On Mon, 7 Jan 2013 00:09:47 +0100
> > Alessandro Rubini <rubini@gnudd.com> wrote:
> >
> > > I don't expect you'll see serious performance differences on the PC. I
> > > think ARM users will have better benefits, due to the different cache
> > > architecture. You told me Jon measured meaningful figures on a Marvel
> > > CPU.
> >
> > It made the difference between 10 frames per second with the CPU running
> > flat out and 30fps mostly idle. I think that probably counts as
> > meaningful, yeah...:)
>
> Couldn't this performance difference be due to the usage of GFP_DMA inside
> the VB2 code, like Federico's new patch series is proposing?
>
> If not, why are there a so large performance penalty?
Nope, this was caused rather by a very poor CPU access to non-cached (aka
'coherent') memory and the way the video data has been accessed/read
with CPU.
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
next prev parent reply other threads:[~2013-01-08 6:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 10:58 [PATCH v3 1/4] v4l: vb2: add prepare/finish callbacks to allocators Federico Vaga
2012-09-24 10:58 ` [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator Federico Vaga
2012-09-24 12:44 ` Marek Szyprowski
2012-12-04 16:04 ` Mauro Carvalho Chehab
2012-12-05 12:50 ` Federico Vaga
2012-12-05 14:25 ` Mauro Carvalho Chehab
2012-12-11 13:54 ` Federico Vaga
2012-12-18 14:41 ` Marek Szyprowski
2012-12-20 15:37 ` Federico Vaga
2013-01-01 12:52 ` Mauro Carvalho Chehab
2013-01-03 16:13 ` Federico Vaga
2013-01-04 13:30 ` Federico Vaga
2013-01-06 17:04 ` Federico Vaga
2013-01-06 23:09 ` Alessandro Rubini
2013-01-07 19:40 ` Jonathan Corbet
2013-01-07 20:15 ` Mauro Carvalho Chehab
2013-01-08 6:50 ` Marek Szyprowski [this message]
2013-01-08 14:31 ` Jonathan Corbet
2013-01-09 7:48 ` Michael Olbrich
2012-09-24 10:58 ` [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework Federico Vaga
2012-12-04 16:15 ` Mauro Carvalho Chehab
2012-12-05 1:12 ` Federico Vaga
2012-12-05 11:34 ` Mauro Carvalho Chehab
2012-12-05 12:24 ` Federico Vaga
2012-12-05 13:10 ` Mauro Carvalho Chehab
2012-12-05 13:27 ` Federico Vaga
2012-12-05 13:37 ` Mauro Carvalho Chehab
2012-12-05 13:45 ` Federico Vaga
2012-12-06 18:59 ` Federico Vaga
2012-09-24 10:58 ` [PATCH v3 4/4] adv7180: remove {query/g_/s_}ctrl Federico Vaga
2012-09-24 12:46 ` [PATCH v3 1/4] v4l: vb2: add prepare/finish callbacks to allocators Marek Szyprowski
2012-09-25 15:04 ` Federico Vaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EBC1C1.3060208@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=corbet@lwn.net \
--cc=federico.vaga@gmail.com \
--cc=giancarlo.asnaghi@st.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mchehab@redhat.com \
--cc=pawel@osciak.com \
--cc=rubini@gnudd.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.