All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] meta-fsl-ppc master: inherit image_types_uboot
@ 2013-01-07 14:45 Bob Cochran
  2013-01-07 20:17 ` McClintock Matthew-B29882
  0 siblings, 1 reply; 6+ messages in thread
From: Bob Cochran @ 2013-01-07 14:45 UTC (permalink / raw)
  To: meta-freescale@yoctoproject.org

Without this patch, fsl-image-minimal-<machine>.ext2.gz.u-boot links to 
a non existent file (u-boot rootfs isn't actually built).

As commented by Matthew McClintock on 1/2/13, this had been handled 
previously using a setup script.

Signed-off-by: Robert Cochran <yocto@mindchasers.com>
---

diff --git a/images/fsl-image-minimal.bb b/images/fsl-image-minimal.bb
index 1732585..64fa096 100644
--- a/images/fsl-image-minimal.bb
+++ b/images/fsl-image-minimal.bb
@@ -6,7 +6,7 @@ IMAGE_LINGUAS = " "

  LICENSE = "MIT"

-inherit core-image
+inherit core-image image_types_uboot

  IMAGE_ROOTFS_SIZE = "8192"

--
1.7.9.5


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] meta-fsl-ppc master: inherit image_types_uboot
  2013-01-07 14:45 [PATCH] meta-fsl-ppc master: inherit image_types_uboot Bob Cochran
@ 2013-01-07 20:17 ` McClintock Matthew-B29882
  2013-01-08 13:36   ` Bob Cochran
  0 siblings, 1 reply; 6+ messages in thread
From: McClintock Matthew-B29882 @ 2013-01-07 20:17 UTC (permalink / raw)
  To: Bob Cochran; +Cc: meta-freescale@yoctoproject.org

On Mon, Jan 7, 2013 at 8:45 AM, Bob Cochran <yocto@mindchasers.com> wrote:
> Without this patch, fsl-image-minimal-<machine>.ext2.gz.u-boot links to a
> non existent file (u-boot rootfs isn't actually built).
>
> As commented by Matthew McClintock on 1/2/13, this had been handled
> previously using a setup script.

You can remove this bit, or place it below the --- line

> Signed-off-by: Robert Cochran <yocto@mindchasers.com>
> ---
>
> diff --git a/images/fsl-image-minimal.bb b/images/fsl-image-minimal.bb
> index 1732585..64fa096 100644
> --- a/images/fsl-image-minimal.bb
> +++ b/images/fsl-image-minimal.bb

$ git ls-tree --name-only -r HEAD | grep fsl-image
images/fsl-image-lsb-sdk.bb
images/fsl-image-minimal.bb

I think the other image needs this too.

-M

> @@ -6,7 +6,7 @@ IMAGE_LINGUAS = " "
>
>  LICENSE = "MIT"
>
> -inherit core-image
> +inherit core-image image_types_uboot
>
>  IMAGE_ROOTFS_SIZE = "8192"
>
> --
> 1.7.9.5
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] meta-fsl-ppc master: inherit image_types_uboot
  2013-01-07 20:17 ` McClintock Matthew-B29882
@ 2013-01-08 13:36   ` Bob Cochran
  2013-01-08 17:28     ` McClintock Matthew-B29882
  2013-01-09  3:47     ` Luo Zhenhua-B19537
  0 siblings, 2 replies; 6+ messages in thread
From: Bob Cochran @ 2013-01-08 13:36 UTC (permalink / raw)
  To: McClintock Matthew-B29882; +Cc: meta-freescale@yoctoproject.org

On 01/07/2013 03:17 PM, McClintock Matthew-B29882 wrote:
> On Mon, Jan 7, 2013 at 8:45 AM, Bob Cochran <yocto@mindchasers.com> wrote:
>> Without this patch, fsl-image-minimal-<machine>.ext2.gz.u-boot links to a
>> non existent file (u-boot rootfs isn't actually built).
>>
>> As commented by Matthew McClintock on 1/2/13, this had been handled
>> previously using a setup script.
>
> You can remove this bit, or place it below the --- line

Matthew,

I'll resubmit this patch & the one Otavio commented on 
(image_types_uboot).  I also want to send up a patch to do a rename: 
recipes-append/libxml/libxml2_2.8.0.bbappend -> 
recipes-append/libxml/libxml2_2.9.0.bbappend

Should I just send up a new patch set today with the three patches 
included, or do you want me to address each individually?

Thanks,

Bob



>
>> Signed-off-by: Robert Cochran <yocto@mindchasers.com>
>> ---
>>
>> diff --git a/images/fsl-image-minimal.bb b/images/fsl-image-minimal.bb
>> index 1732585..64fa096 100644
>> --- a/images/fsl-image-minimal.bb
>> +++ b/images/fsl-image-minimal.bb
>
> $ git ls-tree --name-only -r HEAD | grep fsl-image
> images/fsl-image-lsb-sdk.bb
> images/fsl-image-minimal.bb
>
> I think the other image needs this too.
>
> -M
>
>> @@ -6,7 +6,7 @@ IMAGE_LINGUAS = " "
>>
>>   LICENSE = "MIT"
>>
>> -inherit core-image
>> +inherit core-image image_types_uboot
>>
>>   IMAGE_ROOTFS_SIZE = "8192"
>>
>> --
>> 1.7.9.5
>> _______________________________________________
>> meta-freescale mailing list
>> meta-freescale@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-freescale
>



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] meta-fsl-ppc master: inherit image_types_uboot
  2013-01-08 13:36   ` Bob Cochran
@ 2013-01-08 17:28     ` McClintock Matthew-B29882
  2013-01-09  3:47     ` Luo Zhenhua-B19537
  1 sibling, 0 replies; 6+ messages in thread
From: McClintock Matthew-B29882 @ 2013-01-08 17:28 UTC (permalink / raw)
  To: Bob Cochran; +Cc: McClintock Matthew-B29882, meta-freescale@yoctoproject.org

On Tue, Jan 8, 2013 at 7:36 AM, Bob Cochran <yocto@mindchasers.com> wrote:
> On 01/07/2013 03:17 PM, McClintock Matthew-B29882 wrote:
>>
>> On Mon, Jan 7, 2013 at 8:45 AM, Bob Cochran <yocto@mindchasers.com> wrote:
>>>
>>> Without this patch, fsl-image-minimal-<machine>.ext2.gz.u-boot links to a
>>> non existent file (u-boot rootfs isn't actually built).
>>>
>>> As commented by Matthew McClintock on 1/2/13, this had been handled
>>> previously using a setup script.
>>
>>
>> You can remove this bit, or place it below the --- line
>
>
> Matthew,
>
> I'll resubmit this patch & the one Otavio commented on (image_types_uboot).
> I also want to send up a patch to do a rename:
> recipes-append/libxml/libxml2_2.8.0.bbappend ->
> recipes-append/libxml/libxml2_2.9.0.bbappend
>
> Should I just send up a new patch set today with the three patches included,
> or do you want me to address each individually?

libxml fix is already in master-next
(http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-ppc/commit/?h=master-next&id=3f4e3e1d8f8ed719fc59be3cf0aadefb19f934bb)

Just base your patch off master-next. Feel free to bring up / fix any
issues you find on that branch.

-M

>
> Thanks,
>
> Bob
>
>
>
>
>>
>>> Signed-off-by: Robert Cochran <yocto@mindchasers.com>
>>> ---
>>>
>>> diff --git a/images/fsl-image-minimal.bb b/images/fsl-image-minimal.bb
>>> index 1732585..64fa096 100644
>>> --- a/images/fsl-image-minimal.bb
>>> +++ b/images/fsl-image-minimal.bb
>>
>>
>> $ git ls-tree --name-only -r HEAD | grep fsl-image
>> images/fsl-image-lsb-sdk.bb
>> images/fsl-image-minimal.bb
>>
>> I think the other image needs this too.
>>
>> -M
>>
>>> @@ -6,7 +6,7 @@ IMAGE_LINGUAS = " "
>>>
>>>   LICENSE = "MIT"
>>>
>>> -inherit core-image
>>> +inherit core-image image_types_uboot
>>>
>>>   IMAGE_ROOTFS_SIZE = "8192"
>>>
>>> --
>>> 1.7.9.5
>>> _______________________________________________
>>> meta-freescale mailing list
>>> meta-freescale@yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/meta-freescale
>>
>>
>
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] meta-fsl-ppc master: inherit image_types_uboot
  2013-01-08 13:36   ` Bob Cochran
  2013-01-08 17:28     ` McClintock Matthew-B29882
@ 2013-01-09  3:47     ` Luo Zhenhua-B19537
  2013-01-09  4:10       ` McClintock Matthew-B29882
  1 sibling, 1 reply; 6+ messages in thread
From: Luo Zhenhua-B19537 @ 2013-01-09  3:47 UTC (permalink / raw)
  To: Bob Cochran, McClintock Matthew-B29882; +Cc: meta-freescale@yoctoproject.org

Bob, 

"libxml2_<PV>.bbappend is not needed anymore, the change has been merged into poky. 

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=b7a7e6eebac711642944295ad62c996d6a75891c


Best Regards,

Zhenhua


> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> bounces@yoctoproject.org] On Behalf Of Bob Cochran
> Sent: Tuesday, January 08, 2013 9:37 PM
> To: McClintock Matthew-B29882
> Cc: meta-freescale@yoctoproject.org
> Subject: Re: [meta-freescale] [PATCH] meta-fsl-ppc master: inherit
> image_types_uboot
> 
> On 01/07/2013 03:17 PM, McClintock Matthew-B29882 wrote:
> > On Mon, Jan 7, 2013 at 8:45 AM, Bob Cochran <yocto@mindchasers.com>
> wrote:
> >> Without this patch, fsl-image-minimal-<machine>.ext2.gz.u-boot links
> >> to a non existent file (u-boot rootfs isn't actually built).
> >>
> >> As commented by Matthew McClintock on 1/2/13, this had been handled
> >> previously using a setup script.
> >
> > You can remove this bit, or place it below the --- line
> 
> Matthew,
> 
> I'll resubmit this patch & the one Otavio commented on
> (image_types_uboot).  I also want to send up a patch to do a rename:
> recipes-append/libxml/libxml2_2.8.0.bbappend -> recipes-
> append/libxml/libxml2_2.9.0.bbappend
> 
> Should I just send up a new patch set today with the three patches
> included, or do you want me to address each individually?
> 
> Thanks,
> 
> Bob
> 
> 
> 
> >
> >> Signed-off-by: Robert Cochran <yocto@mindchasers.com>
> >> ---
> >>
> >> diff --git a/images/fsl-image-minimal.bb
> >> b/images/fsl-image-minimal.bb index 1732585..64fa096 100644
> >> --- a/images/fsl-image-minimal.bb
> >> +++ b/images/fsl-image-minimal.bb
> >
> > $ git ls-tree --name-only -r HEAD | grep fsl-image
> > images/fsl-image-lsb-sdk.bb images/fsl-image-minimal.bb
> >
> > I think the other image needs this too.
> >
> > -M
> >
> >> @@ -6,7 +6,7 @@ IMAGE_LINGUAS = " "
> >>
> >>   LICENSE = "MIT"
> >>
> >> -inherit core-image
> >> +inherit core-image image_types_uboot
> >>
> >>   IMAGE_ROOTFS_SIZE = "8192"
> >>
> >> --
> >> 1.7.9.5
> >> _______________________________________________
> >> meta-freescale mailing list
> >> meta-freescale@yoctoproject.org
> >> https://lists.yoctoproject.org/listinfo/meta-freescale
> >
> 
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] meta-fsl-ppc master: inherit image_types_uboot
  2013-01-09  3:47     ` Luo Zhenhua-B19537
@ 2013-01-09  4:10       ` McClintock Matthew-B29882
  0 siblings, 0 replies; 6+ messages in thread
From: McClintock Matthew-B29882 @ 2013-01-09  4:10 UTC (permalink / raw)
  To: Luo Zhenhua-B19537
  Cc: McClintock Matthew-B29882, meta-freescale@yoctoproject.org

On Tue, Jan 8, 2013 at 9:47 PM, Luo Zhenhua-B19537 <B19537@freescale.com> wrote:
> Bob,
>
> "libxml2_<PV>.bbappend is not needed anymore, the change has been merged into poky.
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=b7a7e6eebac711642944295ad62c996d6a75891c

Then we need a patch to drop the bbappends entirely.

-M

>
>
> Best Regards,
>
> Zhenhua
>
>
>> -----Original Message-----
>> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
>> bounces@yoctoproject.org] On Behalf Of Bob Cochran
>> Sent: Tuesday, January 08, 2013 9:37 PM
>> To: McClintock Matthew-B29882
>> Cc: meta-freescale@yoctoproject.org
>> Subject: Re: [meta-freescale] [PATCH] meta-fsl-ppc master: inherit
>> image_types_uboot
>>
>> On 01/07/2013 03:17 PM, McClintock Matthew-B29882 wrote:
>> > On Mon, Jan 7, 2013 at 8:45 AM, Bob Cochran <yocto@mindchasers.com>
>> wrote:
>> >> Without this patch, fsl-image-minimal-<machine>.ext2.gz.u-boot links
>> >> to a non existent file (u-boot rootfs isn't actually built).
>> >>
>> >> As commented by Matthew McClintock on 1/2/13, this had been handled
>> >> previously using a setup script.
>> >
>> > You can remove this bit, or place it below the --- line
>>
>> Matthew,
>>
>> I'll resubmit this patch & the one Otavio commented on
>> (image_types_uboot).  I also want to send up a patch to do a rename:
>> recipes-append/libxml/libxml2_2.8.0.bbappend -> recipes-
>> append/libxml/libxml2_2.9.0.bbappend
>>
>> Should I just send up a new patch set today with the three patches
>> included, or do you want me to address each individually?
>>
>> Thanks,
>>
>> Bob
>>
>>
>>
>> >
>> >> Signed-off-by: Robert Cochran <yocto@mindchasers.com>
>> >> ---
>> >>
>> >> diff --git a/images/fsl-image-minimal.bb
>> >> b/images/fsl-image-minimal.bb index 1732585..64fa096 100644
>> >> --- a/images/fsl-image-minimal.bb
>> >> +++ b/images/fsl-image-minimal.bb
>> >
>> > $ git ls-tree --name-only -r HEAD | grep fsl-image
>> > images/fsl-image-lsb-sdk.bb images/fsl-image-minimal.bb
>> >
>> > I think the other image needs this too.
>> >
>> > -M
>> >
>> >> @@ -6,7 +6,7 @@ IMAGE_LINGUAS = " "
>> >>
>> >>   LICENSE = "MIT"
>> >>
>> >> -inherit core-image
>> >> +inherit core-image image_types_uboot
>> >>
>> >>   IMAGE_ROOTFS_SIZE = "8192"
>> >>
>> >> --
>> >> 1.7.9.5
>> >> _______________________________________________
>> >> meta-freescale mailing list
>> >> meta-freescale@yoctoproject.org
>> >> https://lists.yoctoproject.org/listinfo/meta-freescale
>> >
>>
>> _______________________________________________
>> meta-freescale mailing list
>> meta-freescale@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-freescale
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-01-09  4:10 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-07 14:45 [PATCH] meta-fsl-ppc master: inherit image_types_uboot Bob Cochran
2013-01-07 20:17 ` McClintock Matthew-B29882
2013-01-08 13:36   ` Bob Cochran
2013-01-08 17:28     ` McClintock Matthew-B29882
2013-01-09  3:47     ` Luo Zhenhua-B19537
2013-01-09  4:10       ` McClintock Matthew-B29882

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.