Fix fsl-mm-flv-codeclib package creation

Fix fsl-mm-flv-codeclib package creation

[Javier Viguera]

Hi all,

Trying to build 'fsl-mm-flv-codeclib' package fails because the pre-built libraries inside the "source" package do not follow the 'lib*so.*' naming rule that the recipe expects. This patch fixes the problem and allows to build/install the package.

The patch is done for 'danny' but probably it should be also cherry-picked to master branch.

Please consider pushing it to the repo.

-- 
Javier Viguera
Software Engineer

[meta-fsl-arm][for-danny][PATCH] fsl-mm-flv-codeclib: fix package creation

[Javier Viguera]

The prebuilt libraries in fsl-mm-flv-codeclib package do not follow
the lib*.so.* naming rule, so the 'do_install' function fails to copy
some of the library files and later failing to create the package
(tested with DEB and IPK formats)

Signed-off-by: Javier Viguera <javier.viguera@digi.com>
---
 recipes-multimedia/fsl-mm-core/fsl-mm-flv-codeclib_2.0.3.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-multimedia/fsl-mm-core/fsl-mm-flv-codeclib_2.0.3.bb b/recipes-multimedia/fsl-mm-core/fsl-mm-flv-codeclib_2.0.3.bb
index 7509589..b196a3a 100644
--- a/recipes-multimedia/fsl-mm-core/fsl-mm-flv-codeclib_2.0.3.bb
+++ b/recipes-multimedia/fsl-mm-core/fsl-mm-flv-codeclib_2.0.3.bb
@@ -19,12 +19,12 @@ do_install () {
     install -d ${D}${libdir}
     install -d ${D}${libdir}/pkgconfig
     install -d ${D}${includedir}/mm_ghdr
-    install -m 0755 ${S}/release/lib/*.so* ${D}${libdir}
+    cp -r ${S}/release/lib/* ${D}${libdir}
     install -m 0644 ${S}/ghdr/common/*.h ${D}${includedir}/mm_ghdr
     install -m 0644 ${S}/pkgconfig/*.pc ${D}${libdir}/pkgconfig
 }
 
-FILES_${PN} += "${libdir}/*.so* ${libdir}/pkgconfig/*.pc"
+FILES_${PN} += "${libdir}/lib* ${libdir}/pkgconfig/*.pc"
 INSANE_SKIP_${PN} = "ldflags"
 
 FILES_${PN}-dev += "${includedir}/mm_ghdr/*.h"

Re: [meta-fsl-arm][for-danny][PATCH] fsl-mm-flv-codeclib: fix package creation

[Daiane Angolini]

On Mon, Jan 7, 2013 at 2:39 PM, Javier Viguera <javier.viguera@digi.com> wrote:
> The prebuilt libraries in fsl-mm-flv-codeclib package do not follow
> the lib*.so.* naming rule, so the 'do_install' function fails to copy
> some of the library files and later failing to create the package
> (tested with DEB and IPK formats)
>
> Signed-off-by: Javier Viguera <javier.viguera@digi.com>
> ---
>  recipes-multimedia/fsl-mm-core/fsl-mm-flv-codeclib_2.0.3.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-multimedia/fsl-mm-core/fsl-mm-flv-codeclib_2.0.3.bb b/recipes-multimedia/fsl-mm-core/fsl-mm-flv-codeclib_2.0.3.bb
> index 7509589..b196a3a 100644
> --- a/recipes-multimedia/fsl-mm-core/fsl-mm-flv-codeclib_2.0.3.bb
> +++ b/recipes-multimedia/fsl-mm-core/fsl-mm-flv-codeclib_2.0.3.bb
> @@ -19,12 +19,12 @@ do_install () {
>      install -d ${D}${libdir}
>      install -d ${D}${libdir}/pkgconfig
>      install -d ${D}${includedir}/mm_ghdr
> -    install -m 0755 ${S}/release/lib/*.so* ${D}${libdir}
> +    cp -r ${S}/release/lib/* ${D}${libdir}
>      install -m 0644 ${S}/ghdr/common/*.h ${D}${includedir}/mm_ghdr
>      install -m 0644 ${S}/pkgconfig/*.pc ${D}${libdir}/pkgconfig
>  }
>
> -FILES_${PN} += "${libdir}/*.so* ${libdir}/pkgconfig/*.pc"
> +FILES_${PN} += "${libdir}/lib* ${libdir}/pkgconfig/*.pc"
>  INSANE_SKIP_${PN} = "ldflags"
>
>  FILES_${PN}-dev += "${includedir}/mm_ghdr/*.h"

Could you, please, apply it to master in order to make sure it's
applicable? I will test it on master.

How do you test this package?


Daiane

Re: [meta-fsl-arm][for-danny][PATCH] fsl-mm-flv-codeclib: fix package creation

[Javier Viguera]

On 01/08/2013 11:25 AM, Daiane Angolini wrote:
> Could you, please, apply it to master in order to make sure it's
> applicable? I will test it on master.
> 
> How do you test this package?

Hi Daiane,

Yes the patch applies to master as well without problems.

About the testing. I have not tested it at run time yet. We plan to
use it with gst-fsl plugin. At build time the package is not compiled
because it's not a dependence of anything (for a 'imx53qsb' configured
project). But you can build the recipe with bitbake:

$ bitbake fsl-mm-flv-codeclib

You can see then, that the normal package is not created (it only
creates the -dev and -dbg packages):

$ ls -l tmp/work/armv7a-vfp-neon-poky-linux-gnueabi/fsl-mm-flv-codeclib-2.0.3-r1/deploy-ipks/armv7a-vfp-neon/
   792 Jan  8 12:15 fsl-mm-flv-codeclib-dbg_2.0.3-r1_armv7a-vfp-neon.ipk
 54578 Jan  8 12:15 fsl-mm-flv-codeclib-dev_2.0.3-r1_armv7a-vfp-neon.ipk

Looking at the log we see the reason. There are no files to be added
to the package and that's why it's not created.

$ less tmp/work/armv7a-vfp-neon-poky-linux-gnueabi/fsl-mm-flv-codeclib-2.0.3-r1/temp/log.do_package_write_ipk
...
NOTE: Not creating empty archive for fsl-mm-flv-codeclib-2.0.3-r1
...

And there are no files because the name of the library files in the
source package does not follow the naming rule the bitbake recipe
expects in the 'do_install' function and in the FILES variable.


-- 
Javier Viguera
Software Engineer
Digi International® Spain S.A.U.

Re: [meta-fsl-arm][for-danny][PATCH] fsl-mm-flv-codeclib: fix package creation

[Daiane Angolini]

On Tue, Jan 8, 2013 at 9:38 AM, Javier Viguera <javier.viguera@digi.com> wrote:
> On 01/08/2013 11:25 AM, Daiane Angolini wrote:
>> Could you, please, apply it to master in order to make sure it's
>> applicable? I will test it on master.
>>
>> How do you test this package?
>
> Hi Daiane,
>
> Yes the patch applies to master as well without problems.
>
> About the testing. I have not tested it at run time yet. We plan to
> use it with gst-fsl plugin. At build time the package is not compiled
> because it's not a dependence of anything (for a 'imx53qsb' configured
> project). But you can build the recipe with bitbake:
>
> $ bitbake fsl-mm-flv-codeclib
>
> You can see then, that the normal package is not created (it only
> creates the -dev and -dbg packages):
>
> $ ls -l tmp/work/armv7a-vfp-neon-poky-linux-gnueabi/fsl-mm-flv-codeclib-2.0.3-r1/deploy-ipks/armv7a-vfp-neon/
>    792 Jan  8 12:15 fsl-mm-flv-codeclib-dbg_2.0.3-r1_armv7a-vfp-neon.ipk
>  54578 Jan  8 12:15 fsl-mm-flv-codeclib-dev_2.0.3-r1_armv7a-vfp-neon.ipk
>
> Looking at the log we see the reason. There are no files to be added
> to the package and that's why it's not created.
>
> $ less tmp/work/armv7a-vfp-neon-poky-linux-gnueabi/fsl-mm-flv-codeclib-2.0.3-r1/temp/log.do_package_write_ipk
> ...
> NOTE: Not creating empty archive for fsl-mm-flv-codeclib-2.0.3-r1
> ...
>
> And there are no files because the name of the library files in the
> source package does not follow the naming rule the bitbake recipe
> expects in the 'do_install' function and in the FILES variable.
Great, thanks a lot!

I will include this package on some image, and I will test it runtime as well.

In case you test it runtime, please, let me know the results.


Daiane

Re: [meta-fsl-arm][for-danny][PATCH] fsl-mm-flv-codeclib: fix package creation

[Otavio Salvador]

On Tue, Jan 8, 2013 at 9:38 AM, Javier Viguera <javier.viguera@digi.com> wrote:
> On 01/08/2013 11:25 AM, Daiane Angolini wrote:
>> Could you, please, apply it to master in order to make sure it's
>> applicable? I will test it on master.
>>
>> How do you test this package?
>
> Hi Daiane,
>
> Yes the patch applies to master as well without problems.

Daiane has asked for it to be tested and applied in master as we don't
do fixes in danny without doing those in master before. So all
development and fixes need to be done in master *before*. After it has
been done in master fixes can be backported to danny.

> About the testing. I have not tested it at run time yet. We plan to
> use it with gst-fsl plugin. At build time the package is not compiled
> because it's not a dependence of anything (for a 'imx53qsb' configured
> project). But you can build the recipe with bitbake:

Right. Your patch is not fully complete so I prepared a new one which
should work fine for you but also fix other problems.

> $ bitbake fsl-mm-flv-codeclib
>
> You can see then, that the normal package is not created (it only
> creates the -dev and -dbg packages):
>
> $ ls -l tmp/work/armv7a-vfp-neon-poky-linux-gnueabi/fsl-mm-flv-codeclib-2.0.3-r1/deploy-ipks/armv7a-vfp-neon/
>    792 Jan  8 12:15 fsl-mm-flv-codeclib-dbg_2.0.3-r1_armv7a-vfp-neon.ipk
>  54578 Jan  8 12:15 fsl-mm-flv-codeclib-dev_2.0.3-r1_armv7a-vfp-neon.ipk
>
> Looking at the log we see the reason. There are no files to be added
> to the package and that's why it's not created.
>
> $ less tmp/work/armv7a-vfp-neon-poky-linux-gnueabi/fsl-mm-flv-codeclib-2.0.3-r1/temp/log.do_package_write_ipk
> ...
> NOTE: Not creating empty archive for fsl-mm-flv-codeclib-2.0.3-r1
> ...
>
> And there are no files because the name of the library files in the
> source package does not follow the naming rule the bitbake recipe
> expects in the 'do_install' function and in the FILES variable.

Your analisys is right but some other issues need fix as well:

   * The pkgconfig file provided is the same provided by
      fsl-mm-codeclib-dev so we cannot duplicate this file, instead we add a
      depends on fsl-mm-codeclib-dev to provide a single pkgconfig file;

    * Disable debug split as the binaries are stripped;

    * Set PACKAGE_ARCH to MACHINE_ARCH as this binaries are machine
      specific;

So I will send a patch to the mailing list and I will Cc you. Please
give this a try and confirm if it works for you.

Regards,

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [meta-fsl-arm][for-danny][PATCH] fsl-mm-flv-codeclib: fix package creation

[Javier Viguera]

Hi Otavio,

On 01/08/2013 02:06 PM, Otavio Salvador wrote:
> Your analisys is right but some other issues need fix as well:
>
>     * The pkgconfig file provided is the same provided by
>        fsl-mm-codeclib-dev so we cannot duplicate this file, instead we add a
>        depends on fsl-mm-codeclib-dev to provide a single pkgconfig file;
>
>      * Disable debug split as the binaries are stripped;
>
>      * Set PACKAGE_ARCH to MACHINE_ARCH as this binaries are machine
>        specific;
>
> So I will send a patch to the mailing list and I will Cc you. Please
> give this a try and confirm if it works for you.

I build-tested your patch with master branches (poky, meta-fsl-arm and 
meta-oe) and can confirm it fixes the problems. The package 
'fsl-mm-flv-codeclib_2.0.3-r2_imx53qsb.ipk' is created.

Still the other fsl-mm packages need some care. Both 'fsl-mm-codeclib' 
and 'fsl-mm-mp3enc-codeclib' try to install the 'fsl-mm-core.pc' 
pkgconfig file, so i guess the fsl-mm-mp3enc-codeclib needs the same 
trick than the 'fsl-mm-flv' package.

The fsl-mm-codeclib also seems to be missing files in the final package 
created. There is a warning in the build log:

WARNING: QA Issue: fsl-mm-codeclib: Files/directories were installed but 
not shipped
   /usr/lib/lib_ogg_parser_arm9_elinux.3.0.1.07.00
   /usr/lib/lib_ogg_parser_arm11_elinux.3.0.1.07.00

but i have verified that there are other missing files like 
'lib_deinterlace_arm11_elinux.so'. I guess all those missing files are 
due to the wrong names of the library files in the source package.

-- 
Regards,

Javier Viguera

Re: [meta-fsl-arm][for-danny][PATCH] fsl-mm-flv-codeclib: fix package creation

[Otavio Salvador]

On Tue, Jan 8, 2013 at 3:27 PM, Javier Viguera <javier.viguera@digi.com> wrote:
> Hi Otavio,
>
>
> On 01/08/2013 02:06 PM, Otavio Salvador wrote:
>>
>> Your analisys is right but some other issues need fix as well:
>>
>>     * The pkgconfig file provided is the same provided by
>>        fsl-mm-codeclib-dev so we cannot duplicate this file, instead we
>> add a
>>        depends on fsl-mm-codeclib-dev to provide a single pkgconfig file;
>>
>>      * Disable debug split as the binaries are stripped;
>>
>>      * Set PACKAGE_ARCH to MACHINE_ARCH as this binaries are machine
>>        specific;
>>
>> So I will send a patch to the mailing list and I will Cc you. Please
>> give this a try and confirm if it works for you.
>
>
> I build-tested your patch with master branches (poky, meta-fsl-arm and
> meta-oe) and can confirm it fixes the problems. The package
> 'fsl-mm-flv-codeclib_2.0.3-r2_imx53qsb.ipk' is created.

Good; thanks.

> Still the other fsl-mm packages need some care. Both 'fsl-mm-codeclib' and
> 'fsl-mm-mp3enc-codeclib' try to install the 'fsl-mm-core.pc' pkgconfig file,
> so i guess the fsl-mm-mp3enc-codeclib needs the same trick than the
> 'fsl-mm-flv' package.

Yes, I think so. I will take a look on this.

> The fsl-mm-codeclib also seems to be missing files in the final package
> created. There is a warning in the build log:
>
> WARNING: QA Issue: fsl-mm-codeclib: Files/directories were installed but not
> shipped
>   /usr/lib/lib_ogg_parser_arm9_elinux.3.0.1.07.00
>   /usr/lib/lib_ogg_parser_arm11_elinux.3.0.1.07.00
>
> but i have verified that there are other missing files like
> 'lib_deinterlace_arm11_elinux.so'. I guess all those missing files are due
> to the wrong names of the library files in the source package.

Yes; I will check those things.

I will apply the patch now than and work on the other fixes.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br