From: Tony Camuso <tcamuso-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: minyard-HInyCGIudOg@public.gmane.org
Cc: k-tanaka-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
openipmi-developer-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Corey Minyard <tcminyard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
myamazak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: [PATCH] ipmi: replace call to try_smi_init() with call to add_smi()
Date: Tue, 08 Jan 2013 15:12:31 -0500 [thread overview]
Message-ID: <50EC7DAF.8030606@redhat.com> (raw)
In-Reply-To: <50CB3662.5080100-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Upstream commit 9e368fa0 added function ipmi_pnp_probe(), which
calls try_smi_init() directly.
try_smi_init() allocates resources for IPMI driver. However
try_smi_init() can be called again, and the allocated resources
can be unexpectedly released when the same IPMI resource
information is found on both ACPI namespace and SMBIOS table.
ipmi_pnp_probe() should call add_smi() instead of try_smi_init()
For reference, see upstream commit ...
2407d77a1a013b88ee3b817f2b934e420e5376f5
Signed-off-by: Tony Camuso <tcamuso-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
drivers/char/ipmi/ipmi_si_intf.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index afb89be..20d13c6 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2223,7 +2223,7 @@ static int __devinit ipmi_pnp_probe(struct pnp_dev *dev,
info->dev = &dev->dev;
pnp_set_drvdata(dev, info);
- return try_smi_init(info);
+ return add_smi(info);
err_free:
kfree(info);
--
1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: Tony Camuso <tcamuso@redhat.com>
To: minyard@acm.org
Cc: Corey Minyard <tcminyard@gmail.com>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
openipmi-developer@lists.sourceforge.net,
grant.likely@secretlab.ca, k-tanaka@ce.jp.nec.com,
myamazak@redhat.com
Subject: [PATCH] ipmi: replace call to try_smi_init() with call to add_smi()
Date: Tue, 08 Jan 2013 15:12:31 -0500 [thread overview]
Message-ID: <50EC7DAF.8030606@redhat.com> (raw)
In-Reply-To: <50CB3662.5080100@redhat.com>
Upstream commit 9e368fa0 added function ipmi_pnp_probe(), which
calls try_smi_init() directly.
try_smi_init() allocates resources for IPMI driver. However
try_smi_init() can be called again, and the allocated resources
can be unexpectedly released when the same IPMI resource
information is found on both ACPI namespace and SMBIOS table.
ipmi_pnp_probe() should call add_smi() instead of try_smi_init()
For reference, see upstream commit ...
2407d77a1a013b88ee3b817f2b934e420e5376f5
Signed-off-by: Tony Camuso <tcamuso@redhat.com>
---
drivers/char/ipmi/ipmi_si_intf.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index afb89be..20d13c6 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2223,7 +2223,7 @@ static int __devinit ipmi_pnp_probe(struct pnp_dev *dev,
info->dev = &dev->dev;
pnp_set_drvdata(dev, info);
- return try_smi_init(info);
+ return add_smi(info);
err_free:
kfree(info);
--
1.7.1
next prev parent reply other threads:[~2013-01-08 20:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 18:40 [PATCH] ipmi: add new kernel options to prevent automatic ipmi init Tony Camuso
2012-12-13 19:51 ` Corey Minyard
2012-12-14 14:23 ` Tony Camuso
2012-12-14 14:23 ` Tony Camuso
[not found] ` <50CB3662.5080100-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-01-08 20:12 ` Tony Camuso [this message]
2013-01-08 20:12 ` [PATCH] ipmi: replace call to try_smi_init() with call to add_smi() Tony Camuso
[not found] ` <50EC7DAF.8030606-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-01-09 13:39 ` Tony Camuso
2013-01-09 13:39 ` Tony Camuso
[not found] ` <50CA38CE.2040005@redhat.com>
[not found] ` <AC1B83CE65082B4DBDDB681ED2F6B2EF023202A7@EXHQ.corp.stratus.com>
2012-12-14 16:25 ` [PATCH] ipmi: add new kernel options to prevent automatic ipmi init Evans, Robert
2012-12-14 16:25 ` Evans, Robert
2012-12-14 17:02 ` Corey Minyard
2012-12-17 21:14 ` Evans, Robert
2012-12-17 21:14 ` Evans, Robert
[not found] ` <AC1B83CE65082B4DBDDB681ED2F6B2EF023202B4-d72qy8bFiXh4vSn6MaHdYpqQE7yCjDx5@public.gmane.org>
2012-12-21 21:38 ` Evans, Robert
2012-12-21 21:38 ` Evans, Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EC7DAF.8030606@redhat.com \
--to=tcamuso-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=k-tanaka-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=minyard-HInyCGIudOg@public.gmane.org \
--cc=myamazak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=openipmi-developer-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=tcminyard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.