From: Jeff Garzik <jgarzik@pobox.com>
To: Joshua Coombs <josh.coombs@gmail.com>
Cc: cooloney@gmail.com, rpurdie@rpsys.net,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Allow Marvell SATA driver to work with LEDS_TRIGGER_IDE_DISK
Date: Wed, 09 Jan 2013 11:56:52 -0500 [thread overview]
Message-ID: <50EDA154.6060407@pobox.com> (raw)
In-Reply-To: <1357668987-3610-1-git-send-email-josh.coombs@gmail.com>
On 01/08/2013 01:16 PM, Joshua Coombs wrote:
> Add a call to the IDE LED Trigger within the Marvell SATA driver to allow
> Marvell SoC devices to show SATA activity via GPIO connected LEDs.
>
> Signed-off-by: Joshua Coombs <josh.coombs@gmail.com>
> ---
> drivers/ata/sata_mv.c | 3 +++
> drivers/leds/Kconfig | 3 +--
> 2 files changed, 4 insertions(+), 2 deletions(-)
NAK. This is not appropriate at the specific driver level. This would
be better implemented at a higher level.
WARNING: multiple messages have this Message-ID (diff)
From: jgarzik@pobox.com (Jeff Garzik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Allow Marvell SATA driver to work with LEDS_TRIGGER_IDE_DISK
Date: Wed, 09 Jan 2013 11:56:52 -0500 [thread overview]
Message-ID: <50EDA154.6060407@pobox.com> (raw)
In-Reply-To: <1357668987-3610-1-git-send-email-josh.coombs@gmail.com>
On 01/08/2013 01:16 PM, Joshua Coombs wrote:
> Add a call to the IDE LED Trigger within the Marvell SATA driver to allow
> Marvell SoC devices to show SATA activity via GPIO connected LEDs.
>
> Signed-off-by: Joshua Coombs <josh.coombs@gmail.com>
> ---
> drivers/ata/sata_mv.c | 3 +++
> drivers/leds/Kconfig | 3 +--
> 2 files changed, 4 insertions(+), 2 deletions(-)
NAK. This is not appropriate at the specific driver level. This would
be better implemented at a higher level.
next prev parent reply other threads:[~2013-01-09 16:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 18:16 [PATCH] Allow Marvell SATA driver to work with LEDS_TRIGGER_IDE_DISK Joshua Coombs
2013-01-08 18:16 ` Joshua Coombs
2013-01-08 19:06 ` Jason Cooper
2013-01-08 19:06 ` Jason Cooper
2013-01-08 19:18 ` Josh Coombs
2013-01-08 19:18 ` Josh Coombs
2013-01-08 20:03 ` Jason Cooper
2013-01-08 20:03 ` Jason Cooper
2013-01-09 1:29 ` Kim, Milo
2013-01-09 1:29 ` Kim, Milo
2013-01-09 16:19 ` Josh Coombs
2013-01-09 16:19 ` Josh Coombs
2013-01-09 16:56 ` Jeff Garzik [this message]
2013-01-09 16:56 ` Jeff Garzik
2013-01-09 18:45 ` Josh Coombs
2013-01-09 18:45 ` Josh Coombs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EDA154.6060407@pobox.com \
--to=jgarzik@pobox.com \
--cc=cooloney@gmail.com \
--cc=josh.coombs@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.