Re: [Qemu-devel] [PATCH V2 06/11] qmp: add interface query-images.

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]

On 01/08/2013 10:12 PM, Wenchao Xia wrote:
>   This mirror function will return all image info including
> snapshots. Now Qemu have both query-images and query-block
> interfaces.
> 
> V2:
>   Redesign the interface, it will show related block device name now.
>   Added counter part in qmp-commands.hx.
>   Using plurals in API name.

Again, patch evolution changelog belongs after the S-o-b and (first) ---
line.

> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>  block.c          |   19 +++++++++++++
>  qapi-schema.json |   27 +++++++++++++++++++
>  qmp-commands.hx  |   76 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 122 insertions(+), 0 deletions(-)
> 

>  ##
> +# @DeviceImageInfo:
> +#
> +# Information about image used by QEMU block device

s/image/an image/

>  
>  SQMP
> +query-images
> +-----------
> +
> +Show the block devices's images.

s/devices's/devices'/

> +
> +Each block image information is stored in a json-object and the returned value
> +is a json-array of all devices's image.

s/devices's image/devices' images/

The example is nice.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]