From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: Eric Blake <eblake@redhat.com>
Cc: aliguori@us.ibm.com, phrdina@redhat.com, stefanha@gmail.com,
qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com,
lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH V2 03/11] block: add snapshot and image info query function
Date: Fri, 11 Jan 2013 11:18:00 +0800 [thread overview]
Message-ID: <50EF8468.5000202@linux.vnet.ibm.com> (raw)
In-Reply-To: <50EEC3C0.6030305@redhat.com>
于 2013-1-10 21:36, Eric Blake 写道:
> On 01/09/2013 10:43 PM, Wenchao Xia wrote:
>
>>>>
>>>> v2:
>>>
>>> Generally, the v2 information should go...
>>>
>> Do you know how to put change log under "---" in "git commit"?
>> I found it inconvenient to edit every ".patch" file, so added the
>> log directly in commit message.
>
> Sure - manually put a --- as part of your commit message. 'git am'
> doesn't care if there is more than one ---. It does mean that you have
> to float your S-o-b higher by hand, but doing it at commit time is
> easier than doing post-editing of every .patch file at send-email time.
> Also, if you are editing a v2 of an existing series, you probably
> already have a S-o-b line in the commit message that you are amending,
> making it easy to scroll to the bottom, add ---, and then your v2 info.
>
Thank you very much, this really helps.
--
Best Regards
Wenchao Xia
next prev parent reply other threads:[~2013-01-11 3:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 5:12 [Qemu-devel] [PATCH V2 00/11] add qmp/hmp interfaces for snapshot info Wenchao Xia
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 01/11] qemu-img: remove unused parameter in collect_image_info() Wenchao Xia
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 02/11] block: add bdrv_get_filename() function Wenchao Xia
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 03/11] block: add snapshot and image info query function Wenchao Xia
2013-01-09 15:56 ` Eric Blake
2013-01-10 5:43 ` Wenchao Xia
2013-01-10 13:36 ` Eric Blake
2013-01-11 3:18 ` Wenchao Xia [this message]
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 04/11] qemu-img: switch image retrieving function Wenchao Xia
2013-01-09 16:27 ` Eric Blake
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 05/11] block: rename bdrv_query_info to bdrv_query_block_info Wenchao Xia
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 06/11] qmp: add interface query-images Wenchao Xia
2013-01-09 22:53 ` Eric Blake
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 07/11] block: export function bdrv_find_snapshot() Wenchao Xia
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 08/11] qmp: add interface query-snapshots Wenchao Xia
2013-01-09 23:04 ` Eric Blake
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 09/11] hmp: export function hmp_handle_error() Wenchao Xia
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 10/11] hmp: retrieve info from qmp for snapshot info Wenchao Xia
2013-01-09 5:12 ` [Qemu-devel] [PATCH V2 11/11] hmp: show snapshot on single block device Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EF8468.5000202@linux.vnet.ibm.com \
--to=xiawenc@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=phrdina@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.