* [Ocfs2-devel] [PATCH] Remove unecessary ocfs2_iocb_clear_sem_locked
@ 2013-01-09 17:01 Goldwyn Rodrigues
2013-01-10 1:07 ` Junxiao Bi
0 siblings, 1 reply; 2+ messages in thread
From: Goldwyn Rodrigues @ 2013-01-09 17:01 UTC (permalink / raw)
To: ocfs2-devel
Since 2dfd06036ba7ae8e7be2daf5a2fff1dac42390bf, the private field of
kiocb is initialized in init_sync_kiocb(). This obviates the need to
clear the OCFS2_IOCB_SEM bits. This will save a few cycles/flushes.
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
---
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
index 37d313e..2946c3e 100644
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
@@ -2254,8 +2254,6 @@ static ssize_t ocfs2_file_aio_write(struct kiocb *iocb,
mutex_lock(&inode->i_mutex);
- ocfs2_iocb_clear_sem_locked(iocb);
-
relock:
/* to match setattr's i_mutex -> rw_lock ordering */
if (direct_io) {
@@ -2560,8 +2558,6 @@ static ssize_t ocfs2_file_aio_read(struct kiocb *iocb,
goto bail;
}
- ocfs2_iocb_clear_sem_locked(iocb);
-
/*
* buffered reads protect themselves in ->readpage(). O_DIRECT reads
* need locks to protect pending reads from racing with truncate.
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Ocfs2-devel] [PATCH] Remove unecessary ocfs2_iocb_clear_sem_locked
2013-01-09 17:01 [Ocfs2-devel] [PATCH] Remove unecessary ocfs2_iocb_clear_sem_locked Goldwyn Rodrigues
@ 2013-01-10 1:07 ` Junxiao Bi
0 siblings, 0 replies; 2+ messages in thread
From: Junxiao Bi @ 2013-01-10 1:07 UTC (permalink / raw)
To: ocfs2-devel
On 01/10/2013 01:01 AM, Goldwyn Rodrigues wrote:
> Since 2dfd06036ba7ae8e7be2daf5a2fff1dac42390bf, the private field of
> kiocb is initialized in init_sync_kiocb(). This obviates the need to
> clear the OCFS2_IOCB_SEM bits. This will save a few cycles/flushes.
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Fine to me.
Thanks,
Junxiao
>
> ---
> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
> index 37d313e..2946c3e 100644
> --- a/fs/ocfs2/file.c
> +++ b/fs/ocfs2/file.c
> @@ -2254,8 +2254,6 @@ static ssize_t ocfs2_file_aio_write(struct kiocb *iocb,
>
> mutex_lock(&inode->i_mutex);
>
> - ocfs2_iocb_clear_sem_locked(iocb);
> -
> relock:
> /* to match setattr's i_mutex -> rw_lock ordering */
> if (direct_io) {
> @@ -2560,8 +2558,6 @@ static ssize_t ocfs2_file_aio_read(struct kiocb *iocb,
> goto bail;
> }
>
> - ocfs2_iocb_clear_sem_locked(iocb);
> -
> /*
> * buffered reads protect themselves in ->readpage(). O_DIRECT reads
> * need locks to protect pending reads from racing with truncate.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-10 1:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-09 17:01 [Ocfs2-devel] [PATCH] Remove unecessary ocfs2_iocb_clear_sem_locked Goldwyn Rodrigues
2013-01-10 1:07 ` Junxiao Bi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.