From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Michael Trimarchi <michael@amarulasolutions.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v3] gpio: twl4030: Cache the direction and output states in private data
Date: Thu, 10 Jan 2013 14:09:35 +0100 [thread overview]
Message-ID: <50EEBD8F.6040101@ti.com> (raw)
In-Reply-To: <CACRpkdZK8AA-osijVpbp7U-Wv0XUAVxDPQ3zxfCqWYb6WKjmwQ@mail.gmail.com>
Hi Linus,
On 01/10/2013 11:41 AM, Linus Walleij wrote:
> On Thu, Dec 20, 2012 at 10:44 AM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
>
>> Use more coherent locking in the driver. Use bitfield to store the GPIO
>> direction and if the pin is configured as output store the status also in a
>> bitfiled.
>> In this way we can just look at these bitfields when we need information
>> about the pin status and only reach out to the chip when it is needed.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>> ---
>> Hi Grant,
>>
>> Changes sicne v2:
>> - Fixed the mutex_unlock found by Michael.
>> - Removed the debug prints addedd by v2 patch (remains from debugging)
>> - Removed one blank line between includes and the first comment section.
>
> Sorry Peter this must have been missed somehow.
>
> This does not apply to the current v3.8-rc3, could you respin
> this on top of Torvalds' tree?
Grant applied the patch which this one depends on:
[1] https://patchwork.kernel.org/patch/1844511/
Not sure where.
There were a third patch in v2 as well. I'm not sure about the status of that.
[1] + this patch applies cleanly on top of mainline.
Should I resend the series as v4 for your convenience?
--
Péter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Michael Trimarchi <michael@amarulasolutions.com>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v3] gpio: twl4030: Cache the direction and output states in private data
Date: Thu, 10 Jan 2013 14:09:35 +0100 [thread overview]
Message-ID: <50EEBD8F.6040101@ti.com> (raw)
In-Reply-To: <CACRpkdZK8AA-osijVpbp7U-Wv0XUAVxDPQ3zxfCqWYb6WKjmwQ@mail.gmail.com>
Hi Linus,
On 01/10/2013 11:41 AM, Linus Walleij wrote:
> On Thu, Dec 20, 2012 at 10:44 AM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
>
>> Use more coherent locking in the driver. Use bitfield to store the GPIO
>> direction and if the pin is configured as output store the status also in a
>> bitfiled.
>> In this way we can just look at these bitfields when we need information
>> about the pin status and only reach out to the chip when it is needed.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>> ---
>> Hi Grant,
>>
>> Changes sicne v2:
>> - Fixed the mutex_unlock found by Michael.
>> - Removed the debug prints addedd by v2 patch (remains from debugging)
>> - Removed one blank line between includes and the first comment section.
>
> Sorry Peter this must have been missed somehow.
>
> This does not apply to the current v3.8-rc3, could you respin
> this on top of Torvalds' tree?
Grant applied the patch which this one depends on:
[1] https://patchwork.kernel.org/patch/1844511/
Not sure where.
There were a third patch in v2 as well. I'm not sure about the status of that.
[1] + this patch applies cleanly on top of mainline.
Should I resend the series as v4 for your convenience?
--
Péter
next prev parent reply other threads:[~2013-01-10 13:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 9:44 [PATCH v3] gpio: twl4030: Cache the direction and output states in private data Peter Ujfalusi
2012-12-20 9:44 ` Peter Ujfalusi
2013-01-10 10:41 ` Linus Walleij
2013-01-10 13:09 ` Peter Ujfalusi [this message]
2013-01-10 13:09 ` Peter Ujfalusi
2013-01-17 10:43 ` Linus Walleij
2013-01-17 13:45 ` Peter Ujfalusi
2013-01-17 13:45 ` Peter Ujfalusi
2013-02-09 14:15 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EEBD8F.6040101@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=michael@amarulasolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.