All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Danny Kukawka <danny.kukawka@bisect.de>,
	Jesper Juhl <jj@chaosbits.net>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] dac960: return success instead of -ENOTTY
Date: Fri, 11 Jan 2013 10:27:56 +0000	[thread overview]
Message-ID: <50EFE92C.4080209@kernel.dk> (raw)
In-Reply-To: <20130111065244.GD13207@elgon.mountain>

On 2013-01-11 07:52, Dan Carpenter wrote:
> There is a missing break statement here.  This used to return directly
> but we re-worked it in 2008 to add locking as part of the BKL push down.

Thanks Dan, applied. Must have a big user base...

-- 
Jens Axboe


WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Danny Kukawka <danny.kukawka@bisect.de>,
	Jesper Juhl <jj@chaosbits.net>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] dac960: return success instead of -ENOTTY
Date: Fri, 11 Jan 2013 11:27:56 +0100	[thread overview]
Message-ID: <50EFE92C.4080209@kernel.dk> (raw)
In-Reply-To: <20130111065244.GD13207@elgon.mountain>

On 2013-01-11 07:52, Dan Carpenter wrote:
> There is a missing break statement here.  This used to return directly
> but we re-worked it in 2008 to add locking as part of the BKL push down.

Thanks Dan, applied. Must have a big user base...

-- 
Jens Axboe


  reply	other threads:[~2013-01-11 10:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-11  6:52 [patch] dac960: return success instead of -ENOTTY Dan Carpenter
2013-01-11  6:52 ` Dan Carpenter
2013-01-11 10:27 ` Jens Axboe [this message]
2013-01-11 10:27   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50EFE92C.4080209@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=dan.carpenter@oracle.com \
    --cc=danny.kukawka@bisect.de \
    --cc=jj@chaosbits.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.