Re: [PATCH] The BUG() macro should print the correct architecture, not a hardcoded value.

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 11/01/13 13:20, Ian Campbell wrote:
> On Fri, 2013-01-11 at 13:15 +0000, lra@sics.se wrote:
>> From: Lars Rasmusson <Lars.Rasmusson@sics.se>
>>
>> Signed-off-by: Lars Rasmusson <Lars.Rasmusson@sics.se>
>> ---
>>  xen/arch/arm/traps.c |   18 +++++++++++++++++-
>>  1 file changed, 17 insertions(+), 1 deletion(-)
>>
>> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
>> index f42e4e9..1909abf 100644
>> --- a/xen/arch/arm/traps.c
>> +++ b/xen/arch/arm/traps.c
>
>> @@ -68,7 +68,23 @@ static void print_xen_info(void)
>>      debug = 'y';
>>  #endif
>>  
>> -    printk("----[ Xen-%d.%d%s  x86_64  debug=%c  %s ]----\n",
> Oops!
>
>> +#ifdef CONFIG_ARM_32
>> +#define THE_ARCH "arm_32"
>> +#elif CONFIG_ARM_64
>> +#define THE_ARCH "arm_64"
> Since this is xen/arch/*arm*/traps.c you only need to handle these two
> cases.
>
> Ian.

Is there not a -D available from the Makefiles which would be
appropriate, to save having to change this every time a new architecture
is added?

~Andrew

>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel