All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom de Vries <vries@codesourcery.com>
To: aurelien@aurel32.net
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@redhat.com>
Subject: [Qemu-devel] [PATCH 02/14] target-mips: use the softfloat	floatXX_muladd functions
Date: Fri, 11 Jan 2013 14:23:55 +0100	[thread overview]
Message-ID: <50F0126B.6080106@codesourcery.com> (raw)

Aurelien,

> @@ -8307,7 +8307,7 @@ static void gen_flt3_arith (DisasContext *ctx, uint32_t 
> opc,
>              gen_load_fpr64(ctx, fp0, fs);
>              gen_load_fpr64(ctx, fp1, ft);
>              gen_load_fpr64(ctx, fp2, fr);
> -            gen_helper_float_muladd_d(fp2, cpu_env, fp0, fp1, fp2);
> +            gen_helper_float_madd_d(fp2, cpu_env, fp0, fp1, fp2);
>              tcg_temp_free_i64(fp0);
>              tcg_temp_free_i64(fp1);
>              gen_store_fpr64(ctx, fp2, fd);

AFAIU:
- you're replacing here a non-fused mAC with a fused MAC and
- for all mips cores (except the r8000) the madd.d is non-fused.
So shouldn't we use a non-fused MAC here?

Thanks,
- Tom

             reply	other threads:[~2013-01-11 13:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-11 13:23 Tom de Vries [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-10-09 20:27 [Qemu-devel] [PATCH 00/14] target-mips: misc fixes and optimizations Aurelien Jarno
2012-10-09 20:27 ` [Qemu-devel] [PATCH 02/14] target-mips: use the softfloat floatXX_muladd functions Aurelien Jarno
2012-10-10 19:58   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F0126B.6080106@codesourcery.com \
    --to=vries@codesourcery.com \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.