All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Wolfgang Mauerer <wolfgang.mauerer@siemens.com>,
	qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>,
	paul@codesourcery.com
Subject: Re: [Qemu-devel] [PATCH] Realview/Versatile: Export LED state
Date: Fri, 11 Jan 2013 16:23:19 +0100	[thread overview]
Message-ID: <50F02E67.4080804@suse.de> (raw)
In-Reply-To: <CAFEAcA-TC1FMQ96QrbS2f9K4yytgHa-GD-yDc1w35gpDJy7oNQ@mail.gmail.com>

Am 11.01.2013 16:00, schrieb Peter Maydell:
> On 11 January 2013 13:42, Wolfgang Mauerer <wolfgang.mauerer@siemens.com> wrote:
>> The configuration register for the onboard LEDs is
>> emulated, but the state is not exported, which makes
>> the feature not particularly useful. Create a character
>> device to make status changes accessible to the host.
>>
>> For example, use the command line argument
>>
>> -chardev socket,id=leds,host=localhost,port=12345,server,nowait
>>
>> to observe status changes via a socket.
> 
> This isn't the only board we emulate which has LEDs. I'd
> rather see this problem tackled with a general plan for "this
> is how we handle LEDs in QEMU boards" rather than a
> versatile board specific patch.

Hm, mips_malta.c does use a CharDriverState... just a more "structured"
one using ASCII art.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2013-01-11 15:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-11 13:42 [Qemu-devel] [PATCH] Realview/Versatile: Export LED state Wolfgang Mauerer
2013-01-11 14:58 ` Andreas Färber
2013-01-11 15:46   ` Wolfgang Mauerer
2013-01-11 15:00 ` Peter Maydell
2013-01-11 15:23   ` Andreas Färber [this message]
2013-01-11 15:44     ` Wolfgang Mauerer
2013-01-11 20:22       ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F02E67.4080804@suse.de \
    --to=afaerber@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=paul@codesourcery.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wolfgang.mauerer@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.